Miika Pekkarinen
2e884cc85f
Revert back the previous commit, there are some problems with id3
...
fields to be solved.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7167 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:37:03 +00:00
Miika Pekkarinen
54395bbf3d
Don't read metadata twice.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7163 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:13:13 +00:00
Miika Pekkarinen
b6048c49ba
Don't hang when trying to stop paused playback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7159 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 18:42:01 +00:00
Miika Pekkarinen
34a25a6a3b
Fixed a problem that caused playback to stutter when changing tracks
...
fast.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7157 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 16:42:01 +00:00
Miika Pekkarinen
2159811c66
Fixed a problem that cpu boost didn't always reset when stopping the
...
playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7153 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 07:57:09 +00:00
Miika Pekkarinen
20b3897474
Separated buffering stuff from pcm_playback to pcmbuf. Renamed some
...
function calls (audiobuffer -> pcmbuf etc.).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7131 a1c6a512-1295-4272-9138-f99709370657
2005-07-13 12:48:22 +00:00
Ryan Jackson
d191756286
Resume now starts playback at the point it was stopped, not 2-7 seconds later.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7125 a1c6a512-1295-4272-9138-f99709370657
2005-07-12 16:45:38 +00:00
Miika Pekkarinen
2f6781d616
Resetting the pause indicator when seeking songs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7109 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 20:43:02 +00:00
Linus Nielsen Feltzing
c4b7c671f9
Patch #1235763 by Ryan Jackson - Resume/bookmark support for Vorbis
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7098 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 06:47:35 +00:00
Miika Pekkarinen
0d63cbba4b
Fixed a problem with transition to next album which caused rockbox
...
virtually to crash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7096 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 20:37:36 +00:00
Miika Pekkarinen
1ed292ca5e
Fixed an audio burst coming out when pausing a track with fading
...
enabled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7095 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 17:31:12 +00:00
Miika Pekkarinen
645a2e16ed
Fixed a simulator crash while trying to play a song. Fixed crossfade
...
when selecting a new track to play. Most likely fixed a bug which
caused playback to stop on track change.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7094 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 16:33:03 +00:00
Miika Pekkarinen
a9203b4d83
Updating wps info correctly when changing a track while buffering.
...
Fixed the delay while seeking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7093 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:54:19 +00:00
Miika Pekkarinen
527ce403ea
The previous commit did not fix the metadata reading correctly. Now it
...
should have been fixed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7092 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:46:12 +00:00
Miika Pekkarinen
b288dda685
Fixed a problem that next track info was not always available after the
...
initial file buffering.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7091 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:38:16 +00:00
Miika Pekkarinen
3e33f85f17
Track changing works now better (not still perfect).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7090 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 06:58:02 +00:00
Miika Pekkarinen
5d9e0536ea
Some playback fixes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7076 a1c6a512-1295-4272-9138-f99709370657
2005-07-08 20:01:06 +00:00
Linus Nielsen Feltzing
df80798a30
Lame hack to strip ID3v1 tags from MP3 playback, so they can play back without gaps
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7054 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 09:53:02 +00:00
Miika Pekkarinen
3eb962d13b
PCM buffering fixes. Made a temporary workaround for playback glitch
...
bug (see the patch).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7049 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 07:15:05 +00:00
Linus Nielsen Feltzing
ffd207f4b0
Makes sure that the pause/resume/prev/next functions are executed in the audio thread
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7043 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 19:40:17 +00:00
Miika Pekkarinen
22960c3f95
Waiting pcm buffer to run empty before stopping the last track.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7040 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 15:44:59 +00:00
Miika Pekkarinen
5c2c991d14
Applied patch "[ 1232957 ] MP3 metadata fixes for software codec".
...
Thanks to Magnus Holmgren. Now metadata reading is better with
improved performance for mp3 files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7030 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 19:55:40 +00:00
Miika Pekkarinen
3e33a0f8ee
More crossfade adjustments. Now crossfade should work shortly even if
...
the disk was not spinning while a new track was loaded from the disk.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7028 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 15:51:59 +00:00
Miika Pekkarinen
d6e7942426
Fixed: Crossfading, broken elapsed info with mp3 files, possible cpu
...
boost problem and track changing.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7027 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 15:19:22 +00:00
Miika Pekkarinen
2d79df5086
Fixed a problem that caused playback to stop on certain situations. Fixed
...
buffer filling issue if we try to buffer more than MAX_TRACK tracks at
a same time.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7026 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 13:34:52 +00:00
Miika Pekkarinen
aa30f0483b
Fixed crossfading.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7022 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 07:25:55 +00:00
Hardeep Sidhu
839dbcaed7
Moved resume info updating to the mpeg/playback threads so that it's saved even when not in the WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7018 a1c6a512-1295-4272-9138-f99709370657
2005-07-04 22:50:57 +00:00
Miika Pekkarinen
8ad60cced2
Update the wps when next track info is available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7005 a1c6a512-1295-4272-9138-f99709370657
2005-07-04 06:06:30 +00:00
Miika Pekkarinen
e21cf8440a
Fixed the warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6997 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 19:20:40 +00:00
Miika Pekkarinen
9bde0380a6
Updated the track_unbuffer event callback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6995 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 18:36:24 +00:00
Miika Pekkarinen
f46c9f204c
Now next track info is always available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6994 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 18:03:20 +00:00
Jens Arnold
bb3ed3cda9
Use the central IDATA_ATTR define.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6992 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 15:09:11 +00:00
Miika Pekkarinen
d50ed1248d
The last small fix to the previous commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6990 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:55:51 +00:00
Miika Pekkarinen
837c1e3cad
Correction to the previous commit when switching tracks manually.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6989 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:49:13 +00:00
Miika Pekkarinen
b469e73246
Use correct timing to display the next track wps screen when crossfade
...
is activated.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6988 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:45:12 +00:00
Miika Pekkarinen
9c70b1b562
Make sure we stop the playback the right way.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6987 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:03:19 +00:00
Miika Pekkarinen
d54811fe22
Fixed mono playback support for mp3. Added two other event handlers in
...
playback.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6986 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 16:52:30 +00:00
Miika Pekkarinen
2724d0bb55
Pause correctly while seeking.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6975 a1c6a512-1295-4272-9138-f99709370657
2005-07-01 21:00:02 +00:00
Miika Pekkarinen
c520d69f68
Fixed codec switching.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6974 a1c6a512-1295-4272-9138-f99709370657
2005-07-01 18:38:10 +00:00
Miika Pekkarinen
bbd42ad80b
Fixed seeking in mp3 files (and with other codecs which supports
...
seeking currently). Even long seeks should be possible.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6973 a1c6a512-1295-4272-9138-f99709370657
2005-07-01 18:22:04 +00:00
Miika Pekkarinen
3b90707fdd
Fixed a bug where a few seconds from end of a song was cut out.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6951 a1c6a512-1295-4272-9138-f99709370657
2005-06-30 16:28:40 +00:00
Dave Bryant
1983738ea1
Not sure if this is the right way to make "resume" work correctly for WavPack,
...
but it seems to work and if it's wrong it should only affect WavPack...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6938 a1c6a512-1295-4272-9138-f99709370657
2005-06-30 06:09:59 +00:00
Miika Pekkarinen
7d6d122441
Added event handler to register track changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6936 a1c6a512-1295-4272-9138-f99709370657
2005-06-29 21:36:30 +00:00
Miika Pekkarinen
7b7d1e6802
Always use crossfade if it's enabled.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6933 a1c6a512-1295-4272-9138-f99709370657
2005-06-29 21:13:46 +00:00
Miika Pekkarinen
84d6f9e89b
Fixed slow track switching and track pre-buffering. Fixed rockboy
...
crash while audio is playing. Some buffering adjustments made.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6930 a1c6a512-1295-4272-9138-f99709370657
2005-06-29 20:50:58 +00:00
Miika Pekkarinen
de3b04ee28
Fixed buffering problems with dynamic playlist handling. Increased
...
codec buffer default watermark to prevent skipping.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6922 a1c6a512-1295-4272-9138-f99709370657
2005-06-29 14:46:27 +00:00
Miika Pekkarinen
85f4973106
Replaced some size_t with longs. That might solve some problems. Fixed
...
also problem where codec buffer length indicator goes negative.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6898 a1c6a512-1295-4272-9138-f99709370657
2005-06-27 19:29:49 +00:00
Miika Pekkarinen
65b840dbd1
Fixed one warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6878 a1c6a512-1295-4272-9138-f99709370657
2005-06-26 20:01:33 +00:00
Miika Pekkarinen
d8cb703b1e
Initial DSP implementation. DSP supports resampling audio stream from
...
codecs (currently works corrently only with mp3's, somebody should fix
that).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6877 a1c6a512-1295-4272-9138-f99709370657
2005-06-26 19:41:29 +00:00
Linus Nielsen Feltzing
17098e1c08
More audio thread debug info
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6820 a1c6a512-1295-4272-9138-f99709370657
2005-06-22 20:37:31 +00:00