1
0
Fork 0
forked from len0rd/rockbox
Commit graph

7856 commits

Author SHA1 Message Date
Nicolas Pennequin
0c7b26d3a7 Readd yield_codec, making it check for useful data through buffer_is_low. Fixes the PCM buffer underruns.
Also move update_data_counters and make it static.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15487 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 21:11:54 +00:00
Brandon Low
287f14b8ca This was a bad change on my part earlier. Do not immediately start buffering codecs when they are bufopened
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15486 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:58:50 +00:00
Brandon Low
405380e57f Don't keep resetting to default watermark during buffering, only do it once at play start
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15485 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:54:22 +00:00
Nicolas Pennequin
aef008b061 Set all track handles to -1 on audio init to avoid calling bufclose(0) on all of them on the first playback stop. This also revealed a bug in audio_release_tracks where it wouldn't release all the tracks because the wrong #define value was used.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15484 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:46:25 +00:00
Nicolas Pennequin
6631e36fa7 Fix some logf warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15483 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:19:38 +00:00
Brandon Low
b46175c202 Don't if this, it's a good idea for codecs to explicit seek
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15482 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:16:13 +00:00
Brandon Low
3f69930aa0 Fix mp3 resume
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15481 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 18:15:52 +00:00
Brandon Low
86830b6566 Create two separate ways for a handle buffer request to be sent. One is when the buffer has gotten low, in this case, we want to start a buffer fill. The other is when the buffer itself requests a buffer as part of a running fill. Obviously this is not a new fill start
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15480 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 17:51:55 +00:00
Brandon Low
76f9bfa945 When seeking foward off of the buffer, if it is a short seek don't rebuffer the whole track, just read enough to satisfy
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15479 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 17:50:51 +00:00
Brandon Low
3379440a4b Remove conf_filechunk, it should never have been a setting and its implementation doesn't do what it claims any way
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15478 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 17:48:21 +00:00
Brandon Low
1df1e7b0c7 Remove unused conf_preseek from buffering.c and all of its accountraments. This is _not_ a setting. This is a guessing tool used by either playback or buffering to serve its clients better. Use the REBUFFER_GUESS size in resume to help obviate pondlife's bug. This will also need to be used when FS8092 gets fixed correctly with a complete rebuffer for backward movements. It may also belong in buffering not playback, haven't decided for sure
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15475 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 16:02:12 +00:00
Brandon Low
560515fba1 Minor improvement in responsiveness to buffer_handle calls
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15473 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 15:47:40 +00:00
Brandon Low
555a764dad logging improvements
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15472 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 15:24:21 +00:00
Jonathan Gordon
91ccc01bcf fix FS#7288 - pad the title of the scrolling settings so they actually scroll
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15469 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 13:15:35 +00:00
Stepan Moskovchenko
bdfe87c0f1 MIDI: Make seeking neater by moving it into another file. Will be more useful later.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15467 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 05:35:10 +00:00
Brandon Low
47eb569b62 SHould fix FS#8074, is more better regardless though
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15466 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 03:11:58 +00:00
Brandon Low
d02b5c744e Don't keep useless id3v2 or other leading tag data on the buffer, it could be large
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15465 a1c6a512-1295-4272-9138-f99709370657
2007-11-05 01:56:12 +00:00
Robert Kukla
ca1b920896 Fix for FS#8082:
runtime data fields are filled like any other fields in the mp3entry struct during the call to get_metadata(); HWCODEC still uses the old callback mechanism

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15463 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 21:11:40 +00:00
Brandon Low
31c1164c49 make handle_id of zero valid, stop using memsets to clear tracks, should be no functional changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15462 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 19:01:02 +00:00
Paul Louden
66f0cb2f60 FS#7232 - Fix some inconsistencies within the Sansa keymap. Makes it
easier to use with one thumb, a little more symmetrical for lefties, and 
a little more consistent both within the scope of the e200 target and 
cross-target. Manual should be updated with the changes.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15461 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 18:01:34 +00:00
Jonathan Gordon
04d0e3bc41 fix talking simplelists which I broke yesterday. dont talk if the list is being redrawn because get_action() timed out.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15459 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 12:52:32 +00:00
Jonathan Gordon
a6f2b82803 revert my previous commit and do it in a much less hacky way (both of these were for FS#8084)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 12:40:18 +00:00
Jonathan Gordon
62decc42e7 return to the main menu if stop is pressed in the wps context menu, (blame pondlife for the hack :D )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 12:10:41 +00:00
Jonathan Gordon
4ada9ed2d9 last minor fix for the colour screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15456 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 10:57:06 +00:00
Jonathan Gordon
eb20149804 minor touchpad tweaking...
lists - dont do ACTION_STD_OK if pressing an area under the last item
colour chooser - change the seelcted colour straight away without having to swicth sliders first


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15455 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 10:51:11 +00:00
Jonathan Gordon
fd9bad6597 touchpad interface for the colour selection screens.
voice the unacceptable colour splash (nice and pointless :p )


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15454 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 10:42:22 +00:00
Brandon Low
2ecb3231c6 More residuals from 8077, sanitize chunk and watermark settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15452 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 06:01:46 +00:00
Brandon Low
ebc981b233 More residuals from 8077 that should make buffering start up more smoothly and complete more completely
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15451 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 05:57:48 +00:00
Brandon Low
f906498786 OTher part of previous
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15450 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 05:36:35 +00:00
Brandon Low
e8fa7f94b0 More attempt to fix 8077
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15449 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 05:33:06 +00:00
Brandon Low
3817acc682 Tweak the way the data_counters are calculated to make it more friendly to the potential read-during-write, probably has very little impact on the compiled code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15448 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 05:15:41 +00:00
Brandon Low
aabd6885bf More try to fix 8077, BUF_USED is not a good way to determine if the buffer is healthy any more, we'll need a enw way if we need to resurrect yield_codec later
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15447 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 02:40:24 +00:00
Jonathan Gordon
e247230e0d redraw the siplelist more often
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15446 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 01:04:10 +00:00
Brandon Low
1c36a660ea Disable the already spinning optimization until it is written correctly
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15445 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 00:23:22 +00:00
Jens Arnold
33acc66256 * Add newfound GPO32 register to pp502x.h. * Introduce macros for the PP502x's atomic GPIO bit manipulation feature. * Remove clock setup related registers from debug screen, and add DEV_EN2, DEV_EN3 (to be verified) and GPO32 instead.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15443 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 22:47:27 +00:00
Brandon Low
9784f6b752 Make the use of signed int for buffer handles consistent and handle wrapping better. Number of handle_ids available is unchanged by this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15442 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 22:06:56 +00:00
Brandon Low
7b74dd7574 Attempt to fix FS#8077... again
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15441 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 21:57:27 +00:00
Brandon Low
0c97493a88 This part was good, bring it back
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15440 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 21:55:24 +00:00
Brandon Low
c2e1cc1e39 Revert recent changes that are broken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15439 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 21:48:08 +00:00
Brandon Low
19eae2bd9b Bump hid to 32bit to make sure it's safe
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15438 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 21:20:42 +00:00
Brandon Low
acb3e9af22 Make handle id semantics more like file id. This may need to be revisited if we ever start storing long lived things on the buffer (if an item lives through 32k other items coming and going, there will be an id collision and things will break)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15437 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 21:13:15 +00:00
Brandon Low
60d4e7c9c4 Buffering consistency improvements
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15436 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 17:55:45 +00:00
Brandon Low
86919f4609 Misc. buffering related playback tweaks
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15435 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 17:55:29 +00:00
Alessio Lenzi
a7905da890 Updated italian translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15434 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 16:14:11 +00:00
Mustapha Senhaji
24de1219d6 Update the french translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15429 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 11:43:27 +00:00
Mustapha Senhaji
d6cbbb8477 FS#8079 Update finnish translation by Jani Kinnunen (and fix a typo by me).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15428 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 11:10:36 +00:00
Jens Arnold
c9fca1e69c Show exact CPU version on PP5002 targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15427 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 08:09:07 +00:00
Stepan Moskovchenko
3be1ca0281 MIDI: Improve seeking (especially near the end of the file) by disabling playback during the seek. Next
step is to prevent delta value calculation during seeking, and just recompute the current deltas once 
seeking is over.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15426 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 06:31:33 +00:00
Brandon Low
11a3661d73 Make atomic type work for even first track. Rework low buffer handling... uses a stateful variable because I'm a bitter old man and it works this way
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15425 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 06:21:32 +00:00
Stéphane Doyon
fe2f1af0d3 Fix my mess in r15419: LANG_BATTERY_TOPOFF_CHARGE is only defined
when CONFIG_CHARGING == CHARGING_CONTROL.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15424 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 05:40:22 +00:00