Nicolas Pennequin
9cf8960c85
* Fix the bug where subline separators were read as part of a string.
...
* Some cosmetic code changes, no other functional change (add a comment and rename some variables).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13034 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 14:09:59 +00:00
Dan Everton
86c0e3a4ca
Rearrange struct wps_tag to avoid padding. Hopefully save some bytes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13033 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 10:21:49 +00:00
Nicolas Pennequin
29e18caacf
Allow subline timeout values to be changed dynamically in the WPS (e.g. by using conditionals).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13026 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:44:01 +00:00
Jens Arnold
7b8767c093
Player full-line progress bar: No more separate character cell(s) for the colon(s) in the time display. Looks better, and takes less software-definable characters, allowing for up to 99:59:59 with the last progress bar character still working properly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13023 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 23:18:35 +00:00
Jens Arnold
c6fce6cad3
Player progress drawing rewrite (both emptying cup and full-line bar): * Fixes FS #6820 , related to the glitch that progress moved in the opposite direction when seeking. * Smaller, more efficient code. * Full-line bar only displays as many software defined characters as needed, freeing the remaining ones for other text. * Don't cut last digit from times >=1 hour (at the cost of inexact last progress bar character).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13021 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 22:05:04 +00:00
Nicolas Pennequin
830a3a4720
* Make some private variables 'static'.
...
* Fix the pitch tag and allow it to be used on all targets except the Archos Player.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13020 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 15:47:51 +00:00
Nicolas Pennequin
ab90d58801
Introducing the WPS tokenizer !
...
When a WPS file is loaded, it is parsed to an array of tokens, which allows more efficient displaying. More info on the tracker entry : FS #6862 .
The parsing code is completely independant and is all in wps_parser.c. The displaying part stays in gwps-common.c.
Debugging code is provided (with the right ifdefs) and is disabled by default.
Overall, the code should be easier to read and maintain. Adding new WPS tags is made quite trivial.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13019 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 14:41:40 +00:00
Jens Arnold
2684e36724
Repair player progressbars (single char and full line) broken in the full unicode support move, and enable text alignment for charcell.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12993 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 17:32:12 +00:00
Jonathan Gordon
21165a3f3d
Recode filetypes.c to remove its need for a static string buffer.
...
Functional changes:
- filetypes.c handles the open with menu now instead of onplay.c
- automatic plugin registration no longer works (did anyone know about you could do this?)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12959 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 06:16:00 +00:00
Jens Arnold
ad4e3d6657
First step of charcell LCD code rework: * Make it fully unicode aware so that adding non-ISO8859-1 scripts becomes possible (limited by the LCD capabilities of course). * Make the API more similar to the bitmap LCD code's API. * Moved hardware dependent parts to target tree. * Simplified code. * Jumpscroll temporarily non-functional.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12916 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 07:52:13 +00:00
Jens Arnold
79c8a8cbbe
Let GCC check arguments of some more printf-style functions, also for plugins and codecs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12815 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:02:53 +00:00
Magnus Holmgren
1329d7d3fd
Fix occasional missing cursor when moving up in a list with a title when paged scrolling is on.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12814 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 07:30:33 +00:00
Jens Arnold
2c7b127dd7
Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12811 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 23:47:03 +00:00
Jens Arnold
4d6374c923
Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 21:56:08 +00:00
Nils Wallménius
e6a8d2186c
Make a couple of private functions 'static'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12770 a1c6a512-1295-4272-9138-f99709370657
2007-03-15 00:29:59 +00:00
Nils Wallménius
6485db3b37
Make a couple of private functions 'static'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12729 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 21:48:20 +00:00
Miika Pekkarinen
2eefb5acb8
Optimized the gui list code performance, including automatic frame dropping and cpu boosting when button events are getting queued. Improved scrollwheel acceleration code is needed to notice a real change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12721 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 10:52:36 +00:00
Jonathan Gordon
f83d6eb145
revert FS#6747 — y-margin reset in gui_list_draw, it introduced a nasty
...
scroll bug which isnt so simple to fix.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12719 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 08:05:05 +00:00
Jonathan Gordon
4949818c24
only call display->setmargins() once
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12706 a1c6a512-1295-4272-9138-f99709370657
2007-03-10 13:05:47 +00:00
Jonathan Gordon
a990ff2920
Accept FS#6747 by Timo Horstschäfer
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12704 a1c6a512-1295-4272-9138-f99709370657
2007-03-10 12:43:21 +00:00
Linus Nielsen Feltzing
298c2bbd83
Allow dynamic menu items to be spoken, especially the resume/now playing item
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12614 a1c6a512-1295-4272-9138-f99709370657
2007-03-05 00:32:33 +00:00
Robert Kukla
23c136c892
don't restart the whole wps to essentially update the display of runtime info, but make the concerned tags dynamic. Now scrolling is not restarted at end of buffering.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12592 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 16:09:18 +00:00
Jonathan Gordon
4de9fbeda6
Use the user font in the quickscreen if it fits. Still uses
...
LANG_SYSFONT_x...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12587 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 13:04:15 +00:00
Jonathan Gordon
5ea43ce8a9
thats what happens when you commit between dinner courses :p
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12582 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 08:35:20 +00:00
Jonathan Gordon
e6ba70548d
Fix red builds.
...
(Previous commit was for FS#6713 btw)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12581 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 08:05:33 +00:00
Jonathan Gordon
ca701bf62e
Add a function to get the actual button that was pressed (and some
...
status codes) instead of the action. Use this to figure out which screen
to do prev/next page on in the lists
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12580 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 07:45:12 +00:00
Jonathan Gordon
02a871780f
Remove the need to double up the MENU macros in manu.h.
...
Icons are now used by their id which must be part of the icons_6x8 enum,
or Icon_NOICON for none
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12571 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 13:52:14 +00:00
Jonathan Gordon
7ae5f12449
The list should reset the x margin when it finishes drawing. Not leave
...
it up to the next screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12570 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 13:42:12 +00:00
Robert Kukla
ae08eeb4ff
remove runtime detection of h1x0 series RTC MOD, but leave driver code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12554 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 00:11:20 +00:00
Robert Kukla
79a2a936a2
remove numerical genre and use genre_string consistently:
...
- fix spurious display of "blues" genre for missing genre tag
- simplify code/use less code
- numerical->string conversion only once instead of at every use
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12552 a1c6a512-1295-4272-9138-f99709370657
2007-03-02 21:49:42 +00:00
Jonathan Gordon
a9a9999ff4
fix usb disconnecting in the WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12542 a1c6a512-1295-4272-9138-f99709370657
2007-03-01 23:46:01 +00:00
Steve Bavin
361a60c964
Centralise icon enabling to hopefully save a few bytes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12540 a1c6a512-1295-4272-9138-f99709370657
2007-03-01 18:25:13 +00:00
Jonathan Gordon
91cb68a1fb
Introducing the root menu!
...
Blind users: get a new voice file as there are lots of lang changes and new strings.
FS#6630 or RootMenu on the wiki for more info. complaints to /dev/null :)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12528 a1c6a512-1295-4272-9138-f99709370657
2007-03-01 11:14:46 +00:00
Jens Arnold
b49602e7a9
Fix a potential race condition with cuesheets (that hit every time in an archos test), plus a slight optimisation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12524 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 23:43:38 +00:00
Robert Kukla
50b5ee4781
FS#6419 - driver for H1x0 series RTC Mod with runtime detection
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12520 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 13:20:36 +00:00
Dave Chapman
6c6c352310
Character-encoding policing
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12516 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 01:36:32 +00:00
Nils Wallménius
dbf772bae9
Remove unnecessary function call.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12471 a1c6a512-1295-4272-9138-f99709370657
2007-02-24 11:49:52 +00:00
Nils Wallménius
f67a95330c
Make private functions 'static'.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12470 a1c6a512-1295-4272-9138-f99709370657
2007-02-24 11:07:21 +00:00
Nils Wallménius
7fdee10a70
Make private functions static. Remove some functions from the plugin api as they weren't used in any plugins and could then be declared static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12462 a1c6a512-1295-4272-9138-f99709370657
2007-02-23 21:52:45 +00:00
Jens Arnold
3a37f46fc9
Fix CONFIG_BACKLIGHT warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12393 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 10:07:27 +00:00
Jonathan Gordon
9a6f419775
CONFIG_CHARGING
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12384 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 05:32:06 +00:00
Jonathan Gordon
bd47d48c21
Do the CONFIG_LED define
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12383 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 05:07:19 +00:00
Jonathan Gordon
eff0dc3e13
Allow the list to display a title icon even if no other icons will be
...
displayed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12375 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 00:52:34 +00:00
Magnus Holmgren
2067fcc695
Fix most (all?) CONFIG_LED warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12370 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 23:22:37 +00:00
Daniel Stenberg
d52ee4c0d6
#ifdef
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12369 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 23:12:55 +00:00
Daniel Stenberg
20a5926d2e
build with -Wundef to make sure we have spelled the defines right in #if lines
...
and have the proper includes included etc
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12360 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 21:54:17 +00:00
Magnus Holmgren
14ba91eaa9
A few more bookmark code tweaks. Also improves how the bookmark selection screen is displayed on Archos players.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12350 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 13:36:44 +00:00
Nicolas Pennequin
7ba8aec5af
* Add support for an optional y coordinate to the progressbar (from FS #4783 ).
...
* Modify the 'Rockboxed' WPS to make use of this new coordinate. It improves the display of
cuesheet/A-B markers a lot and cleans the bitmaps up a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12321 a1c6a512-1295-4272-9138-f99709370657
2007-02-15 22:17:01 +00:00
Nicolas Pennequin
9f4bd8712f
Cuesheet support by Jonathan Gordon and me (FS #6460 ).
...
Everytime an audio file is loaded, a cue file with the same name is searched for. A setting
allows to disable this (default is off). Cuesheet files can also be viewed in the file browser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12304 a1c6a512-1295-4272-9138-f99709370657
2007-02-14 14:40:24 +00:00
Miika Pekkarinen
4e9766477b
FS#6638 - Album artist and comment patch for WPS and tagcache. Export
...
your database before updating because initialization is needed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12255 a1c6a512-1295-4272-9138-f99709370657
2007-02-10 12:09:28 +00:00