Nicolas Pennequin
29e18caacf
Allow subline timeout values to be changed dynamically in the WPS (e.g. by using conditionals).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13026 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:44:01 +00:00
Jens Arnold
7b8767c093
Player full-line progress bar: No more separate character cell(s) for the colon(s) in the time display. Looks better, and takes less software-definable characters, allowing for up to 99:59:59 with the last progress bar character still working properly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13023 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 23:18:35 +00:00
Jens Arnold
c6fce6cad3
Player progress drawing rewrite (both emptying cup and full-line bar): * Fixes FS #6820 , related to the glitch that progress moved in the opposite direction when seeking. * Smaller, more efficient code. * Full-line bar only displays as many software defined characters as needed, freeing the remaining ones for other text. * Don't cut last digit from times >=1 hour (at the cost of inexact last progress bar character).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13021 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 22:05:04 +00:00
Nicolas Pennequin
830a3a4720
* Make some private variables 'static'.
...
* Fix the pitch tag and allow it to be used on all targets except the Archos Player.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13020 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 15:47:51 +00:00
Nicolas Pennequin
ab90d58801
Introducing the WPS tokenizer !
...
When a WPS file is loaded, it is parsed to an array of tokens, which allows more efficient displaying. More info on the tracker entry : FS #6862 .
The parsing code is completely independant and is all in wps_parser.c. The displaying part stays in gwps-common.c.
Debugging code is provided (with the right ifdefs) and is disabled by default.
Overall, the code should be easier to read and maintain. Adding new WPS tags is made quite trivial.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13019 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 14:41:40 +00:00
Jens Arnold
2684e36724
Repair player progressbars (single char and full line) broken in the full unicode support move, and enable text alignment for charcell.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12993 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 17:32:12 +00:00
Jens Arnold
2c7b127dd7
Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12811 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 23:47:03 +00:00
Jens Arnold
4d6374c923
Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 21:56:08 +00:00
Robert Kukla
23c136c892
don't restart the whole wps to essentially update the display of runtime info, but make the concerned tags dynamic. Now scrolling is not restarted at end of buffering.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12592 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 16:09:18 +00:00
Robert Kukla
ae08eeb4ff
remove runtime detection of h1x0 series RTC MOD, but leave driver code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12554 a1c6a512-1295-4272-9138-f99709370657
2007-03-03 00:11:20 +00:00
Robert Kukla
79a2a936a2
remove numerical genre and use genre_string consistently:
...
- fix spurious display of "blues" genre for missing genre tag
- simplify code/use less code
- numerical->string conversion only once instead of at every use
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12552 a1c6a512-1295-4272-9138-f99709370657
2007-03-02 21:49:42 +00:00
Jens Arnold
b49602e7a9
Fix a potential race condition with cuesheets (that hit every time in an archos test), plus a slight optimisation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12524 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 23:43:38 +00:00
Robert Kukla
50b5ee4781
FS#6419 - driver for H1x0 series RTC Mod with runtime detection
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12520 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 13:20:36 +00:00
Dave Chapman
6c6c352310
Character-encoding policing
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12516 a1c6a512-1295-4272-9138-f99709370657
2007-02-28 01:36:32 +00:00
Jens Arnold
3a37f46fc9
Fix CONFIG_BACKLIGHT warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12393 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 10:07:27 +00:00
Jonathan Gordon
9a6f419775
CONFIG_CHARGING
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12384 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 05:32:06 +00:00
Jonathan Gordon
bd47d48c21
Do the CONFIG_LED define
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12383 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 05:07:19 +00:00
Magnus Holmgren
2067fcc695
Fix most (all?) CONFIG_LED warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12370 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 23:22:37 +00:00
Magnus Holmgren
14ba91eaa9
A few more bookmark code tweaks. Also improves how the bookmark selection screen is displayed on Archos players.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12350 a1c6a512-1295-4272-9138-f99709370657
2007-02-17 13:36:44 +00:00
Nicolas Pennequin
7ba8aec5af
* Add support for an optional y coordinate to the progressbar (from FS #4783 ).
...
* Modify the 'Rockboxed' WPS to make use of this new coordinate. It improves the display of
cuesheet/A-B markers a lot and cleans the bitmaps up a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12321 a1c6a512-1295-4272-9138-f99709370657
2007-02-15 22:17:01 +00:00
Nicolas Pennequin
9f4bd8712f
Cuesheet support by Jonathan Gordon and me (FS #6460 ).
...
Everytime an audio file is loaded, a cue file with the same name is searched for. A setting
allows to disable this (default is off). Cuesheet files can also be viewed in the file browser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12304 a1c6a512-1295-4272-9138-f99709370657
2007-02-14 14:40:24 +00:00
Miika Pekkarinen
4e9766477b
FS#6638 - Album artist and comment patch for WPS and tagcache. Export
...
your database before updating because initialization is needed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12255 a1c6a512-1295-4272-9138-f99709370657
2007-02-10 12:09:28 +00:00
Jonathan Gordon
228d62dd18
Split the system status variables out of global_settings and put them into a new struct global_status. Use status_save() if these need
...
saving.
Added car_adapter_mode to the nvram settings, so nvram settings will be reset.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12101 a1c6a512-1295-4272-9138-f99709370657
2007-01-24 02:19:22 +00:00
Dominik Riebeling
08c813d45a
Respect the progressbar length when drawing AB markers. Fixes FS#6463. Also fix a function name typo.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11857 a1c6a512-1295-4272-9138-f99709370657
2006-12-29 19:17:03 +00:00
Jens Arnold
2597a13497
Next round of static'ing and related fixes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
2006-12-25 14:01:47 +00:00
Magnus Holmgren
ea7992455a
Make the updated %rg tag match playback behaviour (fall back to track gain if album gain requested but not available). Share the mode decision logic with playback code and simplify the %rg tag handling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11532 a1c6a512-1295-4272-9138-f99709370657
2006-11-15 20:26:33 +00:00
Martin Scarratt
442c0e663f
Improved replaygain tags for WPS by Ian Webber fs#6223. Shows the current status of the gain rather than what the setting is set to. %?rg<off|track|album|shuffletrack|shufflealbum|notag>. Also, %rg will give the current gain adjustment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11531 a1c6a512-1295-4272-9138-f99709370657
2006-11-15 17:29:03 +00:00
Jens Arnold
0297873f6a
Backdrop support for greyscale targets. WPS backdrop is untested.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11520 a1c6a512-1295-4272-9138-f99709370657
2006-11-13 00:45:21 +00:00
Jens Arnold
c1767ddf4a
Remove format_align from the format_lines array, as it's unnecessary. Saves code & memory. Patch by Mark Arigo.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11388 a1c6a512-1295-4272-9138-f99709370657
2006-10-30 00:23:32 +00:00
Magnus Holmgren
606f745c7c
WPS: Fix problem with transparancy in the first image of an enum.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10793 a1c6a512-1295-4272-9138-f99709370657
2006-08-29 12:54:22 +00:00
Magnus Holmgren
ed1a26d567
1 is the correct value here. Not that it makes any difference... :)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10760 a1c6a512-1295-4272-9138-f99709370657
2006-08-26 15:52:44 +00:00
Magnus Holmgren
dd87c364a0
Make volume and battery level enums dynamic, inspired by patch 4802. Almost backwards compatible; for the battery level, the first enum is used when the level is unknown, while the remaining enums are used as before.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10756 a1c6a512-1295-4272-9138-f99709370657
2006-08-26 13:25:33 +00:00
Linus Nielsen Feltzing
224c0a13eb
Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:27:07 +00:00
Martin Scarratt
6c30b95504
Oops...Stupid text editor!
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10459 a1c6a512-1295-4272-9138-f99709370657
2006-08-05 12:47:42 +00:00
Martin Scarratt
aa6ce70ba2
fix crossfeed tag
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10440 a1c6a512-1295-4272-9138-f99709370657
2006-08-03 17:56:24 +00:00
Martin Scarratt
d68ae6a7a6
WPS tags: Crossfade %?xf<off|shuffle|skip|always>, Replay gain %?rg<off|track|album|shuffle>, Crossfeed %xd<off|on>. Bits and bobs from patches 2740, 2684 and 2680 by Myself, Stephan Wezel and Robert Kukla.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10414 a1c6a512-1295-4272-9138-f99709370657
2006-08-02 17:35:41 +00:00
Linus Nielsen Feltzing
df1df9560b
Fixed a bug introduced in patch #5630 which caused the battery icon to disappear in the engineeer2 WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10229 a1c6a512-1295-4272-9138-f99709370657
2006-07-18 12:59:16 +00:00
Linus Nielsen Feltzing
aea41cc221
Patch #5630 by Andreas Mattsson - Minimize WPS subline swap time shift
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10211 a1c6a512-1295-4272-9138-f99709370657
2006-07-13 21:34:36 +00:00
Jens Arnold
0dd1f8ec11
Work-in-progress rework of charging status reading & display: * Changed several charging related HAVE_* macros into one multi-value CONFIG_CHARGING. * Always use proper macros for charging states. * Battery symbol charging animation now starts from current level on all targets with charging. Two-colour animation kept for non-b&w targets. Round down fill level while charging as before, but round to nearest pixel value for discharging on all targets. * Charging anim fixed on player. * Some code cleanup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10080 a1c6a512-1295-4272-9138-f99709370657
2006-06-06 22:23:52 +00:00
Peter D'Hoye
93b899d0fe
Reworked backdrop handling. Fixes a bug that wasn't in the tracker yet ;)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9970 a1c6a512-1295-4272-9138-f99709370657
2006-05-21 11:00:02 +00:00
Peter D'Hoye
23aa325d1d
Caption-backlight: don't keep backlight on if paused as this keeps the backlight on forever. Fixes bug 5050.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9854 a1c6a512-1295-4272-9138-f99709370657
2006-05-01 19:50:44 +00:00
Dave Chapman
9f34872df0
Make the get_image_id() function more robust, and catch a parsing error when parsing the %x tags. This prevents Rockbox crashing when presented with an incorrect %x|filename.bmp| WPS line.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9755 a1c6a512-1295-4272-9138-f99709370657
2006-04-22 09:02:59 +00:00
Brandon Low
857db456af
Fix seeking on swcodec, but probably break some cases of skipping. Another important rework here, buffer management is serialized along with most other operations on the audio thread. This has some minor performance issues on ipod that can lead to audio skips during buffer fill as well.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9529 a1c6a512-1295-4272-9138-f99709370657
2006-04-06 04:07:06 +00:00
Brandon Low
6cd6a447e0
Fix buggy WPS change from earlier
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9524 a1c6a512-1295-4272-9138-f99709370657
2006-04-05 20:48:44 +00:00
Brandon Low
686fc085f1
Remove wasted instruction
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9521 a1c6a512-1295-4272-9138-f99709370657
2006-04-05 16:14:38 +00:00
Brandon Low
a482da3692
Inspired by patch 4784 by Dominik, add pitch to WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9517 a1c6a512-1295-4272-9138-f99709370657
2006-04-05 14:22:40 +00:00
Linus Nielsen Feltzing
93b5f24083
Patch #2854 by David Dent - %bs WPS tag for sleep timer
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9303 a1c6a512-1295-4272-9138-f99709370657
2006-03-28 10:07:34 +00:00
Dan Everton
b66477adcc
Support the recording screen on the LCD remote. Also adds support for the peakmeter in the rremote WPS. Patch from Martin Scarratt (task 4818).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9246 a1c6a512-1295-4272-9138-f99709370657
2006-03-25 13:35:31 +00:00
Brandon Low
ddf7c70a45
Real Time Clock support in the WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9105 a1c6a512-1295-4272-9138-f99709370657
2006-03-18 22:42:02 +00:00
Brandon Low
211d827c0a
Fix ifdefing for wps hold button tags, enables hold button in wps for ipod
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9052 a1c6a512-1295-4272-9138-f99709370657
2006-03-15 20:16:21 +00:00