devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
15010 commits 1 branch 143 tags 210 MiB
Commit graph

7593 commits

Author SHA1 Message Date
Stéphane Doyon
6d08116691 Fix a bug whereby ACTION_TREE_WPS (GO_TO_PREVIOUS_MUSIC) brings us to the 
radio, despite playback having been started since we last visited the radio.

To reproduce:
-go to the radio,
-stop and exit it,
-go to the browser, and do a playlist insert,
    or start a playlist from the playlist catalog,
    anything that starts playback without going to the WPS.
-Press ACTION_TREE_WPS.
Find yourself back into the radio.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15085 a1c6a512-1295-4272-9138-f99709370657
 2007-10-12 04:20:20 +00:00
Stéphane Doyon
84ed3fd50f Go to the WPS on a successful bookmark_mrb_load() from the MRB, 
rather than popping back to the root menu.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15084 a1c6a512-1295-4272-9138-f99709370657
 2007-10-12 04:10:08 +00:00
Stéphane Doyon
2ee85c5056 Voice already gets shutup when starting playback. It's also appropriate 
to shut it up when returning to the WPS (GO_TO_WPS).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15083 a1c6a512-1295-4272-9138-f99709370657
 2007-10-12 02:23:52 +00:00
Dave Chapman
e88ac4ce4a Cosmetic change - change the "loading ..." splashes to "Loading...", as used everywhere else in Rockbox 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15081 a1c6a512-1295-4272-9138-f99709370657
 2007-10-11 23:06:05 +00:00
Daniel Stenberg
c61e462ae3 read_mp4_tag_string() may return a NULL in the pointer so no code should rely 
on the pointer being valid unless the return code is checked. This lead to the
year_string being accessed with atoi() even when being NULL => crash. This
fixes FS#7937.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15080 a1c6a512-1295-4272-9138-f99709370657
 2007-10-11 22:53:08 +00:00
Robert Kukla
83ec896586 FS#7931 - mpegplayer - resume on idle off - play files without start time of zero 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15079 a1c6a512-1295-4272-9138-f99709370657
 2007-10-11 22:38:16 +00:00
Peter D'Hoye
9875700627 Accept FS #7933 by Mario Lang: bugfix in fireworks plugin 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15078 a1c6a512-1295-4272-9138-f99709370657
 2007-10-11 19:33:27 +00:00
Peter D'Hoye
1c9ec20fe9 Accept FS #7914 by Stijn Hisken with corrections and additions by me 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15073 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 23:52:10 +00:00
Peter D'Hoye
85058f5d9c Fix FS #5852 by trying to properly close and update the recorded file, and give the FAT the correct file info. Add filehandle checks to some file functions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15072 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 23:26:17 +00:00
Marianne Arnold
bcdb3217de Enable recording for Sansa c200, the keymap is usable but maybe could still be improved later. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15071 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 22:49:39 +00:00
Marianne Arnold
c0c6cff3c1 Add the missing keymap for the c200, the plugin was compiled before but since there was no way to get to the menu it wasn't very usable... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15070 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 21:35:49 +00:00
Alessio Lenzi
16c0a46948 Updated italian translation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15069 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 20:38:22 +00:00
Jens Arnold
9afdf99212 Add the vkeyboard line end beep to (swcodec) targets with non-modal keyboard. * Select modal keyboard and enable morse mode for iPod 1st/2nd gen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15066 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 06:19:54 +00:00
Jens Arnold
064de4ce4d Slight code policing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 06:02:08 +00:00
Jens Arnold
100d343963 Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 05:56:53 +00:00
Stéphane Doyon
1b89d588e1 Accessible keyboard: guard the beep with talk_menus_enabled() 
rather than the beep setting from the playback settings.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15062 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 03:57:42 +00:00
Stéphane Doyon
3e31d50955 Export shutup() function from talk.c. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15061 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 03:12:17 +00:00
Stéphane Doyon
d529a3845b Make the virtual keyboard easier to use for blind users. 
From FS#6324

When moving up/down and landing on the edit line, say "edit". Otherwise
it gets quite confusing.

When moving left and right on the edit line, sound a beep when the left
or right end is reached.

Before, it would say nothing either when the cursor is over a blank or
a char it doesn't know how to spell. So if we're on a blank spot, say
"blank".

Pass the whole utf8 char to be spelled.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15060 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 02:28:58 +00:00
Stéphane Doyon
0279c71a92 Voice the recording trigger settings screen. 
From FS#6325, with a slight coding improvement.
Also take out a duplicated snprintf in there.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15059 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 01:41:48 +00:00
Robert Kukla
a07e93938c fix yellow and some house cleaning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15056 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 21:28:51 +00:00
Robert Kukla
fd3fe45bc1 FS#7487 - mpegplayer - video start time seek with resume 
by John S. Gwynne & Brian J. Morey
This should stop the patch from breaking again and give them opportunity to improve it further.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15052 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 20:42:20 +00:00
Nicolas Pennequin
9ff40579c3 Hopefully the last fix for crosscompilation of sims with mingw32. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15048 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 18:44:07 +00:00
Nicolas Pennequin
b8eb2a89ad Oops. Fix red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15046 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 15:37:43 +00:00
Nicolas Pennequin
ef9abe4385 Keep track of the number of opened files in the sim to enforce the same limit as on target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15045 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 15:15:00 +00:00
Stéphane Doyon
26e47f2ad5 Use dynamic menu voice callbacks to speak menu item names in the 
"Simple EQ Settings" menu and the Peak filter item names in the
"Advanced EQ Settings" menu.
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15043 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 03:53:46 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback. 
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 03:48:56 +00:00
Nils Wallménius
f619f81676 Change loop structure for sample synthesizing. Gives a nice speedup on both coldfire and arm targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15036 a1c6a512-1295-4272-9138-f99709370657
 2007-10-08 19:28:41 +00:00
Michael Sevakis
d712e252fe Get test_codec running again on PortalPlayer targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15035 a1c6a512-1295-4272-9138-f99709370657
 2007-10-08 18:17:46 +00:00
Linus Nielsen Feltzing
16301880a1 Make sure that audio_resume() is not called in interrupt context when car adapter mode is enabled. Fixes FS#7304. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15034 a1c6a512-1295-4272-9138-f99709370657
 2007-10-08 09:09:40 +00:00
Jonas Häggqvist
46b7028f91 Keep a 2 pixel margin in the instructions screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15033 a1c6a512-1295-4272-9138-f99709370657
 2007-10-08 00:03:15 +00:00
Jonas Häggqvist
548886a17e Use the userfont for the instructions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15032 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 23:50:43 +00:00
Jonas Häggqvist
52336cdeb3 Add instructions on all targets. Somewhat hackish, I'm afraid, but works reasonably well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15030 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 23:01:26 +00:00
Jonas Häggqvist
59f523ce66 Save some more space by not allocating arrays large enough to hold more than NUM_BOGUS (defined at compile-time) elements. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15029 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 23:00:43 +00:00
Mustapha Senhaji
1de497228a Forgot about the case conversion rule for one string :) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15025 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 19:25:04 +00:00
Nils Wallménius
27588edd7e Do the checking arm targets in a nicer way in the makefile 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15024 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 18:24:53 +00:00
Mustapha Senhaji
7ad3e2fffe Update francais language and fix a typo in the english file. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15023 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 18:13:25 +00:00
Jens Arnold
5f1ec307db Name all button light functions and variables consistently starting with buttonlight_ . 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15016 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 15:02:02 +00:00
Magnus Holmgren
7d34565c62 Don't get the dircache size while dircache is still initializing. If done during shutdown, it will force a foreground scan on next boot. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15013 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 12:05:48 +00:00
Jonathan Gordon
d7d6b780d4 Accept FS#7897 with some changes by me. moves the code to talk time/date out of main_menu.c to make it hopefully more useful. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15011 a1c6a512-1295-4272-9138-f99709370657
 2007-10-07 08:12:01 +00:00
Michael Sevakis
6077e5b7c8 Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15006 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 22:27:27 +00:00
Michael Sevakis
f6de0d4083 Discontinue any use of 'swp(b)' on PP5020. While clocking is stable, some testing revealed this instruction can still cause problems without concurrent access. Make sure mpegplayer is safe while not using spinlock (no longer atomic) between cores to protect the stream byte counters - use nonwrapping head and tail pointers. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15005 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 15:01:37 +00:00
Alessio Lenzi
a5133307c7 Updated italian translation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15004 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 14:48:13 +00:00
Jonathan Gordon
4443fcb558 Accept FS#7864 - minor menu cleanup to move theme settings into a new themes menu. patch to update the manual would be welcome :p 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15003 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 11:47:41 +00:00
Nils Wallménius
c27ae40ca2 Reduce memory usage so that we can include all messages on all platforms 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14997 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 21:28:43 +00:00
Nils Wallménius
1d7912955b Get rid of unnecessary memory acesses in a loop, gives slight speedup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14996 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 21:03:56 +00:00
Jonas Häggqvist
44f3706b29 Exclude some more messages for targets with only little space for plugins to allow them to build. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14995 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 20:26:45 +00:00
Jonas Häggqvist
ef7affa01b New plugin: robotfindskitten - a zen simulation. More (or less) information on robotfindskitten.org. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14993 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 20:02:32 +00:00
Nicolas Pennequin
e49247e3e8 get_metadata(): Clear the destination mp3entry to avoid having bogus pointers appear in it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14992 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 16:02:35 +00:00
Linus Nielsen Feltzing
6ac7947e42 Ooops 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14991 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 13:25:35 +00:00
Nils Wallménius
5118f48d73 A loop with one iteration is a little strange, also put it inside an #if block to not rely on gcc otimizing it away 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14990 a1c6a512-1295-4272-9138-f99709370657
 2007-10-05 12:22:58 +00:00