Thom Johansen
bf1b7f131c
First attempt at ifdeffing out as much of the encoder stuff as possible from Speex. Gives a smaller binary and allows me to remove a couple more files from SOURCES.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15394 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 21:30:51 +00:00
Thom Johansen
6d88717f69
ARM assembler versions of iir_mem16() and qmf_synth(), yielding a very nice speedup. Touch some comments in filters_cf.S
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15393 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 21:11:26 +00:00
Jonathan Gordon
9e23e9d43e
Fix FS#7826 - make the view catalog option in the main menu > playlists menu use the same text as the view catalog option in the onplay menus
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15392 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 13:41:16 +00:00
Jonathan Gordon
155f928c8d
fix FS#8064 - screen scroll step and screen scroll out of view needed a restart o take effect
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15391 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 13:32:21 +00:00
Brandon Low
ff9cdb464a
Temporary work around for the situation where a single codec request is for more data than a single file_chunk and that file gets stuck. This should be fixed differently as it could lead to unresponsive behavior from the buffering thread for the duration of a file load.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15390 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 05:12:55 +00:00
Dave Chapman
a076da6efc
Remove an unneeded #include - action.h is already included by plugin.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15388 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 22:33:28 +00:00
Peter D'Hoye
fe939193ed
Update Dutch language file
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15387 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 22:15:37 +00:00
Nicolas Pennequin
7f79564abc
Accept FS#8053 by Bertrik Sikken: playback.c and mpeg.c simplification by removal of last_track argument in track_(un)buffer callback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15384 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 13:43:50 +00:00
Mustapha Senhaji
f04a9b390c
FS#8057: Update finnish translation by Jani Kinnunen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15382 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 12:16:52 +00:00
Alessio Lenzi
6c2a904f2b
* For a better access to the information of the Rockbox Info menu by visually
...
impaired users, the order of the items has been modified.
* Now the software displays a message when the external memory card is not in
the device slot. (only for Sansa and Ondio models)
* The voice tag for the current_time message has been restored.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15381 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 21:41:03 +00:00
Nicolas Pennequin
9d05e50c6e
Fix a file descriptor leak that happened with large directories of small files with some invalid ones.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15379 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 18:01:49 +00:00
Magnus Holmgren
fabdd384e6
Make the playlist catalog use the following settings as appropriate: show filename extensions, load last bookmark, party mode and warn when erasing dynamic playlist.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15378 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 17:38:21 +00:00
Nicolas Pennequin
09bce70f17
Slight rework of the buffering logic:
...
* Don't rely only on ata_disk_is_active, and also do buffer filling after buffer handle requests. Should fix FS#8049.
* Shrink the handles at the last possible moment. This allows more seeking without rebuffering for long tracks and minimises buffer waste.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15377 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 17:24:31 +00:00
Brandon Low
151b7c9038
Further improve the mistakes I made in add_handle (thanks Nico_P for not beating me with them)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15376 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 15:09:52 +00:00
Brandon Low
7030279dd2
Fix a logf warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15375 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 15:09:16 +00:00
Nicolas Pennequin
4ff2f9f372
can_add_handle() can be removed, but its logic must remain: before adding a handle, we need to make sure the there'll be space left for the curent one to finish buffering. This should fix the audio dropout problems people were experiencing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15374 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 14:11:03 +00:00
Nicolas Pennequin
be6e85dc59
Revert r15360: It didn't completely fix the problem and it's a bit dirty. A better solution has to be found.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15373 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 13:19:04 +00:00
Thom Johansen
9626948642
Fix FS #8019 , caused by memcpy() being called before "rb = api;". Be cautious of this one, it'll certainly bite us again. Gut out all the silly file selection stuff, this plugin is already a viewer. Note that mp3_encoder still is buggy and needs more work (or we need a transcoder plugin...).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15372 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 10:42:08 +00:00
Robert Kukla
c436657571
some improvements to FS#8008 - see tracker entry for details
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15371 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 10:02:57 +00:00
Thom Johansen
e9001ae514
Just because it's #if 0 doesn't make it inferior...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15370 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 00:06:09 +00:00
Thom Johansen
daf937422c
Fix faulty clipping when dithering is enabled (thanks to Jens Arnold). This bug would only affect people using WMA. Also, add a small comment in an unrelated place.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15369 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 23:58:00 +00:00
Michael Giacomelli
781c82c0d6
Argh.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15368 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 23:22:33 +00:00
Michael Giacomelli
31b74ecb21
Copyright.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15367 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 23:21:42 +00:00
Michael Giacomelli
132bc634ed
We removed the old Q15.16 precision trig functions from decoding ages ago, so no need to leave them in. Also, this code needs a GPL header.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15366 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 23:16:41 +00:00
Mustapha Senhaji
3da91a9cd1
FS#8044: Update potugues-brasileiro translation by Adilson Vicente Xavier.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15365 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 18:21:06 +00:00
Brandon Low
4649eecc79
Fix yellow, not sure how to properly specify this argument's nature so this is fine
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15363 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 17:00:03 +00:00
Brandon Low
483dca99c4
Remove can_add_handle, its safety and benefit are both questionable. Make shrink_buffer a function to reduce code duplication. Change move_handle semantics so that the caller never loses track of the current position of h, even if the move fails.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15362 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 16:48:16 +00:00
Nicolas Pennequin
30d3d36513
Invalidate prevtrack_id3 on all track skips to prevent next track info from being displaying for a split second after skipping to the previous track.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15361 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 15:10:54 +00:00
Nicolas Pennequin
aecca6693f
Update "elapsed" and "offset" in the mp3entries on the main buffer in the corresponding codec callbacks.
...
This should fix FS#8040.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15360 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 15:10:30 +00:00
Nicolas Pennequin
d400e23e38
Prefix the error constants with ERR_
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15359 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 14:15:59 +00:00
Jonathan Gordon
75eff7af5e
rework my previous commit (FS#8008) to be able to work for any of the strings in the id3 info struct, new ones need to be added to tagtree.c and tagnavi.config
...
*currently available tags are* #title# #artist# #album# #genre# #composer# #albumartist# and #directory#
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15358 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 14:10:24 +00:00
Steve Bavin
c985903084
Oops, sucky workaround wasn't meant to be committed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15357 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 13:57:29 +00:00
Steve Bavin
7707f7fac9
Tiny bit of code policing: remove unneeded variable and spaces at end-of-line.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15356 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 13:55:34 +00:00
Jonathan Gordon
1f415e2fe3
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15355 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 12:15:47 +00:00
Jonathan Gordon
4d18aa3546
Accept FS#8008 - allows the current artist or album to be used in databse searches (use the #artist# or #album# keywords in tagnavi.config)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15354 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 12:02:55 +00:00
Brandon Low
4feab10a0c
Improve move_handle's semantics. Shoudl have no functional impact
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15351 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 20:18:59 +00:00
Brandon Low
94b133ad33
Comment improvements
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15350 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 19:19:54 +00:00
Nicolas Pennequin
7807279eaf
Add #defines for error values. Makes the code easier to read.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15348 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 15:54:10 +00:00
Jens Arnold
36cd5f1e4b
Mandelbrot: Don't update the display more often than 50 times per second on colour targets. Significantly increases speed on iPod Video.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15345 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 14:41:21 +00:00
Magnus Holmgren
0e2852bca1
Detabify a line...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15342 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 12:47:49 +00:00
Magnus Holmgren
868d3ce39c
Add ReplayGain support to WMA (based on tags written by Foobar2000).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15340 a1c6a512-1295-4272-9138-f99709370657
2007-10-28 11:09:55 +00:00
Nicolas Pennequin
1839edf64a
Add queue_peek to the kernel (written by Mike Sevakis), and use it to improve upon my previous commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15336 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 18:08:18 +00:00
Nicolas Pennequin
41add08c5e
Prevent the audio queue from getting flooded with fill buffer messages.
...
The low buffer callback is registred by instead of the function it calls to prevent a loop.
audio_check_new_track() also makes more sense because that's where tracks are made useless by a skip.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15335 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 15:35:51 +00:00
Michael Sevakis
3c1d2069dd
Make voice and codec queues private so they don't receive system messages. The audio thread controls them just fine. Important so codec stack-stealing plugins don't crash when system events are broadcast. Simpler too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15333 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 12:11:45 +00:00
Brandon Low
18c9aba4b4
Hopefully fix codec load and data abort problems by making add_handle and move_handle much better at wrapping the buffer smartly and not putting the wrong things on the wrap
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15330 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 04:49:04 +00:00
Brandon Low
7104ad54d0
Whoops, that thread can't run until the linked list is initialized
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15329 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 04:29:46 +00:00
Brandon Low
2c1e8283aa
Create queue stuff before the thread that will use it
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15328 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 04:19:17 +00:00
Brandon Low
14b6f437bb
Make buffering initialization versus reset separate functions to avoid double initializing threads or mutexes more easily
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15327 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 04:16:41 +00:00
Brandon Low
404c6fbdb2
Add some const keywords, improve some comments, add a safety check or two, should have no functional difference
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15326 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 01:37:33 +00:00
Nicolas Pennequin
d08131a117
* Only call bufgetcodec once
...
* Fix/Improve some queue logf messages
* Complete buffering_init
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15325 a1c6a512-1295-4272-9138-f99709370657
2007-10-27 01:25:47 +00:00