devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
26938 commits 1 branch 143 tags 210 MiB
Commit graph

13170 commits

Author SHA1 Message Date
Frank Gevaerts
ae75c6eb0a Resistor calculator: Don't assume a specific foreground colour 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28205 a1c6a512-1295-4272-9138-f99709370657
 2010-10-03 14:52:20 +00:00
Teruaki Kawashima
0f8fe94f46 correct drawing of the bar type tags when nofill is set. 
draw the slider bitmap before drawing A-B repeat markers so that they are visible.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28204 a1c6a512-1295-4272-9138-f99709370657
 2010-10-03 14:19:30 +00:00
Frank Gevaerts
c80dd635ab Resistor calculator: simplify layout code, add scrolling, and handle error cases 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28203 a1c6a512-1295-4272-9138-f99709370657
 2010-10-03 13:57:18 +00:00
Jens Arnold
3e9f797f6e Make test_fps test the greylib on both cores of dual core targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28202 a1c6a512-1295-4272-9138-f99709370657
 2010-10-03 11:57:47 +00:00
Jonathan Gordon
e4bd9e3774 Fix FS#11648 - loading a .cfg doesnt automatically save the new config, caused by r28120. This fix will only save the new config loaded from the browsers, not during boot 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28201 a1c6a512-1295-4272-9138-f99709370657
 2010-10-03 05:43:36 +00:00
Andree Buschmann
27122e4cc9 Fix FS#11650. Correct sliencing of subband in mpc decoder. Thanks to Leo Witt for reporting and supporting. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28200 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 23:02:36 +00:00
Thomas Martitz
c4925f14a3 Playlist viewer: Fix off-by-one when moving tracks caused by r28131. 
The callbacks for the list code need the current item for rendering the moving track,
which is not known until after the first draw. Hence the first draw is off.
A second one is needed.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28199 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 20:15:35 +00:00
Andree Buschmann
2ddcd7fd94 Optimization of mpc's buffering routines through using the maximum possible buffer size. This reduces read access calls. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28198 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 17:52:12 +00:00
Andree Buschmann
32838e96d0 Finally fix FS#11476 (data abort when playing some sv8 mpc files on lowmem targets like Clip+/Fuzev1/Fuzev2). This fix disables loading of seek tables from the sv8 bitstream. Those table are located at the end of sv8-files. When playing sv8 files this resulted in seek to filebegin, then fileend, then back to filebegin. Such seeking behaviour results in heavy rebuffering when playing files on targets with low RAM. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28197 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 17:43:36 +00:00
Frank Gevaerts
9caca08ebc Fix typo properly this time, to ensure all green 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28195 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 14:48:03 +00:00
Frank Gevaerts
e1320fd442 Fix typo, which should fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28194 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 14:46:33 +00:00
Frank Gevaerts
09cb453f0b Resistor plugin: 
crop the smallest bitmap so it's usable for any small screen and nut just the c200
   make the layout a bit more flexible


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28193 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 14:43:23 +00:00
Teruaki Kawashima
23718ad646 picture flow: clean up code. no functional changes. 
-use upper case for enum constants.
-rename variables to match it's use.
-remove tabs and fix indents.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28192 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 14:28:46 +00:00
Frank Gevaerts
ad6c8c1a72 New plugin: Resistor code calculator 
Flyspray: FS#11585
Author: Calvin Walden


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28191 a1c6a512-1295-4272-9138-f99709370657
 2010-10-02 14:11:40 +00:00
Teruaki Kawashima
15e8460053 text editor: decrease size of extension to reduce stack usage. 
this could solve crash in text editor (FS#10078).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28189 a1c6a512-1295-4272-9138-f99709370657
 2010-10-01 14:40:28 +00:00
Teruaki Kawashima
55a63609ef use correct condition for #if for tagcache_fill_tags(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28188 a1c6a512-1295-4272-9138-f99709370657
 2010-09-30 13:09:50 +00:00
Marcin Bukat
2dbe569aff fix red 
simple_resize_bitmap() can deal with greylib now but I missed
that it was compiled only for LCD_DEPTH > 1

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28187 a1c6a512-1295-4272-9138-f99709370657
 2010-09-29 21:09:03 +00:00
Marcin Bukat
e920671755 imageviewer bmp - drop special case for grey bitmap scaller 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28186 a1c6a512-1295-4272-9138-f99709370657
 2010-09-29 20:38:14 +00:00
Marcin Bukat
289e862695 fix bitmap scallers smooth_resize_bitmap() and simple_resize_bitmap() to properly handle LCD_STRIDEFORMAT == VERTICAL_STRIDE case 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28185 a1c6a512-1295-4272-9138-f99709370657
 2010-09-29 20:38:08 +00:00
Teruaki Kawashima
717f0bd982 explicitly set img->using_preloaded_icons in parse_image_load() and don't rely on parse_image_display(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28184 a1c6a512-1295-4272-9138-f99709370657
 2010-09-29 13:23:24 +00:00
Nils Wallménius
5b2d7e23a0 ARMv6 supports unaligned memory accesses and they are enabled on our only ARMv6 target so we might as well use them. Speeds up decoding of a flac8 file by 3.5%. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28183 a1c6a512-1295-4272-9138-f99709370657
 2010-09-29 13:20:03 +00:00
Torne Wuff
918e895c12 id3 parser: also add id3v2.2 TCM tag for "composer" since that's the only other tag not in there in 2.2 and 2.3 versions 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28182 a1c6a512-1295-4272-9138-f99709370657
 2010-09-28 19:46:15 +00:00
Torne Wuff
f018fbbe18 id3 parser: add id3v2.2 TPA tag for "part of set" as iTunes appears to use it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28181 a1c6a512-1295-4272-9138-f99709370657
 2010-09-28 19:39:35 +00:00
Bertrik Sikken
1ca28a4dc7 Warn about erasing dynamic playlist when loading bookmark - FS #10482 by Tuomas Airaksinen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28176 a1c6a512-1295-4272-9138-f99709370657
 2010-09-26 21:13:25 +00:00
Magnus Holmgren
927a7bdb4b Make sure get_lif_token_value isn't inlined, as it would defeat the purpose of introducing that function. E.g., gcc 3.4.6 for m68k is keen on inlining code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28172 a1c6a512-1295-4272-9138-f99709370657
 2010-09-26 11:58:58 +00:00
Jonathan Gordon
0dd8ba4725 Fix FS#11552 - touches outside of the UI viewport can do unexpected list movements. 
Also remove naughty // comments from r28145

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28168 a1c6a512-1295-4272-9138-f99709370657
 2010-09-26 07:32:16 +00:00
Jonathan Gordon
562437b8e7 Fix FS#1159 - stack overflow in the skin engine when there is too many nested conditionals 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28167 a1c6a512-1295-4272-9138-f99709370657
 2010-09-26 06:43:33 +00:00
Frank Gevaerts
8458fade58 Make sure the dsp code has proper resample buffers even if HAVE_PITCHSCREEN is undefined. This makes playback work again without HAVE_PITCHSCREEN 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28158 a1c6a512-1295-4272-9138-f99709370657
 2010-09-24 22:14:10 +00:00
Thomas Martitz
f060cd5428 Don't actually reimplement an existing feature for hiding the selection marker 
during scrolling.

However, the existing one is part of the list api, so it shouldn't be overridden
blindly internally, so do the decision in a different but equivalent way.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28147 a1c6a512-1295-4272-9138-f99709370657
 2010-09-23 00:37:33 +00:00
Thomas Martitz
e5d43300af Explicitly disable hiding the selection bar by default. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28146 a1c6a512-1295-4272-9138-f99709370657
 2010-09-23 00:13:11 +00:00
Thomas Martitz
ac08e6942a Touchscreen: Improve scrolling in absolute point mode. 
* Scrolling is now done by wiping over the screen. There's no acceleration or
  kinetic scrolling yet though. But it works rather well (previously
  you held the edges of the list to scroll).
* Improve scrollbar scrolling so that it keeps scrolling even if you leave the
  scrollbar area.
* Hide selection during scrolling
* Prevent accidental hitting of the list title (which means go back) during
  scrolling
* Don't go into context menu after scrolling when leaving the screen on an item

In general, it's very much like scrolling in native lists in Android,
except there's no kinetic scrolling and everything is still line based, but with
the feature that the scrollbar enables jumping around in the list and very fast
scrolling.

Thanks to Dustin Skoracki for his ideas and half of the code for this.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28145 a1c6a512-1295-4272-9138-f99709370657
 2010-09-23 00:02:32 +00:00
Thomas Martitz
3013103249 Bad copy&paste. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28140 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 22:56:12 +00:00
Thomas Martitz
138ee6304b Use convenience function. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28139 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 22:55:24 +00:00
Rafaël Carré
2dde958478 eq menu: remove write-only variable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28137 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 09:10:01 +00:00
Rafaël Carré
53ac2ca831 do_setting_from_menu(): remove write-only variables 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28136 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 09:04:22 +00:00
Rafaël Carré
7d9df48478 playback_callback(): remove write-only old_repeat_mode 
Also don't ignore this_item argument, it's being used

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28135 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 08:59:27 +00:00
Rafaël Carré
45f3e5fb94 eq menu: remove write-only variable present since r8606 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28134 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 08:32:49 +00:00
Rafaël Carré
94f5f5b2fd lang_load(): ignore unused field from the lang file 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28133 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 08:25:52 +00:00
Rafaël Carré
7c339c937a parse_sap_header(): remove write-only variable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28132 a1c6a512-1295-4272-9138-f99709370657
 2010-09-21 08:25:46 +00:00
Thomas Martitz
aa01ee314e Fix a bug in playlist viewer's list handling, causing superfluous redraws and 
potentially leading to the wrong track being selected.

The playlist viewer should perform a bit better now.
I always felt it was slower than the otehr lists.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28131 a1c6a512-1295-4272-9138-f99709370657
 2010-09-20 23:10:19 +00:00
Bertrik Sikken
c0edce8f5c iap: make variable serbuf non-global 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28128 a1c6a512-1295-4272-9138-f99709370657
 2010-09-20 19:37:17 +00:00
Marcin Bukat
93c50d4770 Remove the call to settings_save() from settings_load_config() as it seems unneeded any more and causes unecessary writes on every startup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28120 a1c6a512-1295-4272-9138-f99709370657
 2010-09-20 13:34:21 +00:00
Michael Giacomelli
cc6ef19dd9 Remove some unused variables. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28118 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 22:09:11 +00:00
Jonathan Gordon
2c8204cd91 Hopefully fix FS#11630 where the wps backdrop would be shown instead of the menu one 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28116 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 11:49:33 +00:00
Rafaël Carré
272e425a2f get_mp3file_info(): Use the correct printf format in DEBUGF() 
Also remove useless parens and casts in bytes2int()

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28115 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:27:49 +00:00
Rafaël Carré
961b5dd4c1 tagcache open_files(): open the correct file (missed in r27656) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28114 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:17:15 +00:00
Rafaël Carré
d2000a9178 radio_screen() return value is unused -> void 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28113 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:17:08 +00:00
Rafaël Carré
c78d55a311 kbd_input(): move sc assignement under #ifdef HAVE_TOUCHSCREEN 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28112 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:17:02 +00:00
Rafaël Carré
37c1192753 ASAP parse_sap_header() : remove write only variables 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28111 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:16:56 +00:00
Rafaël Carré
f03141477a setid3v2title(): unused variable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28110 a1c6a512-1295-4272-9138-f99709370657
 2010-09-19 08:16:52 +00:00