devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
13286 commits 1 branch 143 tags 210 MiB
Commit graph

6739 commits

Author SHA1 Message Date
Magnus Holmgren
a967523b2b Fix buffer overflow when adding a radio preset. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13327 a1c6a512-1295-4272-9138-f99709370657
 2007-05-05 12:06:35 +00:00
Michael Sevakis
a8140eb259 Enable KBD_CURSOR_KEYS and KBD_MODES on Gigabeat. Enter things any way you like. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13324 a1c6a512-1295-4272-9138-f99709370657
 2007-05-04 17:15:55 +00:00
Michael Sevakis
2aaf45e643 Get samplerate switching working in the sim to be similar to on target. Make all pcm functions available there as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13320 a1c6a512-1295-4272-9138-f99709370657
 2007-05-04 15:14:56 +00:00
Michael Sevakis
d7e8e38253 Audio seemed never to want to stop stopping. A bad condition for plugins that want to stop audio and begin pcm playback immediately. Only do the stop if the state is playing. Properly wait for it to be done as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13317 a1c6a512-1295-4272-9138-f99709370657
 2007-05-03 21:49:59 +00:00
Hardeep Sidhu
7a2bc5272b Enable playlist functions for m3u files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13308 a1c6a512-1295-4272-9138-f99709370657
 2007-05-03 01:10:52 +00:00
Nicolas Pennequin
aa220d5acd Trim a bunch of long lines and fix an infinite loop and buffer overrun in the impossible case that a WPS line ends with a litteral string but without a newline char (wps_parser.c:774). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13306 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 17:51:01 +00:00
Magnus Holmgren
2a20bfe153 Make the ID3 info screen treat empty tag strings as 'no value', like the WPS does. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13305 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 17:01:02 +00:00
Magnus Holmgren
05a158ecf3 Treat empty strings as 'no value' in conditionals, as it used to. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13304 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 16:28:24 +00:00
Nicolas Pennequin
378a140ae2 Add a check for unclosed conditionals at the end of the WPS parsing in case we didn't reach the end of the file. Also a few minor other changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13303 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 11:39:46 +00:00
Peter D'Hoye
3494b2118b FS #7093 by Dave Hooper: prevent crash when loading too many/long static strings in the wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13302 a1c6a512-1295-4272-9138-f99709370657
 2007-05-01 23:36:15 +00:00
Jonathan Gordon
26ff697480 clean up and fix comments. no actual code change 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13297 a1c6a512-1295-4272-9138-f99709370657
 2007-05-01 11:01:53 +00:00
Jonathan Gordon
1fa516822f The menu code needs to know that the function wants a param... 
Fixes all the playlist insert/queue items


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13296 a1c6a512-1295-4272-9138-f99709370657
 2007-05-01 10:43:30 +00:00
Nicolas Pennequin
7e6af1532b Better handling of strings in the WPS parser by detecting duplicates to avoid having two copies of the same string in the string buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13295 a1c6a512-1295-4272-9138-f99709370657
 2007-04-30 14:08:58 +00:00
Jonathan Gordon
3a7760c3e2 Convert onplay.c to the new manu API. only plugins are still using the old API now 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13294 a1c6a512-1295-4272-9138-f99709370657
 2007-04-30 13:41:33 +00:00
Jonathan Gordon
507345000d these should be static 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13288 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 23:26:26 +00:00
Jens Arnold
fa67e5fd4d Fix typo. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13287 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 19:54:45 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now) 
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:31:43 +00:00
Jonathan Gordon
4eaddc3f85 Use the new menu API 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13285 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:02:09 +00:00
Miika Pekkarinen
b1ff1ea303 Improved speed when deleting tags and prevent remaining ghost entries with database loaded in ram. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13284 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 14:40:59 +00:00
Jonathan Gordon
9270ada23a keep some #if 0'ed code in sync 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13283 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 13:33:15 +00:00
Jonathan Gordon
caea20e75f show a splash instead of a menu when the chosen encoder format has no options 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13282 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 13:26:56 +00:00
Marcoen Hirschberg
810f7178ae make A the new 'clear settings' button for the Gigabeat as it was easy to accidentally trigger it with HOLD 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13279 a1c6a512-1295-4272-9138-f99709370657
 2007-04-27 19:24:31 +00:00
Marcoen Hirschberg
7eb8512bf0 changed POWER to be the cancel/stop button and A to be the modifier button to prevent acidental shutdowns 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13278 a1c6a512-1295-4272-9138-f99709370657
 2007-04-27 18:48:20 +00:00
Nicolas Pennequin
b8a79b8bba Clear the RWPS backdrop when a RWPS is loaded, not when a WPS is loaded. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13275 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 20:32:05 +00:00
Magnus Holmgren
832bbf72a8 AAC: More adjustments to how the frequency is read. Still not perfect, but this is probably as good as it can get. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13274 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 17:59:24 +00:00
Jonathan Gordon
386d838b87 fix player warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13273 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 14:02:10 +00:00
Jonathan Gordon
ed8b3bb74b Accept FS#7080 by Mauricio Peccorini with some minor changes by me: 
- show more info in the stopwatch screen, and use the whole display for lap times


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13271 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 13:52:53 +00:00
Jonathan Gordon
52ba1c614d Fix some naughty variable name reuse (hopefully correctly) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13269 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 10:28:32 +00:00
Jonathan Gordon
3d44a20db7 Accept FS7078, try to show the last playlist if no audio is being played 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13268 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 08:21:29 +00:00
Jonathan Gordon
5b5d1018d0 Fix a .icons loading bug which caused the tango iconset to not load. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13267 a1c6a512-1295-4272-9138-f99709370657
 2007-04-26 05:30:46 +00:00
Nicolas Pennequin
1cf2ec38b1 Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454 Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 21:44:56 +00:00
Michael Sevakis
205ec3279d Make recording complain about every little file I/O problem (error on close() failure and fsync() failure). Why? I guess we will find out the disk is full about 1/2 sector sooner on average when the file APIs actually detect this correctly. :/ 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13262 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 19:53:34 +00:00
Nicolas Pennequin
2a2b8d8a82 Make bitmaps use the right format in a RWPS and prevent a backdrop tag in a RWPS from clearing the main display's backdrop. This also allows future backdrop support for LCD remotes by making the parsing code aware of whether the display for a WPS is a remote or not. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13261 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 13:09:56 +00:00
Jonathan Gordon
70e2846241 oops, wrong return value 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13260 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 12:17:16 +00:00
Jonathan Gordon
a2740d9edc convert the playlist viewer menus to the newer API 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13259 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 11:20:19 +00:00
Jonathan Gordon
680acbf71b fix a stupid bug which didnt check the flag correctly (caused the player to crash trying to access the shutdown options context menu) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13258 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 10:41:17 +00:00
Nicolas Pennequin
6ac306a515 Add a new commandline switch to the simulator: "--debugwps". It enables printing of advanced (and very verbose) WPS debugging information. Also make the debugging code a bit cleaner. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13257 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 23:58:57 +00:00
Nicolas Pennequin
4ddc764a7c Small fix to prevent crashing when attempting to use non-mono bitmaps in a RWPS. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13256 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 21:00:45 +00:00
Magnus Holmgren
ab707b8362 AAC: Improve SBR detection, to fix incorrect frequency on some files (and hopefully not break others :). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13255 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 19:22:21 +00:00
Michael Sevakis
72e6dd5e0c Do the clamping a little better. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13254 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 03:38:19 +00:00
Michael Sevakis
0d032d1fa1 mpeglayer: Give the simulator YCbCr blit similar behavior to the target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13253 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 02:46:32 +00:00
Nicolas Pennequin
d7fd989319 WPS Parser: On parse failure, print a (hopefully) useful error message with line number (sim only). 
Also the debug code is still  disabled but now in a nicer way.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13251 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 00:57:04 +00:00
Jens Arnold
27b4a64f9b AIFF COMM chunks might be larger than 18 bytes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13249 a1c6a512-1295-4272-9138-f99709370657
 2007-04-23 23:11:33 +00:00
Jonathan Gordon
77a868360f make the moving smarter so you dont have to select the top card of a column to move the whole column 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13248 a1c6a512-1295-4272-9138-f99709370657
 2007-04-23 14:15:07 +00:00
Jonathan Gordon
cd8870ccfb fix a bug which made menus using the old API and a callback function to not work correctly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13246 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 14:24:32 +00:00
Jonathan Gordon
4b1d1b4033 e200: Make the wheel light timeout configurable (under settings > system) (FS#7067) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13244 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 13:02:24 +00:00
Jens Arnold
6bf86b799e Ooooops, fix warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13243 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:48:05 +00:00
Jens Arnold
5070f41bfc Consolidated several potential places of return from WPS into one. Fixes the 'Return from WPS at end of playlist always brings up the root menu.' bug on hwcodec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13241 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:38:11 +00:00
Jonathan Gordon
9d3694ced6 Fix FS#7056 - dont display garbage if the viewer icon set and the main iconset have different icon heights 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13237 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 08:50:24 +00:00