devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
23154 commits 1 branch 143 tags 210 MiB
Commit graph

1035 commits

Author SHA1 Message Date
Stéphane Doyon
4b5f0909d1 Fix bug in r17188. 
The warning from the build page was valid and helpful, wish my compiler had
given it to me...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17189 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 14:44:36 +00:00
Stéphane Doyon
b2aa86a785 FS#7980: Select default option in an option list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17188 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 14:12:28 +00:00
Bertrik Sikken
db2d61f4ea Killed unnecessary global variables by making them static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 10:24:15 +00:00
Nicolas Pennequin
a5ad74ffca Revert what was left of r17018 until I find a better way. It had quirks in some cases, and doesn't play well with what I'm about to commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17108 a1c6a512-1295-4272-9138-f99709370657
 2008-04-14 15:51:40 +00:00
Nils Wallménius
84dc8d2c7e Move a function to gwps-common.c because it belongs there 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17084 a1c6a512-1295-4272-9138-f99709370657
 2008-04-12 13:25:16 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Nicolas Pennequin
e92c176d95 r17018 caused the WPS playlist index display to be wrong with shuffled enabled, so we revert to using playlist_get_display_index() on HWCODEC. Using id3->index would require something like what was added in r3726. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17025 a1c6a512-1295-4272-9138-f99709370657
 2008-04-07 19:09:30 +00:00
Nicolas Pennequin
977069a41d Bring the WPS playlist index display into sync with the track being played by using the index field of the ID3 info struct instead of directly asking the playlist code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17018 a1c6a512-1295-4272-9138-f99709370657
 2008-04-07 13:43:09 +00:00
Dave Chapman
aa9dbfef19 Add a comment to clarify how the WPS image buffer size is calculated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16961 a1c6a512-1295-4272-9138-f99709370657
 2008-04-04 12:32:37 +00:00
Jonathan Gordon
34196edb60 fix FS#8841 - scrolling doesnt work when using cursor seelction icon 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16941 a1c6a512-1295-4272-9138-f99709370657
 2008-04-03 04:41:42 +00:00
Nicolas Pennequin
19868938d4 WPS parser: also revert to the default WPS when there were bitmap loading errors. The reverting is moved from wps_parse() to wps_data_load(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16914 a1c6a512-1295-4272-9138-f99709370657
 2008-04-01 17:35:48 +00:00
Dave Chapman
d746b79317 Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
 2008-03-29 01:14:10 +00:00
Steve Bavin
c9df8fd87b The const police raid playback.c, should be no change to behaviour. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16860 a1c6a512-1295-4272-9138-f99709370657
 2008-03-28 11:24:24 +00:00
Dave Chapman
78d29f535f Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 23:35:34 +00:00
Dave Chapman
3d88eddb83 Move checkwps to its own subdir in preparation for compiling target-specific versions. Also remove a DEBUGF that should not have been left in. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16827 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 20:19:39 +00:00
Dave Chapman
fa1da20d3a Fix yellow, and at the same time simplify some #ifdefs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16823 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 19:07:39 +00:00
Dave Chapman
b9bb723f12 1) Make Rockbox reject any WPSs if there are errors loading any of the required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 18:18:22 +00:00
Jonathan Gordon
be185a1eaf fix the buttonbar in the browser and menus. 
fix a problem where the menus wouldnt redraw when they should have when settings change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Dave Chapman
7418c357c3 Make checkwps compile again. Still more work is needed though, as checkwps is compiled to emulate an iPod Color - this needs changing to allow the LCD (and remote LCD) dimensions/depth to be specified on the commandline - the new %V tags are validated against the LCD characteristics 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16807 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 21:09:58 +00:00
Steve Bavin
ae39135e2e Oops. Mop up red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16799 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 15:35:14 +00:00
Steve Bavin
cd88e2ad93 Code police raid on the settings code, consting and putting headers alongside their implementation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 15:24:03 +00:00
Dave Chapman
60413d898e D'oh - fix a silly #ifdef mistake that caused problems with remote WPSs using viewports. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16787 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 00:20:59 +00:00
Dave Chapman
0bb2e05aef Stricter syntax checking of the %V tag - pay attention to the return-code from parse_list, and check for the tailing | symbol. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16784 a1c6a512-1295-4272-9138-f99709370657
 2008-03-24 18:40:13 +00:00
Dave Chapman
2a34943d7f Hopefully get the viewport position/dimensions validation correct this time. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16782 a1c6a512-1295-4272-9138-f99709370657
 2008-03-24 14:58:30 +00:00
Dave Chapman
6d9c353f2e Add another safety-check in the bitmap strips parsing - don't allow the num_subimages parameter to %xl to be <= 0 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16779 a1c6a512-1295-4272-9138-f99709370657
 2008-03-24 10:13:47 +00:00
Dave Chapman
99c0978faa Add a sanity-check to ensure only in-range subimages are referenced in %xd tags. Plus some tab policing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16774 a1c6a512-1295-4272-9138-f99709370657
 2008-03-24 00:03:05 +00:00
Dave Chapman
15ddd7a7ec Add the ability to use bitmap strips (a single .bmp file containing many images of the same dimensions, tiled vertically - similar to icon strips) in the WPS. The %xl tag now has an optional "number of subimages" parameter, and the %xd tag has an optional "subimage to display" parameter (a-z,A-Z - allowing up to 52 sub-images). So for example, a bitmap with 10 subimages is loaded with %xl|M|volume.bmp|134|153|10| and then this can be used in a conditional as %?pv<%xdMa|%xdMb|%xdMc|%xdMd|%xdMe|%xdMf|%xdMg|%xdMh|%xdMi|%xdMj>. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16764 a1c6a512-1295-4272-9138-f99709370657
 2008-03-23 20:31:00 +00:00
Dave Chapman
65d50de5b7 Oops - correctly reset the bmp filenames 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16762 a1c6a512-1295-4272-9138-f99709370657
 2008-03-23 12:15:52 +00:00
Dave Chapman
bc227c0aa2 Fix the display of peakmeters and progress bars (without a custom y position) inside a viewport (broken by r16735). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16739 a1c6a512-1295-4272-9138-f99709370657
 2008-03-22 10:56:03 +00:00
Dave Chapman
bca8edd856 Small simplification - take advantage of the fact that x/y/width/height are non-negative integers when validating the viewport bounds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16736 a1c6a512-1295-4272-9138-f99709370657
 2008-03-22 09:28:15 +00:00
Dave Chapman
45b2d8802d Reduce the shocking amount of RAM my viewports implementation was using. The first version stored an array of lines for each of the 16 possible viewports (MAX_VIEWPORTS * the number of lines on the LCD with a 5-pixel high font). This version reverts back to a single global array of lines, with each viewport specifying the first and last lines as indexes into that array. This also turns out to be simpler, reducing binsize a little as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16735 a1c6a512-1295-4272-9138-f99709370657
 2008-03-22 00:31:22 +00:00
Dave Chapman
d02c79c03f Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
 2008-03-21 19:38:00 +00:00
Dave Chapman
e92d2c51ed Add a general-purpose parse_list function to parse a string containing a delimited list of items and adapt the parse_image_load() function in the WPS parser to use it. This function will also be used to parse the upcoming WPS %V viewport tag, but I'm committing it separately as these changes are unrelated to the viewport implementation itself. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16728 a1c6a512-1295-4272-9138-f99709370657
 2008-03-21 13:41:35 +00:00
Dave Chapman
2b7d48ede0 Bugfix for new list implementation - correctly assign colours for remote LCDs (fixes wrong colours on X5 remote) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16599 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 23:53:46 +00:00
Jonathan Gordon
885283c424 more fixes for button bar... this will all disappear when viewports are handled by a manager of some sort 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16589 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 09:37:39 +00:00
Jonathan Gordon
3f686d7034 fix recorder, buttonbar caused list problems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16584 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 02:00:31 +00:00
Jonathan Gordon
f444f1ecbe fix the touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16528 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 10:38:10 +00:00
Jonathan Gordon
0e5cec2d18 FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 09:58:30 +00:00
Jens Arnold
bf9ae1f303 Fix the simplelist redraw behaviour. It caused e.g. the 'Open with...' menu items to not scroll as they should, making it partially unusable with small displays and/or large fonts. Thanks to JdGordon for pointing me into the right direction. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16415 a1c6a512-1295-4272-9138-f99709370657
 2008-02-25 07:41:30 +00:00
Nicolas Pennequin
523f88e192 Hopefully fix FS#8459 by updating the WPS data when returning from the context menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16277 a1c6a512-1295-4272-9138-f99709370657
 2008-02-10 23:07:01 +00:00
Paul Louden
f7c938a7b7 (Hopefully) Revert the quickscreen changes. Many fixes need to be made, 
and the exact implementation needs discussion. We apologize for the 
inconvenience and hope to bring an improved quickscreen to you soon.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16224 a1c6a512-1295-4272-9138-f99709370657
 2008-02-05 09:09:38 +00:00
Jonathan Gordon
7ca3ccd2a4 quiet the masses... 
stop the wps scrolling happening in the quickscreen
green delta for non quickscreen targets
nfi why colours arnt working... hopefully bug in firmware/?


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16222 a1c6a512-1295-4272-9138-f99709370657
 2008-02-05 08:21:54 +00:00
Jonathan Gordon
2c82494e66 updated the quickscreen's: 
- use viewports
- dont change to system font, fiddle with item positions to make them fit small screens
- user customizable options (use the .cfg settings "quickscreen_left, quickscreen_right, quickscreen_top, quickscreen_bottom" for the name and the .cfg name for the setting you want to use. it can be any except the string settings... (e.g. quickscreen_left:talk menu)
- a top item! if there is none set the up button will exit the screen



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16220 a1c6a512-1295-4272-9138-f99709370657
 2008-02-05 05:50:20 +00:00
Peter D'Hoye
c4c678ff1a Accept FS #8490 by Vuong Minh Hiep: fix wrong selection in multi-line lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16135 a1c6a512-1295-4272-9138-f99709370657
 2008-01-21 22:28:25 +00:00
Catalin Patulea
7ed787360c Fix compile error in wps_debug.c when -DDEBUG and not simulator build 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16084 a1c6a512-1295-4272-9138-f99709370657
 2008-01-13 20:17:59 +00:00
Michael Sevakis
c4ebcbeaf4 Make set_option correctly return USB connect status. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16055 a1c6a512-1295-4272-9138-f99709370657
 2008-01-11 17:43:07 +00:00
Jonathan Gordon
b684b82fd0 Accept and Fix FS#8427 - problem with empty screens in lists with pages scrolling enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16023 a1c6a512-1295-4272-9138-f99709370657
 2008-01-08 08:12:32 +00:00
Jonathan Gordon
213d9a2ca1 fix touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15948 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 04:23:34 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 02:37:21 +00:00