Frank Gevaerts
8458fade58
Make sure the dsp code has proper resample buffers even if HAVE_PITCHSCREEN is undefined. This makes playback work again without HAVE_PITCHSCREEN
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28158 a1c6a512-1295-4272-9138-f99709370657
2010-09-24 22:14:10 +00:00
Thomas Martitz
f060cd5428
Don't actually reimplement an existing feature for hiding the selection marker
...
during scrolling.
However, the existing one is part of the list api, so it shouldn't be overridden
blindly internally, so do the decision in a different but equivalent way.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28147 a1c6a512-1295-4272-9138-f99709370657
2010-09-23 00:37:33 +00:00
Thomas Martitz
e5d43300af
Explicitly disable hiding the selection bar by default.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28146 a1c6a512-1295-4272-9138-f99709370657
2010-09-23 00:13:11 +00:00
Thomas Martitz
ac08e6942a
Touchscreen: Improve scrolling in absolute point mode.
...
* Scrolling is now done by wiping over the screen. There's no acceleration or
kinetic scrolling yet though. But it works rather well (previously
you held the edges of the list to scroll).
* Improve scrollbar scrolling so that it keeps scrolling even if you leave the
scrollbar area.
* Hide selection during scrolling
* Prevent accidental hitting of the list title (which means go back) during
scrolling
* Don't go into context menu after scrolling when leaving the screen on an item
In general, it's very much like scrolling in native lists in Android,
except there's no kinetic scrolling and everything is still line based, but with
the feature that the scrollbar enables jumping around in the list and very fast
scrolling.
Thanks to Dustin Skoracki for his ideas and half of the code for this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28145 a1c6a512-1295-4272-9138-f99709370657
2010-09-23 00:02:32 +00:00
Thomas Martitz
3013103249
Bad copy&paste.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28140 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 22:56:12 +00:00
Thomas Martitz
138ee6304b
Use convenience function.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28139 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 22:55:24 +00:00
Rafaël Carré
2dde958478
eq menu: remove write-only variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28137 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 09:10:01 +00:00
Rafaël Carré
53ac2ca831
do_setting_from_menu(): remove write-only variables
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28136 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 09:04:22 +00:00
Rafaël Carré
7d9df48478
playback_callback(): remove write-only old_repeat_mode
...
Also don't ignore this_item argument, it's being used
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28135 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 08:59:27 +00:00
Rafaël Carré
45f3e5fb94
eq menu: remove write-only variable present since r8606
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28134 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 08:32:49 +00:00
Rafaël Carré
94f5f5b2fd
lang_load(): ignore unused field from the lang file
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28133 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 08:25:52 +00:00
Rafaël Carré
7c339c937a
parse_sap_header(): remove write-only variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28132 a1c6a512-1295-4272-9138-f99709370657
2010-09-21 08:25:46 +00:00
Thomas Martitz
aa01ee314e
Fix a bug in playlist viewer's list handling, causing superfluous redraws and
...
potentially leading to the wrong track being selected.
The playlist viewer should perform a bit better now.
I always felt it was slower than the otehr lists.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28131 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 23:10:19 +00:00
Bertrik Sikken
c0edce8f5c
iap: make variable serbuf non-global
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28128 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 19:37:17 +00:00
Marcin Bukat
93c50d4770
Remove the call to settings_save() from settings_load_config() as it seems unneeded any more and causes unecessary writes on every startup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28120 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 13:34:21 +00:00
Michael Giacomelli
cc6ef19dd9
Remove some unused variables.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28118 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 22:09:11 +00:00
Jonathan Gordon
2c8204cd91
Hopefully fix FS#11630 where the wps backdrop would be shown instead of the menu one
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28116 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 11:49:33 +00:00
Rafaël Carré
272e425a2f
get_mp3file_info(): Use the correct printf format in DEBUGF()
...
Also remove useless parens and casts in bytes2int()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28115 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:27:49 +00:00
Rafaël Carré
961b5dd4c1
tagcache open_files(): open the correct file (missed in r27656)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28114 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:15 +00:00
Rafaël Carré
d2000a9178
radio_screen() return value is unused -> void
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28113 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:08 +00:00
Rafaël Carré
c78d55a311
kbd_input(): move sc assignement under #ifdef HAVE_TOUCHSCREEN
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28112 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:02 +00:00
Rafaël Carré
37c1192753
ASAP parse_sap_header() : remove write only variables
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28111 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:56 +00:00
Rafaël Carré
f03141477a
setid3v2title(): unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28110 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:52 +00:00
Rafaël Carré
9afa8002ae
get_mp3file_info(): remove unused variable
...
frames_per_entry is only used for debugging
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28109 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:47 +00:00
Rafaël Carré
1dfebdddbe
playlist_shuffle(): remove unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28108 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:40 +00:00
Rafaël Carré
f18e630ef2
Update Polish translation
...
Author: Wojciech Lesniak
Flyspray: FS#11625
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28105 a1c6a512-1295-4272-9138-f99709370657
2010-09-18 03:51:54 +00:00
Frank Gevaerts
95aae36c6c
Fix red, stupid typo
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28103 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:34:47 +00:00
Frank Gevaerts
f366090562
Make disabling HAVE_PITCHSCREEN actually work without breaking the build
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28102 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:28:47 +00:00
Jonathan Gordon
10b6861bfd
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28094 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 14:01:43 +00:00
Jonathan Gordon
fbb008331d
skin engine: completly rework the sbs title handing code
...
This hopefully fixes the remaining data aborts and freezes when loading skins caused by the somewhat nasty list/sbs title handling code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28093 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 12:56:51 +00:00
Rafaël Carré
f8d1509a95
flac: more detailed debug message
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28087 a1c6a512-1295-4272-9138-f99709370657
2010-09-15 07:44:03 +00:00
Andree Buschmann
24d8e8ef1a
Minor macro redefinition in libfaad to avoid FIXED_POINT ifdef'ing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28085 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 20:40:56 +00:00
Andree Buschmann
9fb54ae32b
More unification of FIXED_POINT and FLOAT. Small refactoring.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28084 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 20:26:01 +00:00
Andree Buschmann
82c143c4e1
Also correct autocorrelation for yet undefined SBR_LOW_POWER. Unify FIXED_POINT and FLOAT implementation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28083 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:53:13 +00:00
Andree Buschmann
c8da311de4
Fix scaling error that was introduced with r28069. With this fix the level of the hf-spectrum will be correct when decoding aac-he files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28081 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:31:00 +00:00
Andree Buschmann
e98ee2d696
Correct comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28080 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:17:21 +00:00
Andree Buschmann
b543a2a5d2
Correct autocorrelation function in libfaad. It used the wrong fract part for the multiplication macros. Introduce appropriate solution to avoid overflow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28079 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:05:09 +00:00
Jonathan Gordon
f4e886158c
fix build (typo)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28078 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:40:42 +00:00
Jonathan Gordon
308ece9e9c
why did plugin.h need statusbar-skinned.h?
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28077 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:36:39 +00:00
Jonathan Gordon
75f04f56eb
woops
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28076 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:30:45 +00:00
Jonathan Gordon
71379cafb1
fix errors, warnings, tabs
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28075 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:21:56 +00:00
Jonathan Gordon
46142b91cd
new file got lost
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28074 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 11:59:52 +00:00
Jonathan Gordon
9928e3418f
Another major skin backend update/hopefully bugfix:
...
Skins are now more self contained in the skin manager which in the future might allow on demand skin loading (i.e smaller skin buffers)
Skin backdrops are also managed more intelegently (fixes a bug where you can get a crazy backdrop loaded if a .sbs fails to load)
the rockbox_default rescue theme is now called rockbox_failsafe to better express what it actually is.
This commit hopefully/maybe fixes the heavily reported data aborts, so please check if you are getting them
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28073 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 11:56:50 +00:00
Rafaël Carré
0928cdf074
pitch_detector: don't use a struct with only one member
...
use fixed point type (fixed == int32_t) directly
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28072 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 06:34:01 +00:00
Andree Buschmann
cba9d259b0
Further libfaad cleanup. Make libfaad compilable for floating point. Floating point cannot be used as reference though, as errorous noise is the result.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28071 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 06:03:39 +00:00
Andree Buschmann
f24e130017
Further libfaad cleanup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28070 a1c6a512-1295-4272-9138-f99709370657
2010-09-13 21:23:32 +00:00
Andree Buschmann
ddb936a0c5
Clean up libfaad's fixed point implementation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28069 a1c6a512-1295-4272-9138-f99709370657
2010-09-13 20:57:22 +00:00
Thomas Martitz
12a2889f8c
Fix sim reds (forgot \ at end of line).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28056 a1c6a512-1295-4272-9138-f99709370657
2010-09-09 16:29:21 +00:00
Thomas Martitz
d9508834ff
Bump plugin api for new functions.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28055 a1c6a512-1295-4272-9138-f99709370657
2010-09-09 16:18:23 +00:00
Thomas Martitz
0d4585b28f
Extend lc_open() to also being able to load overlay plugins.
...
For this it needs to look at the plugin header. Since lc_open() doesn't know
it's a plugin, the header needs to be changed slightly to include the new lc_header (which needs to be the first element in plugin_header so it can be casted savely).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28054 a1c6a512-1295-4272-9138-f99709370657
2010-09-09 16:17:21 +00:00