Michael Sevakis
62fb090ac4
Fix #11897 - Multiple 'divide by zero' while playing particular APE on Clip+. Problem and solution observed and checked on Gigabeat S by myself. Fix submitted by Mikhail Titov resolves it. range_decode_short was declared as returing 'int short' rather than 'unsigned short' resulting in unwanted sign extension.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29208 a1c6a512-1295-4272-9138-f99709370657
2011-02-05 09:59:36 +00:00
Andree Buschmann
d3934185ac
Correct the metronome keymap in the manual. Better describe buttons/actions in metronome help text. Closes FS#11773.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29204 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 21:20:50 +00:00
Andree Buschmann
5a2421a0de
Follow up on r29199. Move new codec types to the end of the list.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29203 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 11:43:45 +00:00
Andree Buschmann
7e63bfd2ab
Correctly re-initialize wma decoder on next track. This fixes strange observed issues (noise, crashes) which only could be solved through re-entering the wma codec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29202 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 11:05:33 +00:00
Andree Buschmann
4e74494d57
Changes in m4a parser: The metadata (e.g. sampling rate) for alac and aac must read from their dedicated metadata atom. Otherwise there might be wrong settings used. This patch also adds (commented) code which enables parsing for an alac metadata atom if neccessary. I have several sample files which require such parsing to find the metadata atom. Fixes FS#11719.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29201 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 09:23:04 +00:00
Andree Buschmann
6b476e7bec
Roll back unintentionally submitted file.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29200 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 08:36:34 +00:00
Andree Buschmann
7345ac124e
Submit FS#11918: Add 2 more codec types to be able to differentiate between AAC / AAC-HE and MPC SV7 / SV8. Additionally handle ATARI soundfiles in get_codec_base_type() as intended.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29199 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 08:28:23 +00:00
Michael Sevakis
1bb3d61ef3
MPEGPlayer: Try out a different frame drop scheme meant to skip in a more uniform way rather than running up late and jumping forward; will often drop more in long term to keep up in short term. Some other obscure fixes included: wait for 2 ref pics before decoding B-pics again after P or I frame drop or seeking (issue with open GOPs); draw the frame the decoder already has when beginning playback after a seek; rename a few vars.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29198 a1c6a512-1295-4272-9138-f99709370657
2011-02-03 03:14:12 +00:00
Thomas Martitz
b22b0dc101
Touchscreen: Fix minor redraw after entering the context menu.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29193 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 18:39:04 +00:00
Thomas Martitz
430ada0864
Redo r29168. Use similar but existing mechanism in the action system which seems to work better.
...
Don't eat buttons on context change if it was waiting for button release (you did need another release).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29192 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 18:30:10 +00:00
Thomas Martitz
48016d5e07
Reduce excessive debug output during mp3 parsing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29191 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 18:27:31 +00:00
Andree Buschmann
5d849a963e
Clean up multiple definitions of RAM size. Remove -DMEM (make) and MEM (code), use the already defined MEMORYSIZE instead.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29189 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 17:43:32 +00:00
Andree Buschmann
35bcdef144
Find a more consistent and resilient way to handle SBR upsampled files. The detection is only done in one place (the metadata parser) and takes into account that the m4a header might already report corrected frame/sample sizes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29188 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 15:12:55 +00:00
Andree Buschmann
4343399473
Recognize AAC-HE SBR with upsampling and correct duration, bitrate, seek and resume behaviour for such files. When SBR upsampling is used the decoder outputs the double amount of samples per frame. As the seek and resume functions do not know about this fact a special handling is introduced. Fixes issues reported in FS#11916.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29186 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 09:38:24 +00:00
Andree Buschmann
0a93396cde
Do not parse into 'ilst' atom if size is 0. Fixes playability issue in FS#11916.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29185 a1c6a512-1295-4272-9138-f99709370657
2011-02-02 09:28:48 +00:00
Magnus Holmgren
11b7a4fb26
Add a safety check in the resume seek code, just in case.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29181 a1c6a512-1295-4272-9138-f99709370657
2011-02-01 20:17:42 +00:00
Andree Buschmann
ee6a74e7e3
We seeked one chunk too far when resuming m4a files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29180 a1c6a512-1295-4272-9138-f99709370657
2011-02-01 19:55:54 +00:00
Thomas Martitz
4888d41b09
Pitchscreen: Small fix for the right touchscreen button.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29179 a1c6a512-1295-4272-9138-f99709370657
2011-02-01 15:01:44 +00:00
Andree Buschmann
411023c6be
Rework m4a seek/resume code. Seek/resume does now also work properly with files having sample_to_chunk of 1 or 2.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29178 a1c6a512-1295-4272-9138-f99709370657
2011-01-31 21:54:50 +00:00
Andree Buschmann
ad6c3bc8c5
Fix resume for m4a files. Solves FS#9306.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29175 a1c6a512-1295-4272-9138-f99709370657
2011-01-31 15:18:26 +00:00
Andree Buschmann
dedde47424
Limit the size of each ID3 metadata item to avoid that the metadata buffer is filled by single items. Fixes FS#11875, FS#9805 and FS#9299.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29174 a1c6a512-1295-4272-9138-f99709370657
2011-01-30 20:23:55 +00:00
Michael Sevakis
799fc0f103
Fix r29171 red. Forgot to replace a few.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29172 a1c6a512-1295-4272-9138-f99709370657
2011-01-30 01:15:23 +00:00
Michael Sevakis
18770dac2e
Use __builtin_constant_p() to select the best byteswapping method: constant or target optimized. Same macro can then be used for constant values and inits as well as non-constant.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29171 a1c6a512-1295-4272-9138-f99709370657
2011-01-30 00:58:45 +00:00
Antoine Cellerier
c0c769c5a8
Add widgets to android port.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29170 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 20:47:32 +00:00
Thomas Martitz
7436e7ab41
Touchscreen/lists: Hopefully fix glitchy behavior that happened after opening the context menu.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29168 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 16:33:25 +00:00
Thomas Martitz
3804befc13
Ugh, remove debug output.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29167 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 15:37:09 +00:00
Thomas Martitz
5e3d8f961c
Improve sometimes glitchy touchscreen handling in the pitchscreen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29166 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 15:34:36 +00:00
Thomas Martitz
c402519e31
Fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29165 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 15:14:23 +00:00
Thomas Martitz
5606719499
Fix oops in r29160 (apps went into games and vice versa).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29163 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 15:03:03 +00:00
Thomas Martitz
2bb81f70f5
Move fm radio related menus out of radio.c into apps/menus/.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29162 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 15:01:28 +00:00
Thomas Martitz
aa9a68a690
Android: Change menu button to go always (and not only in the wps) to the main menu and long menu to open the context menu.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29161 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 11:58:32 +00:00
Thomas Martitz
f7da333d12
Re-factor code for the plugins main menu item, enabling better icons in that menu.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29160 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 11:50:38 +00:00
Thomas Martitz
4aec8ef059
Fix SDL app build
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29159 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 01:26:43 +00:00
Thomas Martitz
42a8cc3835
Give the playlists main menu item a context menu (playlist settings).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29158 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 01:01:44 +00:00
Thomas Martitz
89a4cf2693
Change the way how playlists and system menu items in the main menu are internally invoked so that the mechanism to
...
pass the back button press to the android system (to let it go to the home screen) works for them.
This fixes that the back button goes still to the home screen after entering these items.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29157 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 01:01:12 +00:00
Mustapha Senhaji
70b99e3e2c
Some minor corrections for the czech translation.
...
Flyspray: FS#11909
Author: Marek Salaba
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29155 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 00:30:14 +00:00
Mustapha Senhaji
8855ac48db
Update the slovak translation.
...
Flyspray: FS#11905
Author: Peter Lecky
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29152 a1c6a512-1295-4272-9138-f99709370657
2011-01-29 00:21:37 +00:00
Thomas Martitz
b703d251be
Workaround the brokenness of realpath() a bit more.
...
At least on android it blindly writes to the end of the buffer passed to it assuming it's sufficiently. It wasn't in our case, resulting in a buffer overflow (and breakage).
This should fix strange problems relating to database initialization on application targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29147 a1c6a512-1295-4272-9138-f99709370657
2011-01-27 20:17:55 +00:00
Thomas Martitz
044de86d81
Fix FS#11904, filename generation was lacking a slash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29140 a1c6a512-1295-4272-9138-f99709370657
2011-01-26 07:46:02 +00:00
Andree Buschmann
4c38572997
Remove WPS related variable which is read but not set or changed. Closes FS#11396.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29139 a1c6a512-1295-4272-9138-f99709370657
2011-01-25 21:40:55 +00:00
Michael Sevakis
d796ab6f61
Pacbox: Fix assumption about LCD width of 128 implying the display needs vertical clipping. No more screen garbage on sa9200.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29138 a1c6a512-1295-4272-9138-f99709370657
2011-01-25 19:28:40 +00:00
Mustapha Senhaji
81682e723a
Update the russian translation.
...
Flyspray: FS#11882
Author: Simon Zhukovsky
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29137 a1c6a512-1295-4272-9138-f99709370657
2011-01-25 17:22:39 +00:00
Mustapha Senhaji
f29bc4b8ff
Update the chinese-simp translation.
...
Since "Yes" and "No" are context depending apparently,
replace them by "" for "Yes" and "Ã" for "No";
for voice use "¯" and "¦".
Flyspray: FS#11890
Author: Purling Nayuki
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29136 a1c6a512-1295-4272-9138-f99709370657
2011-01-25 17:20:56 +00:00
Michael Sevakis
c498a5cf08
MPEGPlayer: Account for drivers that pass pointers to their internal state variables to the audio callback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29135 a1c6a512-1295-4272-9138-f99709370657
2011-01-25 17:18:20 +00:00
Antoine Cellerier
ef980355c8
Move android notification display format logic to java code (no functional change, this is used by FS #11902 ).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29132 a1c6a512-1295-4272-9138-f99709370657
2011-01-24 17:10:56 +00:00
Teruaki Kawashima
01313d5039
* Rename backlight_force_on to backlight_ignore_timeout to make it clear what the function does.
...
* Add backlight_force_on() which forces to turn on backlight even when the setting is set to Off. use this in lamp.
No functional change except lamp.
See aslo FS#9883.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29128 a1c6a512-1295-4272-9138-f99709370657
2011-01-24 12:29:16 +00:00
Jonathan Gordon
f06f685273
New option for the bar tags: 'backdrop, <label>' will draw another image under the progressbar (only works with image and slider bars)
...
example:
%V(22,253,198,14,-)
%xl(a,PLAY_BAR_BACKDROP-240x320x16.bmp,0,0)
%pb(0,0,198,14,PLAY_BAR-240x320x16.bmp, backdrop, a)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29127 a1c6a512-1295-4272-9138-f99709370657
2011-01-24 09:04:28 +00:00
Marianne Arnold
cb39ac6b1e
Also update the two missing autoresume strings in the German translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29126 a1c6a512-1295-4272-9138-f99709370657
2011-01-23 22:45:09 +00:00
Dominik Riebeling
264e27d5b0
Add german translation for LANG_FM_RSSI.
...
Author: Uwe Wiebach
Flyspray: FS#11811
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29121 a1c6a512-1295-4272-9138-f99709370657
2011-01-23 18:08:50 +00:00
Michael Sevakis
6d2e7769e2
Better boost calculation for multifrequency CPUs. Frequencies between minimum and maximum count as fractional boost.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29115 a1c6a512-1295-4272-9138-f99709370657
2011-01-22 18:30:24 +00:00