devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity
29420 commits 1 branch 143 tags 210 MiB
Commit graph

1512 commits

Author SHA1 Message Date
Thomas Martitz
ce6b116bc1 Put exiting the wps entirely into the hands of the wps (restoring backdrops and statusbars, stop scrolling). Remove the restoration code from root_menu, and add some gwps_leave_wps at every possible return/screen change. This also unifies exiting the wps code-wise. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20399 a1c6a512-1295-4272-9138-f99709370657
 2009-03-19 23:04:39 +00:00
Thomas Martitz
71471062eb Move gwps_leave_wps() a bit down, so that the menu-statusbars are showing in sync with the rest of the followin screen. It was shown noticeably earlier, particularly if the fade on stop is on. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20355 a1c6a512-1295-4272-9138-f99709370657
 2009-03-19 14:33:22 +00:00
Thomas Martitz
aad712d39f Some style changes, move gwps_leave_wps a bit down; add a #define for restoration after 1 second and rename the one for instant restoration 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20330 a1c6a512-1295-4272-9138-f99709370657
 2009-03-17 01:56:20 +00:00
Thomas Martitz
680990912c Some internal rework of the wps: 
a) Put duplicated code together. The restoration code into the existing restoration part of the main loop, the exiting code into a separate function
b) Let the STATUSBAR_CHANGED event handle fixing the statusbar

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20329 a1c6a512-1295-4272-9138-f99709370657
 2009-03-17 01:39:20 +00:00
Thomas Martitz
74aba34b58 Move play_hop() to gwps.c and make it static. It's the only file that calls it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20306 a1c6a512-1295-4272-9138-f99709370657
 2009-03-12 18:50:24 +00:00
Bertrik Sikken
b24fafbf14 Yet more #include cleanups 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20249 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 20:28:15 +00:00
Bertrik Sikken
30a2713b6e Clean up some more #includes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20243 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 18:37:32 +00:00
Jens Arnold
3f69bb2b1d Bugfix: Text styles are not drawmodes, so stop storing them in the vieport's drawmode field. They're only used locally anyway. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20234 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 12:42:33 +00:00
Alexander Levin
03dcedbbea Changed the comment to more accurately reflect how it works 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20233 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 11:32:02 +00:00
Thomas Martitz
fd14cac7c2 Split HAVE_SCROLLWHEEL into HAVE_SCROLLWHEEL and HAVE_WHEEL_ACCELERATION, where the latter now activates the wheel acceleration code. 
HAVE_SCROLLWHEEL plainly indicates the existence of a scrollwheel, thus all ipods define it now (in addition to the ones and some 
sansas which did before). Same applies to the manual.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20177 a1c6a512-1295-4272-9138-f99709370657
 2009-03-02 19:25:50 +00:00
Jonathan Gordon
79967c7a49 Fix screens not redrawing the statusbar when they should. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20126 a1c6a512-1295-4272-9138-f99709370657
 2009-02-27 08:24:39 +00:00
Thomas Martitz
22b9eb4245 Cleanup play_hop() slightly and remove redundant/uneeded checks, reclaim a tiny bit of binsize 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20097 a1c6a512-1295-4272-9138-f99709370657
 2009-02-24 18:07:42 +00:00
Jens Arnold
2088ce9117 Fix Player status'bar' broken in r19894. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20062 a1c6a512-1295-4272-9138-f99709370657
 2009-02-20 15:00:34 +00:00
Maurus Cuelenaere
21ca86646f Touchscreen fixes: 
* better handling of clicks/taps above the list itself (which results in exiting the current menu)
 * fix 'entering the first item when clicking on the empty space below a list which has less items than a full screen can handle'


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20046 a1c6a512-1295-4272-9138-f99709370657
 2009-02-19 16:16:22 +00:00
Thomas Martitz
4395c12f4c Move parts into the if, as they're unused outside of it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20016 a1c6a512-1295-4272-9138-f99709370657
 2009-02-16 08:34:56 +00:00
Thomas Martitz
54c2f49a69 FS#9904 - Fix for FS#9894 - Position of the progress bar is not updated after the font is changed (with small changes by me) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20015 a1c6a512-1295-4272-9138-f99709370657
 2009-02-16 08:28:51 +00:00
Maurus Cuelenaere
39be5ff9ff Touchscreen devices: make scrolling up work better 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19989 a1c6a512-1295-4272-9138-f99709370657
 2009-02-12 15:58:55 +00:00
Thomas Martitz
dd13730112 Minor quickscreen and pitchscreen fixes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19924 a1c6a512-1295-4272-9138-f99709370657
 2009-02-05 00:14:52 +00:00
Jonathan Gordon
3f879eb6ae fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19918 a1c6a512-1295-4272-9138-f99709370657
 2009-02-04 05:22:03 +00:00
Jonathan Gordon
08e3ebbf8c Temp fix for the statusbar disappearing for a fraction of a second when the WPS is first opened 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19917 a1c6a512-1295-4272-9138-f99709370657
 2009-02-04 04:49:43 +00:00
Jonathan Gordon
92035f5cdd Accept FS#9836 which fixes a bit of a display glitch in the colour chooser (Thanks Teruaki) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19906 a1c6a512-1295-4272-9138-f99709370657
 2009-02-02 09:24:24 +00:00
Jonathan Gordon
701a593c5d continuation of last nights statusbar cleanup. 
accept FS#9858 and FS#9859
make the rec and fm screens force the statusbar the correct way now which doesnt need extra status variables


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19904 a1c6a512-1295-4272-9138-f99709370657
 2009-02-02 03:14:51 +00:00
Nils Wallménius
ee7f12644c Use unsigned constants to avoid adding another gcc-support routine and save a few bytes. This affects SH only. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19899 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 14:23:17 +00:00
Jonathan Gordon
036fb05dfd Accept a quick patch from Alexander Levin to neaten up the #defines and comments from my earlier commit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19897 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 13:43:08 +00:00
Jonathan Gordon
ee8c479dff this commit actually makes my previous one work when the statusbar setting is enabled but the bar has been forcibly removed from the screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19896 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 13:08:31 +00:00
Jonathan Gordon
80cb3551eb Statusbar handling fixes. 
Fixes FS#9845 - %we/%wd wasnt working
WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before)
screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon)

minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 11:34:16 +00:00
Bertrik Sikken
91948d12aa FS#9638 - temp_cue is unused and wasting memory. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19890 a1c6a512-1295-4272-9138-f99709370657
 2009-01-31 19:41:29 +00:00
Maurus Cuelenaere
36c71a60ca Get checkwps working again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19880 a1c6a512-1295-4272-9138-f99709370657
 2009-01-29 20:49:43 +00:00
Thomas Martitz
76ba8ec890 Some cleanup (such as #include cleanup, clearer variable names) in pitchscreen. Also, don't update the full display all the time, but only the necessary parts. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19871 a1c6a512-1295-4272-9138-f99709370657
 2009-01-28 20:14:01 +00:00
Thomas Martitz
0dd6641872 Fix list title setup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19870 a1c6a512-1295-4272-9138-f99709370657
 2009-01-28 18:06:58 +00:00
Jonathan Gordon
40ca3a4ccc fix the statusbar on the archos player... a more proper fix is probably to surround global_Settings.statusbar with #ifdef HAVE_LCD_BITMAP... maybe.. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19753 a1c6a512-1295-4272-9138-f99709370657
 2009-01-12 09:05:59 +00:00
Jonathan Gordon
b84fe020a5 use the playback PLAYBACK_EVENT_TRACK_CHANGE instead of the WPS to keep track of the current track (for follow playlist) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19747 a1c6a512-1295-4272-9138-f99709370657
 2009-01-11 04:03:17 +00:00
Jonathan Gordon
12b8f8de89 fix FS#9772 - the statusbars were not working correclty on multi screen targets in the WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19742 a1c6a512-1295-4272-9138-f99709370657
 2009-01-10 13:16:24 +00:00
Dominik Riebeling
36d8b7eebf Fix Quickscreen ACTION_QS_DOWNINV button to reverse direction of down entry which was broken with r17315. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19733 a1c6a512-1295-4272-9138-f99709370657
 2009-01-09 11:07:26 +00:00
Jonathan Gordon
04dcf117a1 revert part of r19705 which caused fS#9773 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19732 a1c6a512-1295-4272-9138-f99709370657
 2009-01-09 04:46:28 +00:00
Jonathan Gordon
a68e5d835f remove some useless/unused stuff from gwps.c 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19705 a1c6a512-1295-4272-9138-f99709370657
 2009-01-07 10:57:51 +00:00
Jonathan Gordon
f9329e4c92 Fix some wierdness with the debug menus... 
Set the current viewport back to NULL after the list is finished drawing, Screens 
should be setting it before they start drawing so this probably only effects the debug menus.
Also change how the statusbars are handled there to make things easier. (this change also forces the bars back on (if enabled) in the simple list widget.. hopefully this doesnt cause problems later)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19703 a1c6a512-1295-4272-9138-f99709370657
 2009-01-07 07:52:32 +00:00
Jonathan Gordon
8b9fdb540c redo how the statusbar updates are done. send the EVENT_GUI_ACTIONUPDATE event every time get_action() is called. The event wont be as realiable (timewise) as before, but seems to work better 
This also fixes FS#9761.
Also set the lcd font back to the ui font from the debug screens which use sysfont


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19681 a1c6a512-1295-4272-9138-f99709370657
 2009-01-05 09:59:11 +00:00
Jonathan Gordon
e74cc6d9da "fix" FS#9757 by handing the statusbar redraw event more correctly... the eqscreen needs to be converted to viewports to display the statusbar. 
fix the colour chooser screen to work with the bar redraw also


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19680 a1c6a512-1295-4272-9138-f99709370657
 2009-01-05 07:50:25 +00:00
Jonathan Gordon
de4d030653 minor code reshuffle to not call viewport_set_default so often 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19667 a1c6a512-1295-4272-9138-f99709370657
 2009-01-04 05:36:23 +00:00
Jonathan Gordon
4b472de39b a few more button/statusbar fixes... 
* hopefully fix the last of the plugins which dont handle the enw SYS event.
* fix FS#9750 - WPS's which dont specify (or force the wps on) wernt showing the statusbar at all
* lamp, battery_bench, *_flash button handling fixes
* plugins using the core menu code will again show the statusbar



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19656 a1c6a512-1295-4272-9138-f99709370657
 2009-01-03 13:27:19 +00:00
Nils Wallménius
3681ff197d Reorder of user_settings, cleaned out some unused settings grouped settings depending on the same preprocessor defines together a bit more to make it more readable, updated some comments. Plugin api bump and the wps token for 12/24 hour clock setting is now excluded for non rtc targets 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19655 a1c6a512-1295-4272-9138-f99709370657
 2009-01-03 12:48:06 +00:00
Jonathan Gordon
7555f34cb3 fix FS#9743: plugins using rb->do_menu() were dropped 8 pixels.. 
please oh please let this be the last fix :p


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19640 a1c6a512-1295-4272-9138-f99709370657
 2009-01-02 07:15:46 +00:00
Jonathan Gordon
b86f2d05fc woops... fix the header and bump the plugin API 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19636 a1c6a512-1295-4272-9138-f99709370657
 2009-01-02 01:43:00 +00:00
Jonathan Gordon
9296126417 More SYS_FOURHERTZ handling fixes.. (FS#9740 FS#9741) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19635 a1c6a512-1295-4272-9138-f99709370657
 2009-01-02 01:29:13 +00:00
Jonathan Gordon
a02702ce1d try again... BUTTON_NONE is not a sys event :p 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19631 a1c6a512-1295-4272-9138-f99709370657
 2009-01-01 05:12:27 +00:00
Jonathan Gordon
6728678385 fis FS#9739 - yesterdays statusbar commits broke the WPS disk spindown handling 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19630 a1c6a512-1295-4272-9138-f99709370657
 2009-01-01 05:04:34 +00:00
Jonathan Gordon
d6def79dca fix the yesno screen which I accidently broke with the last commites 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19624 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 10:02:35 +00:00
Jonathan Gordon
79b3e87004 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19623 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 06:11:23 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically. 
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 05:59:26 +00:00