When overwriting an existing directory, the idle
power off timer may fire during the mass-renaming
of individual files.
Change-Id: Iedbc882c2470c32129a162d31dab8e5031a929b9
Use the known difference in path length between src
and dst in order to detect an insufficient
buffer size not just for the source, but also for
the destination path during the pre-scan already.
Change-Id: I9e4caeb9b9d2cb1e9577f418f2b777ab17718acf
Scanning files before a delete or copy operation was
slowed down by splashf() being called too frequently.
- Delay and update splashf every 0.5s (the scan will
often be finished in a split second)
- Only clear screen buffer before scan info is redrawn
- Display name of *top* level item only, to prevent bar
from jumping around due to the string length changing
- Use item size for progress bar, so that the overall
progress isn't interrupted by each file's progress
- Display processed & total file sizes (KiB if total
is < 10MiB, or MiB otherwise)
- Move delete confirmation before scan to provide
instant UI feedback
Change-Id: I882a8db4161a46aca2d398e371ec4ed018fc8501
1) Remaining:
Sometimes, you may only be interested in how
much time is left in a playlist, but don't care
about the progress already made.
The new option will disregard already played tracks,
which can be much faster, depending on your position
in the playlist.
2) Single Mode:
When 'Single Mode' is enabled (and set to something
other than 'Track'), you now have the option to see
the time elapsed and remaining specifically for
that section of the playlist (e.g. the playing album).
Change-Id: I786eaababc537f565ab3fa4de1c46b7d5f3d1101
Launching a themed plugin can cause the screen to
flash due to the theme being disabled, before it
is re-enabled right away. For the Properties plugin
in particular, this seems a bit annoying and
unnecessary.
Change-Id: Ifa0275b453369051cc63a3c626551f54120fdb41
- prevent buffer overflow that could theoretically
happen if an input file's dirname were larger
than sizeof(str_dirname)
- remove has_pl_extension, use existing filetype_get_attr
- move determination of props type to single function, and
eliminate need for redundantly reading the container dir
for a file
Change-Id: Ice7cfcb9d891d22a8eb549439569dda126435bc2
allows viewers to pop a file browser to let the user pick a relevant file
which then gets run by the viewer
(only lua so far)
Change-Id: I7e6b4c2827fab5e9f596d336f546100636c4b871
Stops on first/last setting value when you switch quick setting using long button press. Useful for long settings list (like Skip Length).
Change-Id: Id7ddae4f70554e7f523661e5f0e09f5e4d5d32fd
The component after the final '/' can be a directory, so don't
unconditionally treat it as a file.
Also check to make sure there is something after the final '/' otherwise
we end up voicing it as '//'
Change-Id: I56d69ea3f299e524df29c328ec9eeb3cfc22ff42
Prevent switching to a fullscreen view when scanning
a directory, which could be a bit jarring, depending
on your theme of choice.
Also pop context menu activity immediately, without
refreshing, so it isn't redrawn when returning from
plugin.
Change-Id: I021e5880505e7f121163851ae732eb47509cc5d8
Also:
- Enables cpu boosting for Stats
(*much* faster on some players)
- Displays file size in Stats
Change-Id: I888ba054e1f8c2985fbf8dca36e11e6ef130e7ca
The former one ('cori') had some very pathological corner cases
especiallly when voicing single letters. This one is just
better all around.
Change-Id: I275256a637cf70ba196aafdecc24038bfe841955
- We only have to update stats->dirname when entering
a new directory, or when id3cb needs to be called
- Reduce frequency for calling get_action and LCD update
- Replace dir_stats->len and hardcoded MAX_PATH with
sizeof
- Don't show paths in Properties during scanning
- Don't show error when user cancels
Change-Id: I4afbeba561e69188e8039fa8d91eb1e91318bdab
Add up length and size of tracks in ms & Bytes,
then only convert units to s & KiB at the end.
Otherwise, the result can be noticeably off when
dealing with a large enough number of tracks.
Change-Id: I2a3e502508089830f63b24c3bbdbb0ab8f57cabe
Generalize the fix in 2348779ae6 to apply to hosted as well as simulator
builds. Original regression introduced in c0ac043c6d
Change-Id: Ia786533cc318555e3bb842eb21a73a1f76888379
From the Rockbox Translation website:
When the English language is set to "" or none, the translation should follow. The strings below don't do this. This is an error and should be fixed.
Change-Id: I4a6946170bf6bf5b4b1f14ebc4f8b3be6ff2f985
This brings the puzzles source in sync with Simon's branch, commit fd304c5
(from March 2024), with some added Rockbox-specific compatibility changes:
https://www.franklinwei.com/git/puzzles/commit/?h=rockbox-devel&id=516830d9d76bdfe64fe5ccf2a9b59c33f5c7c078
There are quite a lot of backend changes, including a new "Mosaic" puzzle.
In addition, some new frontend changes were necessary:
- New "Preferences" menu to access the user preferences system.
- Enabled spacebar input for several games.
Change-Id: I94c7df674089c92f32d5f07025f6a1059068af1e
When adding files to an existing playlist from
the database or file browser, Rockbox returns to
the root menu afterwards.
Appears to be a regression introduced in commit 72c539d
for the file browser. For the database, it has only
become noticeable since commit 188f025
Change-Id: Iac48fe74d20d25f083005f6ebff5abc7ee425080
make _lists_uiviewport_update_callback a oneshot
and reset it each call of list_do_action_timeout()
block multiple runs of gui_usb_screen_run() in the sim
Change-Id: I0c0429c42622c82bcf481ad13efdc47e9055a1bb
The idea is that a theme or whatever could use this to provide visual
differentiation (eg "George's iPod") between multiple
otherwise-identical players..
Defaults to an empty string.
Added to the manual but there is not a way to set this through the
menus yet.
Change-Id: I1cff6b19d621dd6207b4b82eed67741ce2da0ef1
- decrease max entries to the required minimum
- merge two info lines
- fix value in too many entries error message
Change-Id: I72eeca5dd9c7c2fbb4978d0972d4db532dfa901e
Crossfade (see Playback Settings -> Crossfade) now works between songs in Single Mode (see Playback Settings -> Single Mode) unless it’s the last song to be played.
Change-Id: Icfe3d48459bb35bbc050f237a68b27e793ab9152
