Miika Pekkarinen
eab434c416
More accurate playback position calculation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7218 a1c6a512-1295-4272-9138-f99709370657
2005-07-22 06:32:55 +00:00
Miika Pekkarinen
857ee67b6a
Fixed the unnecessary compiler warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7215 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 16:16:30 +00:00
Miika Pekkarinen
ab2163bdf5
Fixed the crossfade setting: Resuming stopped playback automatically
...
when changing values, setting crossfade amount correctly and pcm
drivers should not be re-initialized.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7214 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 15:47:29 +00:00
Miika Pekkarinen
f090dc3829
Crossfade (and pcm buffer size) length is now configurable.
...
Implemented anti-skip buffer setting for iriver also. Settings block
bumped up, PLEASE SAVE YOUR SETTINGS BEFORE UPGRADING.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7210 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 11:44:00 +00:00
Miika Pekkarinen
5755ffe60c
Fixed the backwards skipping.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7207 a1c6a512-1295-4272-9138-f99709370657
2005-07-20 18:50:07 +00:00
Miika Pekkarinen
bd1131e748
Implemented mp3_pause_done() for software codecs to make wps correctly
...
wait for pause to complete when fading the volume.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7205 a1c6a512-1295-4272-9138-f99709370657
2005-07-20 01:58:27 +00:00
Ryan Jackson
300fb882be
No longer crashes when resuming or on shutdown in car adapter mode
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7204 a1c6a512-1295-4272-9138-f99709370657
2005-07-19 22:01:47 +00:00
Miika Pekkarinen
d83b659fa7
Fixed track changing problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7201 a1c6a512-1295-4272-9138-f99709370657
2005-07-19 19:57:23 +00:00
Miika Pekkarinen
f5df9cd81c
Track count is now correct.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7185 a1c6a512-1295-4272-9138-f99709370657
2005-07-18 06:10:53 +00:00
Miika Pekkarinen
e361749fe2
Fixed a problem that caused codec switching to fail on certain rare
...
conditions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7184 a1c6a512-1295-4272-9138-f99709370657
2005-07-17 21:44:58 +00:00
Miika Pekkarinen
cd8bfeb8a3
Fixed the gapless playback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7180 a1c6a512-1295-4272-9138-f99709370657
2005-07-17 15:35:17 +00:00
Magnus Holmgren
08761aaa52
Restructured DSP code for readability and speed. Simplified the API.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7174 a1c6a512-1295-4272-9138-f99709370657
2005-07-16 12:25:28 +00:00
Miika Pekkarinen
cda55bbd6f
Correctly read the next track metadata information. Don't crash if
...
frequency is ever set to 0.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7171 a1c6a512-1295-4272-9138-f99709370657
2005-07-16 06:26:29 +00:00
Miika Pekkarinen
2e884cc85f
Revert back the previous commit, there are some problems with id3
...
fields to be solved.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7167 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:37:03 +00:00
Miika Pekkarinen
54395bbf3d
Don't read metadata twice.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7163 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:13:13 +00:00
Miika Pekkarinen
b6048c49ba
Don't hang when trying to stop paused playback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7159 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 18:42:01 +00:00
Miika Pekkarinen
34a25a6a3b
Fixed a problem that caused playback to stutter when changing tracks
...
fast.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7157 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 16:42:01 +00:00
Miika Pekkarinen
2159811c66
Fixed a problem that cpu boost didn't always reset when stopping the
...
playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7153 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 07:57:09 +00:00
Miika Pekkarinen
20b3897474
Separated buffering stuff from pcm_playback to pcmbuf. Renamed some
...
function calls (audiobuffer -> pcmbuf etc.).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7131 a1c6a512-1295-4272-9138-f99709370657
2005-07-13 12:48:22 +00:00
Ryan Jackson
d191756286
Resume now starts playback at the point it was stopped, not 2-7 seconds later.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7125 a1c6a512-1295-4272-9138-f99709370657
2005-07-12 16:45:38 +00:00
Miika Pekkarinen
2f6781d616
Resetting the pause indicator when seeking songs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7109 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 20:43:02 +00:00
Linus Nielsen Feltzing
c4b7c671f9
Patch #1235763 by Ryan Jackson - Resume/bookmark support for Vorbis
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7098 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 06:47:35 +00:00
Miika Pekkarinen
0d63cbba4b
Fixed a problem with transition to next album which caused rockbox
...
virtually to crash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7096 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 20:37:36 +00:00
Miika Pekkarinen
1ed292ca5e
Fixed an audio burst coming out when pausing a track with fading
...
enabled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7095 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 17:31:12 +00:00
Miika Pekkarinen
645a2e16ed
Fixed a simulator crash while trying to play a song. Fixed crossfade
...
when selecting a new track to play. Most likely fixed a bug which
caused playback to stop on track change.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7094 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 16:33:03 +00:00
Miika Pekkarinen
a9203b4d83
Updating wps info correctly when changing a track while buffering.
...
Fixed the delay while seeking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7093 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:54:19 +00:00
Miika Pekkarinen
527ce403ea
The previous commit did not fix the metadata reading correctly. Now it
...
should have been fixed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7092 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:46:12 +00:00
Miika Pekkarinen
b288dda685
Fixed a problem that next track info was not always available after the
...
initial file buffering.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7091 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:38:16 +00:00
Miika Pekkarinen
3e33f85f17
Track changing works now better (not still perfect).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7090 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 06:58:02 +00:00
Miika Pekkarinen
5d9e0536ea
Some playback fixes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7076 a1c6a512-1295-4272-9138-f99709370657
2005-07-08 20:01:06 +00:00
Linus Nielsen Feltzing
df80798a30
Lame hack to strip ID3v1 tags from MP3 playback, so they can play back without gaps
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7054 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 09:53:02 +00:00
Miika Pekkarinen
3eb962d13b
PCM buffering fixes. Made a temporary workaround for playback glitch
...
bug (see the patch).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7049 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 07:15:05 +00:00
Linus Nielsen Feltzing
ffd207f4b0
Makes sure that the pause/resume/prev/next functions are executed in the audio thread
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7043 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 19:40:17 +00:00
Miika Pekkarinen
22960c3f95
Waiting pcm buffer to run empty before stopping the last track.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7040 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 15:44:59 +00:00
Miika Pekkarinen
5c2c991d14
Applied patch "[ 1232957 ] MP3 metadata fixes for software codec".
...
Thanks to Magnus Holmgren. Now metadata reading is better with
improved performance for mp3 files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7030 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 19:55:40 +00:00
Miika Pekkarinen
3e33a0f8ee
More crossfade adjustments. Now crossfade should work shortly even if
...
the disk was not spinning while a new track was loaded from the disk.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7028 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 15:51:59 +00:00
Miika Pekkarinen
d6e7942426
Fixed: Crossfading, broken elapsed info with mp3 files, possible cpu
...
boost problem and track changing.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7027 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 15:19:22 +00:00
Miika Pekkarinen
2d79df5086
Fixed a problem that caused playback to stop on certain situations. Fixed
...
buffer filling issue if we try to buffer more than MAX_TRACK tracks at
a same time.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7026 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 13:34:52 +00:00
Miika Pekkarinen
aa30f0483b
Fixed crossfading.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7022 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 07:25:55 +00:00
Hardeep Sidhu
839dbcaed7
Moved resume info updating to the mpeg/playback threads so that it's saved even when not in the WPS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7018 a1c6a512-1295-4272-9138-f99709370657
2005-07-04 22:50:57 +00:00
Miika Pekkarinen
8ad60cced2
Update the wps when next track info is available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7005 a1c6a512-1295-4272-9138-f99709370657
2005-07-04 06:06:30 +00:00
Miika Pekkarinen
e21cf8440a
Fixed the warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6997 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 19:20:40 +00:00
Miika Pekkarinen
9bde0380a6
Updated the track_unbuffer event callback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6995 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 18:36:24 +00:00
Miika Pekkarinen
f46c9f204c
Now next track info is always available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6994 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 18:03:20 +00:00
Jens Arnold
bb3ed3cda9
Use the central IDATA_ATTR define.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6992 a1c6a512-1295-4272-9138-f99709370657
2005-07-03 15:09:11 +00:00
Miika Pekkarinen
d50ed1248d
The last small fix to the previous commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6990 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:55:51 +00:00
Miika Pekkarinen
837c1e3cad
Correction to the previous commit when switching tracks manually.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6989 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:49:13 +00:00
Miika Pekkarinen
b469e73246
Use correct timing to display the next track wps screen when crossfade
...
is activated.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6988 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:45:12 +00:00
Miika Pekkarinen
9c70b1b562
Make sure we stop the playback the right way.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6987 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 17:03:19 +00:00
Miika Pekkarinen
d54811fe22
Fixed mono playback support for mp3. Added two other event handlers in
...
playback.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6986 a1c6a512-1295-4272-9138-f99709370657
2005-07-02 16:52:30 +00:00