1
0
Fork 0
forked from len0rd/rockbox
Commit graph

13829 commits

Author SHA1 Message Date
Andree Buschmann
29a855245c Fix residual red. Keep index in mp3entry for HWCODEC.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29692 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 22:11:12 +00:00
Andree Buschmann
39d9d8bab1 Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29691 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 21:38:51 +00:00
Andree Buschmann
4df825be43 Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29690 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 20:33:00 +00:00
Björn Stenberg
2d00f0c8b2 Removed some dead code identified by clang-analyzer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29685 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 21:08:31 +00:00
Andree Buschmann
3184cbe10a Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29682 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 19:11:40 +00:00
Andree Buschmann
d1766a1510 Rework parts of the replaygain code to be able to differentiate between 0.00 dB set intentionally and having no replaygain information at all. Bump codec api.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29679 a1c6a512-1295-4272-9138-f99709370657
2011-04-04 15:21:44 +00:00
Andree Buschmann
a7354e7925 Cosmetic change of a comment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29666 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 22:06:52 +00:00
Andree Buschmann
29164ccbcc Changing convert_gain() also implicitly changed get_replaygain_int() which could lead to div by zero. This patch finds another way to fix the replaygain fallback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29665 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 21:46:09 +00:00
Andree Buschmann
4f7930b883 Fix for replaygain: Ensure fallback to track gain in case of missing album gain.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29664 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 12:44:29 +00:00
Björn Stenberg
ce755dd9c5 Only set volume on SYS_VOLUME_CHANGED the first time. Workaround for FS#12034.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29663 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 07:04:44 +00:00
Bertrik Sikken
81d67d0dda Revert accidental commit of apps/plugins/SOURCES
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29661 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:44:09 +00:00
Bertrik Sikken
8351a1aa9d AMSv2 sd: do not try to switch sd cards into high-speed mode.
High-speed mode is only half implemented (sd controller still uses normal speed) and causes card detection problems.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29660 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:37:40 +00:00
Rafaël Carré
8c3fc23ae6 remove set but unused variable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29659 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:36 +00:00
Rafaël Carré
cde3c9a08e maze: fix warning spotted by gcc 4.6.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29658 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:23 +00:00
Jonathan Gordon
87aa86cedd Skin variables for touchscreen targets (origional implementation by Jens Theeß)
%vs(name, [set|inc|dec], value [,max]) - name is the id, set sets the value, inc increments by value, dec decrements by value
%vg(name) - get the current value
%vl(name [,timeout]) - 'has it changed in [timeout]'?

values start at 1 and are all reset to 1 on skin load

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29655 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 08:01:58 +00:00
Jonathan Gordon
969381322d Fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29654 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:30:23 +00:00
Jonathan Gordon
443b134983 Fix touchregions muting volume, and change &<action> to mean 'needs long press but only fire once'. Use *<action> for 'long press and allow repeats'
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29653 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:23:38 +00:00
Andree Buschmann
0258895faa Fix error in Ohm's law formula as provided in FS#12023. Thanks to Leif Andersen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29644 a1c6a512-1295-4272-9138-f99709370657
2011-03-25 07:22:38 +00:00
Andree Buschmann
afe6ee4300 Fix FS#12024. Scroll acceleration did not work -- at least reported for iRiver H10 -- caused by too short duration for button repeat recognition.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29642 a1c6a512-1295-4272-9138-f99709370657
2011-03-24 18:42:27 +00:00
Andree Buschmann
04bd51fbcb Scroll speed is increased every N seconds, not every N half seconds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29635 a1c6a512-1295-4272-9138-f99709370657
2011-03-22 21:29:05 +00:00
Andree Buschmann
0897753d3b Submit parts of FS#12024. Describe the settings 'List Acceleration Start Delay' and 'List Acceleration Speed' in the manual. Correct the unit (seconds) for the first setting and change the text for the second setting.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29634 a1c6a512-1295-4272-9138-f99709370657
2011-03-22 21:15:22 +00:00
Jonathan Gordon
f4e152bdef Make repeat mode/shuffle work in the sbs also
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29632 a1c6a512-1295-4272-9138-f99709370657
2011-03-22 09:41:11 +00:00
Jonathan Gordon
98881fd822 Add some playback controls to the SBS. 2 new touch regions wps_next/wps_prev needed to make it work. 'next' in the sbs changes list selection, 'wps_next' in sbs changes audio tracks. no difference in the wps
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29631 a1c6a512-1295-4272-9138-f99709370657
2011-03-22 09:31:45 +00:00
Michael Sevakis
4823b2b1c0 Buffering should truncate if read() returns 0 since it's not a valid return there as there should be data left to read. The loop wouldn't break until there was a message in the queue. I just experienced the case with crosslinked files and read stopped making progress, returning 0 each time it was called.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29626 a1c6a512-1295-4272-9138-f99709370657
2011-03-21 15:57:07 +00:00
Andree Buschmann
e9c5190de7 Headroom in AAC SBR HF-generator's fixed point implementation of autocorrelation was too small. Fixes FS#12019.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29622 a1c6a512-1295-4272-9138-f99709370657
2011-03-20 15:57:38 +00:00
Nils Wallménius
5aaabbfd12 FS#12014 by Huan Zhang fixing some link errors with a recent mips toolchain.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29615 a1c6a512-1295-4272-9138-f99709370657
2011-03-19 10:14:12 +00:00
Bertrik Sikken
528e1850bf FS#12016 - Update Chinese Translation by Purling Nayuki
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29614 a1c6a512-1295-4272-9138-f99709370657
2011-03-19 09:59:32 +00:00
Andree Buschmann
e209002c13 Optimize memory consumption in the mp3data parser. The vbr-header parser will never need 1.800 byte of data. The maximum amount of data needed is 1/10 of this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29610 a1c6a512-1295-4272-9138-f99709370657
2011-03-18 07:08:25 +00:00
Andree Buschmann
c59a086da6 Local implementation of read_uint32be() in mp3data.c needs a major correction.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29609 a1c6a512-1295-4272-9138-f99709370657
2011-03-17 18:13:14 +00:00
Andree Buschmann
742980f94c Avoid magic numbers. Use the available defines to set up the bit mask to compare MPEG frame headers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29607 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 22:05:46 +00:00
Andree Buschmann
3706d6d0b5 Hopefully fix red now and reduce binsize for HWCODEC targets. This change implements a local read_uint32be() function within the mp3data parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29606 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 21:57:16 +00:00
Andree Buschmann
ea61fb8023 Fix red. read_uint32be() was not implemented in sim builds for HWCODEC targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29605 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 21:24:07 +00:00
Marcin Bukat
f6c610de0d HD300: RECTRIGGER keymap
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29604 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 20:24:35 +00:00
Andree Buschmann
25246f7e47 More robust implementation of MPEG frame header search. The parser will not only search for the very first byte sequence that looks like a valid MPEG frame header. It will search for a valid MPEG frame header sequence, decode it, and probe if there is a consecutive MPEG frame header of the same type (MPEG version, layer, sampling frequency) at the expected position. This approach will reduce false detection of MPEG frame headers in case of errorous metadata or garbaged files. Fixes FS#12007.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29603 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 18:45:03 +00:00
Thomas Martitz
8c46ddf9d7 Android: Implement app shutdown and thus, sleep timer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29602 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 15:17:24 +00:00
Thomas Martitz
046cec3aa7 Android: Partly revert r29569 and only call the new getJavaEnvironment() when needed.
The environment is fine to share in general, just not across OS threads, so it's only needed
for functions which are possibly called from multiple OS threads (only 1 currently).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29601 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 14:33:55 +00:00
Thomas Martitz
a0c664850c Fix FS#12012 - Radio Art broken since r29259 - Embedded album art support
Forgot to adapt radio art to the new bufopen user_data argument.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29598 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 10:20:32 +00:00
Marcin Bukat
ccd53953b2 MPIO HD300: add KBD context keymap
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29597 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 07:38:23 +00:00
Michael Sevakis
a4098e6174 Sync test_codec to r29595.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29596 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 05:59:46 +00:00
Michael Sevakis
56dd75d204 Purge buffer and codec APIs existing exclusively in support of mpa.codec and fix that to not require them: buf_get_offset and ci.advance_buffer_loc. Sort APIs; everything must become incompatible. :(
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29595 a1c6a512-1295-4272-9138-f99709370657
2011-03-16 05:38:37 +00:00
Marcin Bukat
2e4259e497 recording.c
1) fix bug in fmt_gain()
2) take into account steps field of sound_settings_info struct when inc/dec gain

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29593 a1c6a512-1295-4272-9138-f99709370657
2011-03-15 22:35:04 +00:00
Andree Buschmann
c24c3ebe0f Disable debug output in wave format parser by default.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29592 a1c6a512-1295-4272-9138-f99709370657
2011-03-15 20:27:26 +00:00
Andree Buschmann
d9e85475c5 Submit FS#12009. Add embedded album art support for m4a. Thanks to Jason Yu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29591 a1c6a512-1295-4272-9138-f99709370657
2011-03-15 20:17:28 +00:00
Björn Stenberg
9c41252d77 Fixed a typo. (Thanks Jeff!)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29587 a1c6a512-1295-4272-9138-f99709370657
2011-03-14 15:01:11 +00:00
Björn Stenberg
e50cc0e3d7 Listen to and follow external Android volume changes. (Based on FS#11914 by Maurus Cuelenaere)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29586 a1c6a512-1295-4272-9138-f99709370657
2011-03-14 12:25:48 +00:00
Marcin Bukat
606bed035e Update lang files to be inline with changes in r29584
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29585 a1c6a512-1295-4272-9138-f99709370657
2011-03-14 10:28:45 +00:00
Marcin Bukat
a8dc45f511 slightly modified FS#11531 by me: WM8750/51 driver rework
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29584 a1c6a512-1295-4272-9138-f99709370657
2011-03-14 09:58:19 +00:00
Andree Buschmann
8aed244bd8 Add up skipped bytes when parsing for valid MPEG headers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29583 a1c6a512-1295-4272-9138-f99709370657
2011-03-13 19:59:27 +00:00
Andree Buschmann
ff1b2b7fab Refactor reading of Xing/Info/Vbri tags to prepare for further changes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29582 a1c6a512-1295-4272-9138-f99709370657
2011-03-13 19:25:20 +00:00
Michael Sevakis
7cac18f94b Use ringbuf_add in buffering when incrementing for initial allocation of non-wrapping data. The result of the shortcut would have been wrong if the handle used space exactly to the end of the buffer since buf_widx wouldn't have been properly wrapped to index 0.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29578 a1c6a512-1295-4272-9138-f99709370657
2011-03-13 11:56:51 +00:00