devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

[BugFix] Multiboot Database duplicate files

Browse source 
When the sd card is mounted into the root namespace the database
picks up files through both paths

previously we hid the mounted drive but this causes issues with users
databases when the drive letter changes

Adds a way to keep track of volumes mounted in the root namespace

Hides the enumerated volume in root

Database:
we can just parse the root directory ('/') and get to any mounted
volume but we can also enumerate a volume in the root directory
when this occurs it leads to multiple entries since the files can
be reached through multiple paths ex, /Foo could also be /SD1/Foo
Instead we will attempt to rewrite the root with any non-hidden volumes
failing that just leave the paths alone

Change-Id: I7bdba8cfaf63902d2a3852d28484bcf8ca317ebd
This commit is contained in:
William Wilgus 2024-03-21 18:27:23 -04:00
parent ae01ea7fd9
commit fdc3668a6a
11 changed files with 198 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

3
firmware/include/rb_namespace.h
View file

@ -37,6 +37,8 @@ struct ns_scan_info
};
/* root functions */
#define ROOT_MAX_REALPATH 80
const char* root_get_realpath(void);
int root_mount_path(const char *path, unsigned int flags);
void root_unmount_volume(IF_MV_NONVOID(int volume));
int root_readdir_dirent(struct filestr_base *stream,
@ -49,6 +51,7 @@ int ns_open_root(IF_MV(int volume,) unsigned int *callflagsp,
struct file_base_info *infop, uint16_t *attrp);
int ns_open_stream(const char *path, unsigned int callflags,
struct filestr_base *stream, struct ns_scan_info *scanp);
bool ns_volume_is_visible(IF_MV_NONVOID(int volume));
/* closes the namespace stream */
static inline int ns_close_stream(struct filestr_base *stream)