devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Fix possible truncation albumart.c

Browse source 
Change-Id: Ie0e576f26c0507cc12fbdc12093d6fe924377e1d
This commit is contained in:
William Wilgus 2019-07-09 22:58:06 -05:00
parent c0dbfc8130
commit fc7a45853b
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/recorder/albumart.c
View file

@ -141,7 +141,7 @@ static bool try_exts(char *path, int len)
bool search_albumart_files(const struct mp3entry *id3, const char *size_string, bool search_albumart_files(const struct mp3entry *id3, const char *size_string,
char *buf, int buflen) char *buf, int buflen)
{ {
char path[MAX_PATH + 1]; char path[MAX_PATH + 11]; /* need room for filename and null termination */
char dir[MAX_PATH + 1]; char dir[MAX_PATH + 1];
bool found = false; bool found = false;
int track_first = 1; int track_first = 1;
@ -281,7 +281,7 @@ bool find_albumart(const struct mp3entry *id3, char *buf, int buflen,
if (!id3 || !buf) if (!id3 || !buf)
return false; return false;
char size_string[9]; char size_string[15];/* .-32768x-32768\0 */
logf("Looking for album art for %s", id3->path); logf("Looking for album art for %s", id3->path);
/* Write the size string, e.g. ".100x100". */ /* Write the size string, e.g. ".100x100". */