devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

short circuit is_diacritic for 5-15% text drawing speed-up

Browse source 
characters less than the first diacritic in the symbol table (0x300)
return false after checking the MRU table

we gain some performance by eliding the function call all together if less than first diacritic

Change-Id: I02c14e350eb168eca808523affad443cd43888b4
This commit is contained in:
William Wilgus 2025-01-31 13:36:50 -05:00
parent c5103bab95
commit f501dd00eb
4 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
firmware/drivers/lcd-bitmap-common.c
View file

@ -434,7 +434,7 @@ static void LCDFN(putsxyofs)(int x, int y, int ofs, const unsigned char *str)
if (x >= vp->width)
break;
is_diac = is_diacritic(*ucs, &is_rtl);
is_diac = IS_DIACRITIC_RTL(*ucs, &is_rtl);
/* Get proportional width and glyph bits */
width = font_get_width(pf, *ucs);
@ -450,7 +450,7 @@ static void LCDFN(putsxyofs)(int x, int y, int ofs, const unsigned char *str)
const unsigned short *u;
/* Jump to next non-diacritic char, and calc its width */
for (u = &ucs[1]; *u && is_diacritic(*u, NULL); u++);
for (u = &ucs[1]; *u && IS_DIACRITIC(*u); u++);
rtl_next_non_diac_width = *u ? font_get_width(pf, *u) : 0;
}
@ -510,7 +510,7 @@ static void LCDFN(putsxyofs)(int x, int y, int ofs, const unsigned char *str)
if (next_ch)
{
bool next_is_rtl;
bool next_is_diacritic = is_diacritic(next_ch, &next_is_rtl);
bool next_is_diacritic = IS_DIACRITIC_RTL(next_ch, &next_is_rtl);
/* Increment if:
* LTR: Next char is not diacritic,