devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Minor confirm prompt adjustments

Browse source 
* Rename LANG_RESET_ASK to LANG_ARE_YOU_SURE,
  so that it matches the actual language string
  (translations remain valid), and can be repurposed
  for generic confirmation prompts, where the
  first line says "Are you sure?", and the second
  line reiterates the selected action

* Add "Reset Settings" as second line to the prompt
  shown before resetting settings, instead of just
  asking "Are you sure?"

* Make Shuffle prompt consistent between WPS and
  Playlist Viewer, and ask whether user is sure they
  want to Shuffle instead of warning them that the
  current playlist will be erased, which was a bit
  misleading

* Explicitly say "Cancelled" when user answers NO to
  erasing the current playlist or to overwriting a file.
  Improves consistency with other prompts that are
  displayed for potentially destructive actions, e.g.
  before items are deleted, renamed, saved, or reset.

* PictureFlow: Prompt before rebuilding/updating cache

Change-Id: Id8ae36db7187315eb1a374701307e6ab4dcdbd1d
This commit is contained in:
Christian Soffke 2025-05-25 03:23:49 +02:00
parent 57f3f290c9
commit f3d127f372
55 changed files with 169 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/plugins/pictureflow/pictureflow.c
View file

@ -3590,6 +3590,11 @@ static int display_settings_menu(void)
rb->set_bool(rb->str(LANG_RESIZE_COVERS), &pf_cfg.resize);
if (old_val == pf_cfg.resize) /* changed? */
break;
else if (!rb->yesno_pop_confirm(ID2P(LANG_RESIZE_COVERS)))
{
pf_cfg.resize = old_val;
break;
}
pf_cfg.update_albumart = false;
pf_cfg.cache_version = CACHE_REBUILD;
@ -3766,6 +3771,8 @@ static int main_menu(void)
break;
#endif
case PF_REBUILD_CACHE:
if (!rb->yesno_pop_confirm(ID2P(LANG_REBUILD_CACHE)))
break;
pf_cfg.update_albumart = false;
pf_cfg.cache_version = CACHE_REBUILD;
rb->remove(EMPTY_SLIDE);
@ -3773,6 +3780,8 @@ static int main_menu(void)
CONFIG_NUM_ITEMS, CONFIG_VERSION);
return -3; /* re-init */
case PF_UPDATE_CACHE:
if (!rb->yesno_pop_confirm(ID2P(LANG_UPDATE_CACHE)))
break;
pf_cfg.update_albumart = true;
pf_cfg.cache_version = CACHE_REBUILD;
rb->remove(EMPTY_SLIDE);