From f1eedb80a2efbf60cfc25182b72e3da07e0f1250 Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Mon, 6 Feb 2012 22:35:08 +0100 Subject: [PATCH] Don't try to save settings if none available. Fixes a crash when leaving the encoder settings dialog with the Ok button but the dynamically loaded library missing, in which case no settings will be available. Change-Id: I889a0bbcde6bed2df658b5df57341edf6802daad --- rbutil/rbutilqt/base/encoderlame.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/rbutil/rbutilqt/base/encoderlame.cpp b/rbutil/rbutilqt/base/encoderlame.cpp index 75289481fb..8950d416c9 100644 --- a/rbutil/rbutilqt/base/encoderlame.cpp +++ b/rbutil/rbutilqt/base/encoderlame.cpp @@ -82,11 +82,12 @@ void EncoderLame::generateSettings() void EncoderLame::saveSettings() { - // no user settings right now. - RbSettings::setSubValue("lame", RbSettings::EncoderVolume, - getSetting(VOLUME)->current().toDouble()); - RbSettings::setSubValue("lame", RbSettings::EncoderQuality, - getSetting(QUALITY)->current().toDouble()); + if(m_symbolsResolved) { + RbSettings::setSubValue("lame", RbSettings::EncoderVolume, + getSetting(VOLUME)->current().toDouble()); + RbSettings::setSubValue("lame", RbSettings::EncoderQuality, + getSetting(QUALITY)->current().toDouble()); + } } bool EncoderLame::start()