devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

config: Change default HAVE_MULTIVOLUME settings

Browse source 
* HAVE_MULTIDRIVE implies HAVE_MULTIVOLUME as the latter is always
   removeable storage
 * SD storage implies MULTIVOLUME
 * ATA storage (with HAVE_LBA48) implies MULTIVOLUME
 * Replace HAVE_MULTIDRIVE && NUM_DRIVES == 1 with HAVE_MULTIVOLUME

Since SD and ATA can exceed 2TB, we need multiple volumes to fully
utilize available storage with FAT32.

In practice I believe this only affects the ipod devices.

Change-Id: Ia597770948b0e2b47630f7264ad34f225a33a640
This commit is contained in:
Solomon Peachy 2024-07-06 10:42:47 -04:00
parent af1eddb6e9
commit ea80d1cc9c
19 changed files with 18 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

16
firmware/export/config.h
View file

@ -868,6 +868,18 @@ Lyre prototype 1 */
#define CONFIG_STORAGE_MULTI
#endif
#if !defined(HAVE_MULTIVOLUME)
#if defined(HAVE_MULTIDRIVE)
/* Multidrive strongly implies multivolume */
#define HAVE_MULTIVOLUME
#elif (CONFIG_STORAGE & STORAGE_SD)
/* SD routinely have multiple partitions */
#elif (CONFIG_STORAGE & STORAGE_ATA) && defined(HAVE_LBA48)
/* ATA routinely haves multiple partitions, but don't bother if we can't do LBA48 */
#define HAVE_MULTIVOLUME
#endif
#endif
/* Explicit HAVE_MULTIVOLUME in the config file. Allow the maximum number */
#ifdef HAVE_MULTIVOLUME
#define NUM_VOLUMES_PER_DRIVE 4
@ -878,10 +890,6 @@ Lyre prototype 1 */
#define HAVE_MULTIDRIVE
#endif
#if defined(HAVE_MULTIDRIVE) && !defined(HAVE_MULTIVOLUME)
#define HAVE_MULTIVOLUME
#endif
#if defined(HAVE_MULTIDRIVE) && !defined(NUM_DRIVES)
#error HAVE_MULTIDRIVE needs to have an explicit NUM_DRIVES
#endif