From e6687c11f25c9f6358676bb2aff0781bebf1ac79 Mon Sep 17 00:00:00 2001 From: Sebastian Leonhardt Date: Sat, 25 Jun 2016 16:30:37 +0200 Subject: [PATCH] Rockboy: revert FS#11745 patch William Shipley sent this patch via mailing list. Original Message: "There was a patch to rockboy in 2010 that fixed a problem where the bottom tile row would be rendered at the top. Here's the relevant issue from that time: http://www.rockbox.org/tracker/11745 Note that Stummi openly admits it was a hack, not a true fix. Sometime in the 6 years since, the root cause was fixed. Currently, rockboy on the Clip+ and other 64px models shows the top of the gb screen along the bottom of the display. I confirmed that reversing this patch fixes the issue on my own Clip+" I don't have any of the mentioned targets, so someone else has to test. Change-Id: Id29b78c4ece0af53ba1280029c18b76808a21da2 --- apps/plugins/rockboy/sys_rockbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/plugins/rockboy/sys_rockbox.c b/apps/plugins/rockboy/sys_rockbox.c index a758f73da3..31bab1c478 100644 --- a/apps/plugins/rockboy/sys_rockbox.c +++ b/apps/plugins/rockboy/sys_rockbox.c @@ -294,7 +294,7 @@ void vid_update(int scanline) scanline-=16; else if (fb.mode==2) scanline-=8; - scanline_remapped = (scanline / 16 + 7) % 8; + scanline_remapped = scanline / 16; frameb = rb->lcd_framebuffer + scanline_remapped * LCD_WIDTH; while (cnt < 160) { balance += LCD_WIDTH;