From e3323e3ba7280e5d624a2ba63603344508e2f2d8 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Sun, 8 Dec 2024 17:44:19 -0500 Subject: [PATCH] Revert "libmad synth.c silence warnings" This reverts commit b14056e90fb86a5494fb70ab3632c2aef1c91e96. Reason for revert: Not mathematically equivalent, inconsistent with other code paths, and leads to audio artifacts on ARM targets. Change-Id: I71646e6e8df2aa2c57decdb5360daff870670c87 --- lib/rbcodec/codecs/libmad/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rbcodec/codecs/libmad/synth.c b/lib/rbcodec/codecs/libmad/synth.c index e82f50dd67..ebcf3d5015 100644 --- a/lib/rbcodec/codecs/libmad/synth.c +++ b/lib/rbcodec/codecs/libmad/synth.c @@ -863,7 +863,7 @@ void synth_full(struct mad_synth *synth, struct mad_frame const *frame, fo = &(*filter)[1][~phase & 1][0]; D0ptr = (void*)&D[0][ p]; - D1ptr = (void*)D-p; + D1ptr = (void*)&D[0][-p]; if(s & 1) {