devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

metadata: mp3: Simplify comment tag processing

Browse source 
Avoid unnecessary string comparison.

Change-Id: Ib1c5622f7b7760c43c4763930dc4ef6b409dbc05
This commit is contained in:
Roman Artiukhin 2024-11-07 11:12:01 +02:00 • committed by Solomon Peachy
parent 2156d9874f
commit da478aaa32
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/rbcodec/metadata/id3tags.c
View file

@ -996,8 +996,7 @@ retry_with_limit:
* remove them so unicode_munge can work correctly * remove them so unicode_munge can work correctly
*/ */
if((tr->tag_length == 4 && !memcmp( header, "COMM", 4)) || if (tr->offset == offsetof(struct mp3entry, comment)) {
(tr->tag_length == 3 && !memcmp( header, "COM", 3))) {
int offset; int offset;
if (buffersize - bufferpos <= 4) if (buffersize - bufferpos <= 4)
return; /* Error ?? */ return; /* Error ?? */