devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Use LIST_WRAP_UNLESS_HELD consistently

Browse source 
LIST_WRAP_ON seems to only be used in 3 places
at this point.

- Keybox Plugin
- Puzzles Plugin
- (File) Properties Plugin

Switch them them over to LIST_WRAP_UNLESS_HELD
as that is used everywhere else and is arguably
preferable (the option to turn off list wrapping
completely remains, of course).

Change-Id: Id8017dcbb123a0568cb6db527a8966b63ba06d47
This commit is contained in:
Christian Soffke 2021-12-05 14:23:18 +01:00 • committed by Aidan MacDonald
parent daa3967071
commit d93a3cac50
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/plugins/keybox.c
View file

@ -567,7 +567,7 @@ static int keybox(void)
{
rb->gui_synclist_draw(&kb_list);
button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
if (rb->gui_synclist_do_button(&kb_list, &button, LIST_WRAP_ON))
if (rb->gui_synclist_do_button(&kb_list, &button, LIST_WRAP_UNLESS_HELD))
continue;
switch (button)

2
apps/plugins/properties.c
View file

@ -490,7 +490,7 @@ enum plugin_status plugin_start(const void* parameter)
{
button = rb->get_action(CONTEXT_LIST, HZ);
/* HZ so the status bar redraws corectly */
if (rb->gui_synclist_do_button(&properties_lists,&button,LIST_WRAP_ON))
if (rb->gui_synclist_do_button(&properties_lists,&button,LIST_WRAP_UNLESS_HELD))
continue;
switch(button)
{

6
apps/plugins/puzzles/rockbox.c
View file

@ -2459,7 +2459,7 @@ static int list_choose(const char *list_str, const char *title, int sel)
{
rb->gui_synclist_draw(&list);
int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_ON))
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
continue;
switch(button)
{
@ -2674,7 +2674,7 @@ static bool config_menu(void)
{
rb->gui_synclist_draw(&list);
int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_ON))
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
continue;
switch(button)
{
@ -2760,7 +2760,7 @@ static int do_preset_menu(struct preset_menu *menu, char *title, int selected)
{
rb->gui_synclist_draw(&list);
int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_ON))
if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
continue;
switch(button)
{