devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

gui: Remove "enum list_wrap" from list action functions

Browse source 
Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.

This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.

Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
This commit is contained in:
Aidan MacDonald 2022-09-19 12:48:15 +01:00
parent ff378deb69
commit d5a081cbd1
28 changed files with 53 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/PLUGIN_API
View file

@ -669,7 +669,7 @@ void gui_synclist_del_item(struct gui_synclist * lists)
\param lists
\description
bool gui_synclist_do_button(struct gui_synclist * lists, unsigned *action, enum list_wrap wrap)
bool gui_synclist_do_button(struct gui_synclist * lists, unsigned *action)
\group list
\param lists
\param action