forked from len0rd/rockbox
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy. In practice, almost all lists are using LIST_WRAP_UNLESS_HELD behavior so we can make that the default. A couple of lists disable wraparound with LIST_WRAP_OFF; this is now achieved by setting the list "wraparound" flag to false when setting up the list. LIST_WRAP_ON was unused and is of questionable value, so it has been removed entirely. This makes list wraparound behavior a property of the list, controlled solely by the "wraparound" flag. The result is a simpler list API and implementation, without changing the behavior of any lists. Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
This commit is contained in:
parent
ff378deb69
commit
d5a081cbd1
28 changed files with 53 additions and 86 deletions
|
|
@ -59,13 +59,8 @@ enum sc_list_action_type draw_sc_list(struct gui_synclist *gui_sc)
|
|||
/* user input */
|
||||
button = rb->get_action(CONTEXT_LIST, HZ);
|
||||
/* HZ so the status bar redraws corectly */
|
||||
if (rb->gui_synclist_do_button(gui_sc, &button,
|
||||
LIST_WRAP_UNLESS_HELD)) {
|
||||
/* automatic handling of user input.
|
||||
* _UNLESS_HELD can be _ON or _OFF also
|
||||
* selection changed, so redraw */
|
||||
if (rb->gui_synclist_do_button(gui_sc, &button))
|
||||
continue;
|
||||
}
|
||||
switch (button) { /* process the user input */
|
||||
case ACTION_STD_OK:
|
||||
return SCLA_SELECT;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue