devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

load_code/overlay: Don't close plugin handle before calling the plugin.

Browse source 
Doesnt fix an actual bug because closing a handle is a no-op on all
native targets and others dont use overlay.

Change-Id: Ie55e3fd4abd08b174d86ca25aed54a970dddbebd
This commit is contained in:
Thomas Martitz 2012-05-26 22:57:21 +02:00
parent 3f365fc06b
commit d523fd6e64
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/plugins/lib/overlay.c
View file

@ -52,6 +52,7 @@ enum plugin_status run_overlay(const void* parameter,
void *handle; void *handle;
struct plugin_header *p_hdr; struct plugin_header *p_hdr;
struct lc_header *hdr; struct lc_header *hdr;
enum plugin_status retval = PLUGIN_ERROR;
audiobuf = rb->plugin_get_audio_buffer(&audiobuf_size); audiobuf = rb->plugin_get_audio_buffer(&audiobuf_size);
if (!audiobuf) if (!audiobuf)
@ -90,13 +91,11 @@ enum plugin_status run_overlay(const void* parameter,
goto error_close; goto error_close;
} }
rb->lc_close(handle);
*(p_hdr->api) = rb; *(p_hdr->api) = rb;
return p_hdr->entry_point(parameter); retval = p_hdr->entry_point(parameter);
/* fall through */
error_close: error_close:
rb->lc_close(handle); rb->lc_close(handle);
error: error:
return PLUGIN_ERROR; return retval;
} }