1
0
Fork 0
forked from len0rd/rockbox

Do extra filtering in H300 (and H100) main unit button reading to suppress wrong readings during voltage transitions. * Optimised multi-button ADC reads to use a balanced binary tree with an initial check for 'any button' to determine the pressed button. * The iriver button driver wouldn't have detected main unit (ADC-connected) buttons as long as remote buttons (ADC-connected) were pressed (btn = value; vs. btn |= value), * Do extra filtering in the recorder v1 OFF button read, to suppress spurious OFF events. * Some more tweaks.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9530 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jens Arnold 2006-04-06 07:27:11 +00:00
parent 857db456af
commit cef83c782f

View file

@ -393,8 +393,8 @@ static int ipod_3g_button_read(void)
return btn; return btn;
} }
#endif #endif
static void button_tick(void) static void button_tick(void)
{ {
static int tick = 0; static int tick = 0;
@ -482,10 +482,9 @@ static void button_tick(void)
#ifdef HAVE_SW_POWEROFF #ifdef HAVE_SW_POWEROFF
if ((btn == POWEROFF_BUTTON if ((btn == POWEROFF_BUTTON
#ifdef BUTTON_RC_STOP #ifdef BUTTON_RC_STOP
|| btn == BUTTON_RC_STOP) && || btn == BUTTON_RC_STOP
#else
) &&
#endif #endif
) &&
#if defined(HAVE_CHARGING) && !defined(HAVE_POWEROFF_WHILE_CHARGING) #if defined(HAVE_CHARGING) && !defined(HAVE_POWEROFF_WHILE_CHARGING)
!charger_inserted() && !charger_inserted() &&
#endif #endif
@ -836,14 +835,12 @@ static int button_read(void)
{ {
int btn = BUTTON_NONE; int btn = BUTTON_NONE;
int retval; int retval;
int data; int data;
#if (CONFIG_KEYPAD == IRIVER_H100_PAD)\ #if (CONFIG_KEYPAD == IRIVER_H100_PAD) || (CONFIG_KEYPAD == IRIVER_H300_PAD)
|| (CONFIG_KEYPAD == IRIVER_H300_PAD)
static bool hold_button = false; static bool hold_button = false;
static bool remote_hold_button = false; static bool remote_hold_button = false;
static int last_button_val= 0xff;
/* light handling */ /* light handling */
if (hold_button && !button_hold()) if (hold_button && !button_hold())
@ -863,6 +860,8 @@ static int button_read(void)
{ {
data = adc_scan(ADC_BUTTONS); data = adc_scan(ADC_BUTTONS);
#if CONFIG_KEYPAD == IRIVER_H100_PAD #if CONFIG_KEYPAD == IRIVER_H100_PAD
if ((data < 0xf0) && ((unsigned)(data - last_button_val + 1) <= 2))
{
if (data < 0x80) if (data < 0x80)
if (data < 0x30) if (data < 0x30)
if (data < 0x18) if (data < 0x18)
@ -884,9 +883,11 @@ static int button_read(void)
if (data < 0xd0) if (data < 0xd0)
btn = BUTTON_MODE; btn = BUTTON_MODE;
else else
if (data < 0xf0)
btn = BUTTON_REC; btn = BUTTON_REC;
}
#else /* H300 */ #else /* H300 */
if ((data < 0xba) && ((unsigned)(data - last_button_val + 1) <= 2))
{
if (data < 0x54) if (data < 0x54)
if (data < 0x30) if (data < 0x30)
if (data < 0x10) if (data < 0x10)
@ -902,10 +903,10 @@ static int button_read(void)
else else
btn = BUTTON_RIGHT; btn = BUTTON_RIGHT;
else else
if(data < 0xba)
btn = BUTTON_OFF; btn = BUTTON_OFF;
}
#endif #endif
last_button_val = data;
} }
/* remote buttons */ /* remote buttons */
@ -915,79 +916,85 @@ static int button_read(void)
switch (remote_type()) switch (remote_type())
{ {
case REMOTETYPE_H100_LCD: case REMOTETYPE_H100_LCD:
if (data < 0xf5)
{
if (data < 0x73) if (data < 0x73)
if (data < 0x3f) if (data < 0x3f)
if (data < 0x25) if (data < 0x25)
if(data < 0x0c) if(data < 0x0c)
btn = BUTTON_RC_STOP; btn |= BUTTON_RC_STOP;
else else
btn = BUTTON_RC_VOL_DOWN; btn |= BUTTON_RC_VOL_DOWN;
else else
btn = BUTTON_RC_MODE; btn |= BUTTON_RC_MODE;
else else
if (data < 0x5a) if (data < 0x5a)
btn = BUTTON_RC_VOL_UP; btn |= BUTTON_RC_VOL_UP;
else else
btn = BUTTON_RC_BITRATE; btn |= BUTTON_RC_BITRATE;
else else
if (data < 0xa8) if (data < 0xa8)
if (data < 0x8c) if (data < 0x8c)
btn = BUTTON_RC_REC; btn |= BUTTON_RC_REC;
else else
btn = BUTTON_RC_SOURCE; btn |= BUTTON_RC_SOURCE;
else else
if (data < 0xdf) if (data < 0xdf)
if(data < 0xc5) if(data < 0xc5)
btn = BUTTON_RC_FF; btn |= BUTTON_RC_FF;
else else
btn = BUTTON_RC_MENU; btn |= BUTTON_RC_MENU;
else else
if (data < 0xf5) btn |= BUTTON_RC_REW;
btn = BUTTON_RC_REW; }
break; break;
case REMOTETYPE_H300_LCD: case REMOTETYPE_H300_LCD:
if (data < 0xf5)
{
if (data < 0x73) if (data < 0x73)
if (data < 0x42) if (data < 0x42)
if (data < 0x27) if (data < 0x27)
if(data < 0x0c) if(data < 0x0c)
btn = BUTTON_RC_VOL_DOWN; btn |= BUTTON_RC_VOL_DOWN;
else else
btn = BUTTON_RC_FF; btn |= BUTTON_RC_FF;
else else
btn = BUTTON_RC_STOP; btn |= BUTTON_RC_STOP;
else else
if (data < 0x5b) if (data < 0x5b)
btn = BUTTON_RC_MODE; btn |= BUTTON_RC_MODE;
else else
btn = BUTTON_RC_REC; btn |= BUTTON_RC_REC;
else else
if (data < 0xab) if (data < 0xab)
if (data < 0x8e) if (data < 0x8e)
btn = BUTTON_RC_ON; btn |= BUTTON_RC_ON;
else else
btn = BUTTON_RC_BITRATE; btn |= BUTTON_RC_BITRATE;
else else
if (data < 0xde) if (data < 0xde)
if(data < 0xc5) if(data < 0xc5)
btn = BUTTON_RC_SOURCE; btn |= BUTTON_RC_SOURCE;
else else
btn = BUTTON_RC_VOL_UP; btn |= BUTTON_RC_VOL_UP;
else else
if (data < 0xf5) btn |= BUTTON_RC_REW;
btn = BUTTON_RC_REW; }
break; break;
case REMOTETYPE_H300_NONLCD: case REMOTETYPE_H300_NONLCD:
if (data < 0xf1)
{
if (data < 0x7d) if (data < 0x7d)
if (data < 0x25) if (data < 0x25)
btn = BUTTON_RC_FF; btn |= BUTTON_RC_FF;
else else
btn = BUTTON_RC_REW; btn |= BUTTON_RC_REW;
else else
if (data < 0xd5) if (data < 0xd5)
btn = BUTTON_RC_VOL_DOWN; btn |= BUTTON_RC_VOL_DOWN;
else else
if(data<0xf1) /* 0xff no button pressed */ btn |= BUTTON_RC_VOL_UP;
btn = BUTTON_RC_VOL_UP; }
break; break;
} }
} }
@ -1020,7 +1027,6 @@ static int button_read(void)
} }
#elif CONFIG_KEYPAD == IRIVER_IFP7XX_PAD #elif CONFIG_KEYPAD == IRIVER_IFP7XX_PAD
static bool hold_button = false; static bool hold_button = false;
/* light handling */ /* light handling */
@ -1034,7 +1040,8 @@ static int button_read(void)
if (!button_hold()) if (!button_hold())
{ {
data = adc_read(ADC_BUTTONS); data = adc_read(ADC_BUTTONS);
if (data < 0x35c)
{
if (data < 0x151) if (data < 0x151)
if (data < 0xc7) if (data < 0xc7)
if (data < 0x41) if (data < 0x41)
@ -1053,44 +1060,32 @@ static int button_read(void)
if (data < 0x2f9) if (data < 0x2f9)
btn = BUTTON_EQ; btn = BUTTON_EQ;
else else
if (data < 0x35c)
btn = BUTTON_MODE; btn = BUTTON_MODE;
} }
if (!button_hold() && (adc_read(ADC_BUTTON_PLAY) < 0x64)) if (adc_read(ADC_BUTTON_PLAY) < 0x64)
btn |= BUTTON_PLAY; btn |= BUTTON_PLAY;
}
#elif CONFIG_KEYPAD == RECORDER_PAD #elif CONFIG_KEYPAD == RECORDER_PAD
#ifndef HAVE_FMADC
#ifdef HAVE_FMADC static int off_button_count = 0;
if ( adc_read(ADC_BUTTON_ON) < 512 )
btn |= BUTTON_ON;
if ( adc_read(ADC_BUTTON_OFF) > 512 )
btn |= BUTTON_OFF;
#else
/* check port B pins for ON and OFF */
data = PBDR;
if ((data & 0x0100) == 0)
btn |= BUTTON_ON;
if ((data & 0x0010) == 0)
btn |= BUTTON_OFF;
#endif #endif
/* check F1..F3 and UP */ /* check F1..F3 and UP */
data = adc_read(ADC_BUTTON_ROW1); data = adc_read(ADC_BUTTON_ROW1);
if (data >= LEVEL1) if (data >= LEVEL1)
{ {
if (data >= LEVEL3) if (data >= LEVEL3)
if (data >= LEVEL4) if (data >= LEVEL4)
btn |= BUTTON_F3; btn = BUTTON_F3;
else else
btn |= BUTTON_UP; btn = BUTTON_UP;
else else
if (data >= LEVEL2) if (data >= LEVEL2)
btn |= BUTTON_F2; btn = BUTTON_F2;
else else
btn |= BUTTON_F1; btn = BUTTON_F1;
} }
/* Some units have mushy keypads, so pressing UP also activates /* Some units have mushy keypads, so pressing UP also activates
@ -1100,7 +1095,6 @@ static int button_read(void)
{ {
/* check DOWN, PLAY, LEFT, RIGHT */ /* check DOWN, PLAY, LEFT, RIGHT */
data = adc_read(ADC_BUTTON_ROW2); data = adc_read(ADC_BUTTON_ROW2);
if (data >= LEVEL1) if (data >= LEVEL1)
{ {
if (data >= LEVEL3) if (data >= LEVEL3)
@ -1116,11 +1110,33 @@ static int button_read(void)
} }
} }
#elif CONFIG_KEYPAD == PLAYER_PAD #ifdef HAVE_FMADC
if ( adc_read(ADC_BUTTON_ON) < 512 )
btn |= BUTTON_ON;
if ( adc_read(ADC_BUTTON_OFF) > 512 )
btn |= BUTTON_OFF;
#else
/* check port B pins for ON and OFF */
data = PBDR;
if ((data & 0x0100) == 0)
btn |= BUTTON_ON;
if ((data & 0x0010) == 0)
{
/* When the batteries are low, the low-battery shutdown logic causes
* spurious OFF events due to voltage fluctuation on some units.
* Only accept OFF when read several times in sequence. */
if (++off_button_count > 3)
btn |= BUTTON_OFF;
}
else
off_button_count = 0;
#endif
#elif CONFIG_KEYPAD == PLAYER_PAD
/* buttons are active low */ /* buttons are active low */
if (adc_read(0) < 0x180) if (adc_read(0) < 0x180)
btn |= BUTTON_LEFT; btn = BUTTON_LEFT;
if (adc_read(1) < 0x180) if (adc_read(1) < 0x180)
btn |= BUTTON_MENU; btn |= BUTTON_MENU;
if(adc_read(2) < 0x180) if(adc_read(2) < 0x180)
@ -1136,46 +1152,54 @@ static int button_read(void)
btn |= BUTTON_STOP; btn |= BUTTON_STOP;
#elif CONFIG_KEYPAD == ONDIO_PAD #elif CONFIG_KEYPAD == ONDIO_PAD
/* Check the 4 direction keys */
data = adc_read(ADC_BUTTON_ROW1);
if (data >= LEVEL1)
{
if (data >= LEVEL3)
if (data >= LEVEL4)
btn = BUTTON_LEFT;
else
btn = BUTTON_RIGHT;
else
if (data >= LEVEL2)
btn = BUTTON_UP;
else
btn = BUTTON_DOWN;
}
if(adc_read(ADC_BUTTON_OPTION) > 0x200) /* active high */ if(adc_read(ADC_BUTTON_OPTION) > 0x200) /* active high */
btn |= BUTTON_MENU; btn |= BUTTON_MENU;
if(adc_read(ADC_BUTTON_ONOFF) < 0x120) /* active low */ if(adc_read(ADC_BUTTON_ONOFF) < 0x120) /* active low */
btn |= BUTTON_OFF; btn |= BUTTON_OFF;
/* Check the 4 direction keys */ #elif CONFIG_KEYPAD == GMINI100_PAD
data = adc_read(ADC_BUTTON_ROW1); data = adc_read(7);
if (data < 0x38a)
if (data >= LEVEL1)
{ {
if (data >= LEVEL3) if (data < 0x1c5)
if (data >= LEVEL4) if (data < 0xe3)
btn |= BUTTON_LEFT; btn = BUTTON_LEFT;
else else
btn |= BUTTON_RIGHT; btn = BUTTON_DOWN;
else else
if (data >= LEVEL2) if (data < 0x2a2)
btn |= BUTTON_UP; btn = BUTTON_RIGHT;
else else
btn |= BUTTON_DOWN; btn = BUTTON_UP;
} }
#elif CONFIG_KEYPAD == GMINI100_PAD data = adc_read(6);
if (data < 0x355)
if (adc_read(7) < 0xE3) {
btn |= BUTTON_LEFT; if (data < 0x288)
else if (adc_read(7) < 0x1c5) if (data < 0x233)
btn |= BUTTON_DOWN;
else if (adc_read(7) < 0x2a2)
btn |= BUTTON_RIGHT;
else if (adc_read(7) < 0x38a)
btn |= BUTTON_UP;
if (adc_read(6) < 0x233)
btn |= BUTTON_OFF; btn |= BUTTON_OFF;
else if (adc_read(6) < 0x288) else
btn |= BUTTON_PLAY; btn |= BUTTON_PLAY;
else if (adc_read(6) < 0x355) else
btn |= BUTTON_MENU; btn |= BUTTON_MENU;
}
data = P7; data = P7;
if (data & 0x01) if (data & 0x01)
@ -1185,6 +1209,7 @@ static int button_read(void)
(void)data; (void)data;
/* The int_btn variable is set in the button interrupt handler */ /* The int_btn variable is set in the button interrupt handler */
btn = int_btn; btn = int_btn;
#elif (CONFIG_KEYPAD == IPOD_3G_PAD) #elif (CONFIG_KEYPAD == IPOD_3G_PAD)
(void)data; (void)data;
btn = ipod_3g_button_read(); btn = ipod_3g_button_read();
@ -1200,6 +1225,8 @@ static int button_read(void)
if (!hold_button) if (!hold_button)
{ {
data = adc_scan(ADC_BUTTONS); data = adc_scan(ADC_BUTTONS);
if (data < 0xf0)
{
if(data < 0x7c) if(data < 0x7c)
if(data < 0x42) if(data < 0x42)
btn = BUTTON_LEFT; btn = BUTTON_LEFT;
@ -1218,9 +1245,9 @@ static int button_read(void)
if(data < 0xd3) if(data < 0xd3)
btn = BUTTON_DOWN; btn = BUTTON_DOWN;
else else
if(data < 0xf0)
btn = BUTTON_UP; btn = BUTTON_UP;
} }
}
/* remote buttons */ /* remote buttons */
data = adc_scan(ADC_REMOTE); data = adc_scan(ADC_REMOTE);
@ -1228,27 +1255,29 @@ static int button_read(void)
remote_hold_button = true; remote_hold_button = true;
if(!remote_hold_button) if(!remote_hold_button)
{
if (data < 0xee)
{ {
if(data < 0x7a) if(data < 0x7a)
if(data < 0x41) if(data < 0x41)
btn = BUTTON_RC_REW; btn |= BUTTON_RC_REW;
else else
if(data < 0x61) if(data < 0x61)
btn = BUTTON_RC_FF; btn |= BUTTON_RC_FF;
else else
btn = BUTTON_RC_MODE; btn |= BUTTON_RC_MODE;
else else
if(data < 0xb4) if(data < 0xb4)
if(data < 0x96) if(data < 0x96)
btn = BUTTON_RC_REC; btn |= BUTTON_RC_REC;
else else
btn = BUTTON_RC_MENU; btn |= BUTTON_RC_MENU;
else else
if(data < 0xd1) if(data < 0xd1)
btn = BUTTON_RC_VOL_UP; btn |= BUTTON_RC_VOL_UP;
else else
if(data < 0xee) btn |= BUTTON_RC_VOL_DOWN;
btn = BUTTON_RC_VOL_DOWN; }
} }
data = GPIO_READ; data = GPIO_READ;
@ -1260,7 +1289,6 @@ static int button_read(void)
#endif /* CONFIG_KEYPAD */ #endif /* CONFIG_KEYPAD */
#ifdef HAVE_LCD_BITMAP #ifdef HAVE_LCD_BITMAP
if (btn && flipped) if (btn && flipped)
btn = button_flip(btn); /* swap upside down */ btn = button_flip(btn); /* swap upside down */