devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

[coverity] font.c load_cache_entry check for successful read

Browse source 
Change-Id: Ic2d8d6e498417983af7ee691f53dfb1e951561fa
This commit is contained in:
William Wilgus 2024-06-02 10:32:47 -04:00
parent 5d34887d4a
commit cc67f420f2
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
firmware/font.c
View file

@ -724,7 +724,6 @@ load_cache_entry(struct font_cache_entry* p, void* callback_data)
struct font* pf = callback_data; struct font* pf = callback_data;
unsigned short char_code = p->_char_code; unsigned short char_code = p->_char_code;
unsigned char tmp[2];
int fd; int fd;
lock_font_handle(pf->handle, true); lock_font_handle(pf->handle, true);
@ -755,11 +754,14 @@ load_cache_entry(struct font_cache_entry* p, void* callback_data)
else else
fd = pf->fd; fd = pf->fd;
lseek(fd, offset, SEEK_SET); lseek(fd, offset, SEEK_SET);
read (fd, tmp, 2); unsigned char tmp[2];
bitmap_offset = tmp[0] | (tmp[1] << 8); if (read (fd, tmp, 2) == 2)
if (pf->long_offset) { {
read (fd, tmp, 2); bitmap_offset = tmp[0] | (tmp[1] << 8);
bitmap_offset |= (tmp[0] << 16) | (tmp[1] << 24); if (pf->long_offset) {
if (read (fd, tmp, 2) == 2)
bitmap_offset |= (tmp[0] << 16) | (tmp[1] << 24);
}
} }
} }
else else