devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

quake: fix race condition

Browse source 
COM_LoadStackFile was not thread-safe since it relied on a global variable
to pass the loadbuf parameter to COM_LoadFile. This was causing mysterious
crashes when model loading and audio mixing were happening simultaneously.

Change-Id: I505c5ef0ed49d0c4aa4b11cfed05647c75b5b40d
This commit is contained in:
Franklin Wei 2019-07-29 20:59:11 -04:00
parent 0b23348610
commit caee6c578d
2 changed files with 37 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
apps/plugins/sdl/progs/quake/model.c
View file

@ -1472,8 +1472,11 @@ void Mod_LoadAliasModel (model_t *mod, void *buffer)
version = LittleLongUnaligned (pinmodel->version);
if (version != ALIAS_VERSION)
{
rb->splashf(HZ*2, "Likely race condition! S_LoadSound and this use the same allocator!");
Sys_Error ("%s has wrong version number (%i should be %i)",
mod->name, version, ALIAS_VERSION);
}
//
// allocate space for a working header, plus all the data except the frames,