devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Remove unnecessary (and incorrect) acks after stalling the control endpoint

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25359 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Frank Gevaerts 2010-03-27 19:41:37 +00:00
parent b917337be9
commit c689496e04
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
firmware/usbstack/usb_core.c
View file

@ -507,14 +507,6 @@ static void allocate_interfaces_and_endpoints(void)
usb_core_num_interfaces = interface; usb_core_num_interfaces = interface;
} }
static int usb_core_ack_control(struct usb_ctrlrequest* req)
{
if (req->bRequestType & USB_DIR_IN)
return usb_drv_recv(EP_CONTROL,NULL,0);
else
return usb_drv_send(EP_CONTROL,NULL,0);
}
static void control_request_handler_drivers(struct usb_ctrlrequest* req) static void control_request_handler_drivers(struct usb_ctrlrequest* req)
{ {
@ -536,7 +528,6 @@ static void control_request_handler_drivers(struct usb_ctrlrequest* req)
/* nope. flag error */ /* nope. flag error */
logf("bad req:desc %d:%d", req->bRequest, req->wValue>>8); logf("bad req:desc %d:%d", req->bRequest, req->wValue>>8);
usb_drv_stall(EP_CONTROL, true, true); usb_drv_stall(EP_CONTROL, true, true);
usb_core_ack_control(req);
} }
} }
@ -744,7 +735,6 @@ static void request_handler_endoint_drivers(struct usb_ctrlrequest* req)
/* nope. flag error */ /* nope. flag error */
logf("usb bad req %d",req->bRequest); logf("usb bad req %d",req->bRequest);
usb_drv_stall(EP_CONTROL,true,true); usb_drv_stall(EP_CONTROL,true,true);
usb_core_ack_control(req);
} }
} }