devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

rk27xx: do not disable irq in commit_discard_dcache_range()

Browse source 
commit_discard_dcache_range() is used in sd, lcd and pcm drivers
to handle transfers form/to data buffers so this should not introduce
any problems. It is reported to fix pop noise observed on some hifimans.
We apparently don't fully understand cache handling on this platform.

Change-Id: I436d291509f91d16a13d10965a28171fb27574ab
This commit is contained in:
Marcin Bukat 2013-02-12 08:48:43 +01:00
parent 6c5bc31ff7
commit c66a66728c
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
firmware/target/arm/rk27xx/system-rk27xx.c
View file

@ -222,8 +222,6 @@ void commit_discard_dcache_range (const void *base, unsigned int size)
uint32_t end_opcode = (uint32_t)((uintptr_t)base + size) | 0x01;
uint32_t opcode = (uint32_t)((uintptr_t)base & 0xffffffe0) | 0x01;
int old_irq = disable_irq_save();
while (opcode <= end_opcode)
{
while (CACHEOP & 0x03);
@ -231,8 +229,6 @@ void commit_discard_dcache_range (const void *base, unsigned int size)
CACHEOP = opcode;
opcode += 32;
}
restore_irq(old_irq);
}
#ifdef HAVE_ADJUSTABLE_CPU_FREQ