viewports, set flags to VP_DEFAULT_FLAGS

flags were getting un-initialized memory
it really didn't matter with the flags getting initialized
anyway
But once I added a new flag that didn't explicitly
set or clear the flag at init well here we are

set flags to VP_DEFAULT_FLAGS in viewport_set_defaults()

add the flags variable to the default vp's set to 0
(it was already initialized to 0 by bss, make it explicit)

Change-Id: I3a9a062455b4cf66d2b8c70fdf05402a5c0c091c

apps/gui/viewport.c

@@ -332,7 +332,7 @@ void viewport_set_defaults(struct viewport *vp,
                             const enum screen_type screen)
 {
     vp->buffer = NULL; /* use default frame_buffer */
-
+    vp->flags = VP_DEFAULT_FLAGS;
 #if !defined(__PCTOOL__)
     struct viewport *sbs_area = NULL;
     if (!is_theme_enabled(screen))

firmware/drivers/lcd-1bit-vert.c

@@ -71,6 +71,7 @@ static struct viewport default_vp =
     .y        = 0,
     .width    = LCDM(WIDTH),
     .height   = LCDM(HEIGHT),
+    .flags    = 0,
     .font     = FONT_SYSFIXED,
     .drawmode = DRMODE_SOLID,
     .buffer   = NULL,

firmware/drivers/lcd-2bit-horz.c

@@ -64,6 +64,7 @@ static struct viewport default_vp =
     .y        = 0,
     .width    = LCD_WIDTH,
     .height   = LCD_HEIGHT,
+    .flags    = 0,
     .font     = FONT_SYSFIXED,
     .drawmode = DRMODE_SOLID,
     .buffer   = NULL,

firmware/drivers/lcd-2bit-vert.c

@@ -66,6 +66,7 @@ static struct viewport default_vp =
     .y        = 0,
     .width    = LCD_WIDTH,
     .height   = LCD_HEIGHT,
+    .flags    = 0,
     .font     = FONT_SYSFIXED,
     .drawmode = DRMODE_SOLID,
     .buffer   = NULL,

firmware/drivers/lcd-2bit-vi.c

@@ -78,6 +78,7 @@ static struct viewport default_vp =
     .y        = 0,
     .width    = LCDM(WIDTH),
     .height   = LCDM(HEIGHT),
+    .flags    = 0,
     .font     = FONT_SYSFIXED,
     .drawmode = DRMODE_SOLID,
     .buffer   = NULL,

firmware/drivers/lcd-color-common.c

@@ -61,6 +61,7 @@ static struct viewport default_vp =
     .y        = 0,
     .width    = LCD_WIDTH,
     .height   = LCD_HEIGHT,
+    .flags    = 0,
     .font     = FONT_SYSFIXED,
     .drawmode = DRMODE_SOLID,
     .buffer   = NULL,

firmware/export/lcd.h

@@ -182,6 +182,8 @@ struct frame_buffer_t {
 #define VP_FLAG_VP_DIRTY     0x4000
 #define VP_FLAG_CLEAR_FLAG   0x8000
 #define VP_FLAG_VP_SET_CLEAN (VP_FLAG_CLEAR_FLAG | VP_FLAG_VP_DIRTY)
+/* flags set by viewport_set_defaults() */
+#define VP_DEFAULT_FLAGS (VP_FLAG_VP_DIRTY)
 
 struct viewport {
     int x;