devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

viewports, set flags to VP_DEFAULT_FLAGS

Browse source 
flags were getting un-initialized memory
it really didn't matter with the flags getting initialized
anyway
But once I added a new flag that didn't explicitly
set or clear the flag at init well here we are

set flags to VP_DEFAULT_FLAGS in viewport_set_defaults()

add the flags variable to the default vp's set to 0
(it was already initialized to 0 by bss, make it explicit)

Change-Id: I3a9a062455b4cf66d2b8c70fdf05402a5c0c091c
This commit is contained in:
William Wilgus 2022-04-17 10:36:33 -04:00 • committed by William Wilgus
parent 6703f43f5c
commit c4156b1909
7 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/gui/viewport.c
View file

@ -332,7 +332,7 @@ void viewport_set_defaults(struct viewport *vp,
const enum screen_type screen)
{
vp->buffer = NULL; /* use default frame_buffer */
vp->flags = VP_DEFAULT_FLAGS;
#if !defined(__PCTOOL__)
struct viewport *sbs_area = NULL;
if (!is_theme_enabled(screen))