devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

regtools/qeditor: clean-up

Browse source 
Free the backend when closing a tab to release some memory. Implement about
dialogs.

Change-Id: Ic8c500a23d38e6c3dd4de6a4ba862012925968be
This commit is contained in:
Amaury Pouly 2014-02-09 02:17:14 +01:00
parent a66a5af4db
commit b8bad8412f
4 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
utils/regtools/qeditor/mainwindow.cpp
View file

@ -34,11 +34,13 @@ MainWindow::MainWindow(Backend *backend)
QAction *load_desc_act = new QAction(QIcon::fromTheme("document-open"), tr("&Soc Description"), this); QAction *load_desc_act = new QAction(QIcon::fromTheme("document-open"), tr("&Soc Description"), this);
QAction *quit_act = new QAction(QIcon::fromTheme("application-exit"), tr("&Quit"), this); QAction *quit_act = new QAction(QIcon::fromTheme("application-exit"), tr("&Quit"), this);
QAction *about_act = new QAction(QIcon::fromTheme("help-about"), tr("&About"), this); QAction *about_act = new QAction(QIcon::fromTheme("help-about"), tr("&About"), this);
QAction *about_qt_act = new QAction(QIcon::fromTheme("help-about"), tr("About &Qt"), this);
connect(new_regtab_act, SIGNAL(triggered()), this, SLOT(OnNewRegTab())); connect(new_regtab_act, SIGNAL(triggered()), this, SLOT(OnNewRegTab()));
connect(load_desc_act, SIGNAL(triggered()), this, SLOT(OnLoadDesc())); connect(load_desc_act, SIGNAL(triggered()), this, SLOT(OnLoadDesc()));
connect(quit_act, SIGNAL(triggered()), this, SLOT(OnQuit())); connect(quit_act, SIGNAL(triggered()), this, SLOT(OnQuit()));
connect(about_act, SIGNAL(triggered()), this, SLOT(OnAbout())); connect(about_act, SIGNAL(triggered()), this, SLOT(OnAbout()));
connect(about_qt_act, SIGNAL(triggered()), this, SLOT(OnAboutQt()));
QMenu *file_menu = menuBar()->addMenu(tr("&File")); QMenu *file_menu = menuBar()->addMenu(tr("&File"));
QMenu *new_submenu = file_menu->addMenu(QIcon::fromTheme("document-new"), "&New"); QMenu *new_submenu = file_menu->addMenu(QIcon::fromTheme("document-new"), "&New");
@ -51,6 +53,7 @@ MainWindow::MainWindow(Backend *backend)
QMenu *about_menu = menuBar()->addMenu(tr("&About")); QMenu *about_menu = menuBar()->addMenu(tr("&About"));
about_menu->addAction(about_act); about_menu->addAction(about_act);
about_menu->addAction(about_qt_act);
m_tab = new MyTabWidget(); m_tab = new MyTabWidget();
@ -73,11 +76,17 @@ void MainWindow::WriteSettings()
void MainWindow::OnQuit() void MainWindow::OnQuit()
{ {
WriteSettings(); close();
} }
void MainWindow::OnAbout() void MainWindow::OnAbout()
{ {
QMessageBox::about(this, "About", "Written by Amaury Pouly for Rockbox");
}
void MainWindow::OnAboutQt()
{
QMessageBox::aboutQt(this);
} }
void MainWindow::closeEvent(QCloseEvent *event) void MainWindow::closeEvent(QCloseEvent *event)

1
utils/regtools/qeditor/mainwindow.h
View file

@ -33,6 +33,7 @@ private:
private slots: private slots:
void OnQuit(); void OnQuit();
void OnAbout(); void OnAbout();
void OnAboutQt();
void OnLoadDesc(); void OnLoadDesc();
void OnNewRegTab(); void OnNewRegTab();

5
utils/regtools/qeditor/regtab.cpp
View file

@ -204,6 +204,11 @@ RegTab::RegTab(Backend *backend)
OnDataSelChanged(DataSelNothing); OnDataSelChanged(DataSelNothing);
} }
RegTab::~RegTab()
{
delete m_io_backend;
}
void RegTab::SetDataSocName(const QString& socname) void RegTab::SetDataSocName(const QString& socname)
{ {
if(socname.size() != 0) if(socname.size() != 0)

1
utils/regtools/qeditor/regtab.h
View file

@ -76,6 +76,7 @@ class RegTab : public QSplitter
Q_OBJECT Q_OBJECT
public: public:
RegTab(Backend *backend); RegTab(Backend *backend);
~RegTab();
protected: protected:
void FillDevSubTree(DevTreeItem *item); void FillDevSubTree(DevTreeItem *item);