devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Removed the risk of getting a zero CRC for a valid file.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7503 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Daniel Stenberg 2005-09-09 07:35:09 +00:00
parent 4a939ecdcd
commit acabd28efc
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tools/songdb.pl
View file

@ -192,12 +192,12 @@ sub crc32 {
if(!$crc) { if(!$crc) {
return 0; # fixed bad CRC when disabled! return 0; # fixed bad CRC when disabled!
# better to set to 0 cause the rundb code will handle it better that way. # The runtimedb treats a CRC zero as CRC disabled!
} }
if(!open(FILE, "<$filename")) { if(!open(FILE, "<$filename")) {
print "failed to open \"$filename\" $!\n"; print "failed to open \"$filename\" $!\n";
return -2; return 0;
} }
# read $data from index $index to $buffer from the file, may return fewer # read $data from index $index to $buffer from the file, may return fewer
@ -266,8 +266,14 @@ sub crc32 {
# printf("%08x\n", $crc); # printf("%08x\n", $crc);
} }
return $crc; if($crc == 0) {
# rule out the very small risk that this actually returns a zero, as
# the current rockbox code assumes a zero CRC means it is disabled!
# TODO: fix the Rockbox code. This is just a hack.
return 1;
}
return $crc;
} }
sub singlefile { sub singlefile {