devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Removed the interrupt disabling in lcd_write_data()

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4329 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Linus Nielsen Feltzing 2004-03-02 10:01:26 +00:00
parent 68331ffb08
commit aa5b23d616
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
firmware/drivers/lcd.c
View file

@ -195,9 +195,8 @@ void lcd_write_data(unsigned char* p_bytes, int count)
byte = *p_bytes++ << 24; /* fetch to MSB position */
/* make port modifications atomic, in case an IRQ uses PBDRL */
/* (currently not the case, so this could be optimized away) */
oldlevel = set_irq_level(15);
/* This code will fail if an interrupt changes the contents of PBDRL.
If so, we must disable the interrupt here. */
/* precalculate the values for later bit toggling, init data write */
asm (
@ -287,7 +286,8 @@ void lcd_write_data(unsigned char* p_bytes, int count)
: "r0"
);
set_irq_level(oldlevel);
/* This is the place to reenable the interrupts, if we have disabled
them. See above. */
} while (--count); /* tail loop is faster */
}
@ -306,9 +306,8 @@ void lcd_write_data(unsigned char* p_bytes, int count)
the only carry add/sub which does not destroy a source register */
byte = ~(*p_bytes++ << 24); /* fetch to MSB position */
/* make port modifications atomic, in case an IRQ uses PBDRL */
/* (currently not the case, so this could be optimized away) */
oldlevel = set_irq_level(15);
/* This code will fail if an interrupt changes the contents of PBDRL.
If so, we must disable the interrupt here. */
/* precalculate the values for later bit toggling, init data write */
asm (
@ -390,7 +389,8 @@ void lcd_write_data(unsigned char* p_bytes, int count)
"r0"
);
set_irq_level(oldlevel);
/* This is the place to reenable the interrupts, if we have disabled
them. See above. */
} while (--count); /* tail loop is faster */
}