devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Don't include the .bss section in the archos rockboy overlay as well. Explicitly add common symbols to .bss section for plugins and codecs.

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8309 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jens Arnold 2006-01-08 23:45:29 +00:00
parent 07c4254135
commit a991de3730
3 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
apps/plugins/plugin.lds
View file

@ -113,6 +113,7 @@ SECTIONS
#endif #endif
{ {
*(.bss*) *(.bss*)
*(COMMON)
} > PLUGIN_RAM } > PLUGIN_RAM
/* Special trick to avoid a linker error when no other sections are /* Special trick to avoid a linker error when no other sections are

4
apps/plugins/rockboy.c
View file

@ -69,10 +69,12 @@ enum plugin_status plugin_start(struct plugin_api* api, void* parameter)
" overlay doesn't fit into memory."); " overlay doesn't fit into memory.");
return PLUGIN_ERROR; return PLUGIN_ERROR;
} }
rb->memset(header.start_addr, 0, header.end_addr - header.start_addr);
rb->lseek(fh, 0, SEEK_SET); rb->lseek(fh, 0, SEEK_SET);
readsize = rb->read(fh, header.start_addr, header.end_addr - header.start_addr); readsize = rb->read(fh, header.start_addr, header.end_addr - header.start_addr);
rb->close(fh); rb->close(fh);
if (readsize != header.end_addr - header.start_addr) if (readsize <= sizeof(header))
{ {
rb->splash(2*HZ, true, "Error loading " OVL_DISPLAYNAME " overlay."); rb->splash(2*HZ, true, "Error loading " OVL_DISPLAYNAME " overlay.");
return PLUGIN_ERROR; return PLUGIN_ERROR;

13
apps/plugins/rockboy/archos.lds
View file

@ -28,18 +28,19 @@ SECTIONS
*(.text) *(.text)
} > OVERLAY_RAM } > OVERLAY_RAM
.rodata : {
*(.rodata)
*(.rodata.str1.1)
*(.rodata.str1.4)
} > OVERLAY_RAM
.data : { .data : {
*(.data) *(.data)
} > OVERLAY_RAM } > OVERLAY_RAM
.bss : { .bss : {
*(.bss) *(.bss)
} > OVERLAY_RAM *(COMMON)
.rodata : {
*(.rodata)
*(.rodata.str1.1)
*(.rodata.str1.4)
. = ALIGN(0x4); . = ALIGN(0x4);
_ovl_end_addr = .; _ovl_end_addr = .;
} > OVERLAY_RAM } > OVERLAY_RAM