devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

text_viewer: remove unneeded code.

Browse source 
viewportmanager_theme_enable() sets values to passed viewport by viewport_set_defaults(), so no need to call sb_skin_get_info_vp() or viewport_set_defaults().

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27399 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Teruaki Kawashima 2010-07-12 13:38:40 +00:00
parent 64af2b3a16
commit a874f77e18
3 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/plugin.c
View file

@ -719,10 +719,6 @@ static const struct plugin_api rockbox_api = {
rbversion, rbversion,
#ifdef HAVE_LCD_BITMAP
sb_skin_get_info_vp,
#endif
/* new stuff at the end, sort into place next time /* new stuff at the end, sort into place next time
the API gets incompatible */ the API gets incompatible */
}; };

8
apps/plugin.h
View file

@ -145,12 +145,12 @@ void* plugin_get_buffer(size_t *buffer_size);
#define PLUGIN_MAGIC 0x526F634B /* RocK */ #define PLUGIN_MAGIC 0x526F634B /* RocK */
/* increase this every time the api struct changes */ /* increase this every time the api struct changes */
#define PLUGIN_API_VERSION 189 #define PLUGIN_API_VERSION 190
/* update this to latest version if a change to the api struct breaks /* update this to latest version if a change to the api struct breaks
backwards compatibility (and please take the opportunity to sort in any backwards compatibility (and please take the opportunity to sort in any
new function which are "waiting" at the end of the function table) */ new function which are "waiting" at the end of the function table) */
#define PLUGIN_MIN_API_VERSION 189 #define PLUGIN_MIN_API_VERSION 190
/* plugin return codes */ /* plugin return codes */
enum plugin_status { enum plugin_status {
@ -886,10 +886,6 @@ struct plugin_api {
const char *rbversion; const char *rbversion;
#ifdef HAVE_LCD_BITMAP
struct viewport *(*sb_skin_get_info_vp)(enum screen_type screen);
#endif
/* new stuff at the end, sort into place next time /* new stuff at the end, sort into place next time
the API gets incompatible */ the API gets incompatible */
}; };

5
apps/plugins/text_viewer/tv_display.c
View file

@ -322,11 +322,6 @@ static void tv_change_viewport(void)
else else
is_initialized_vp = true; is_initialized_vp = true;
if (show_statusbar)
rb->memcpy(&vp_info, rb->sb_skin_get_info_vp(SCREEN_MAIN), sizeof(struct viewport));
else
rb->viewport_set_defaults(&vp_info, SCREEN_MAIN);
rb->viewportmanager_theme_enable(SCREEN_MAIN, show_statusbar, &vp_info); rb->viewportmanager_theme_enable(SCREEN_MAIN, show_statusbar, &vp_info);
vp_info.flags &= ~VP_FLAG_ALIGNMENT_MASK; vp_info.flags &= ~VP_FLAG_ALIGNMENT_MASK;
display->set_viewport(&vp_info); display->set_viewport(&vp_info);