devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Sansa Connect: More reliable AVR communication

Browse source 
AVR requires bigger delays between retries. Read state instead of
version for synchronization purposes as it shifts more bytes.

Change-Id: Ib7fa980496d3bc7744a086b45e1865861ef58b88
This commit is contained in:
Tomasz Moń 2021-06-27 12:20:56 +02:00
parent ead4bc0769
commit a4ab636423
No known key found for this signature in database
GPG key ID: 92BA8820D4D517C8
1 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

31
firmware/target/arm/tms320dm320/sansa-connect/avr-sansaconnect.c
View file

@ -52,8 +52,8 @@
#define dbgprintf(...) #define dbgprintf(...)
#endif #endif
#define AVR_DELAY_US 100 #define AVR_DELAY_US 200
#define AVR_MAX_RETRIES 3 #define AVR_MAX_RETRIES 10
#define CMD_SYNC 0xAA #define CMD_SYNC 0xAA
#define CMD_CLOSE 0xCC #define CMD_CLOSE 0xCC
@ -428,17 +428,29 @@ static bool avr_run_command(uint8_t opcode, uint8_t *data, size_t data_length)
return success; return success;
} }
static bool avr_hid_get_state(void)
{
uint8_t state[8];
if (avr_run_command(CMD_STATE, state, sizeof(state)))
{
avr_battery_status = state[6];
avr_battery_level = state[7];
parse_button_state(state);
return true;
}
return false;
}
static bool avr_hid_sync(void) static bool avr_hid_sync(void)
{ {
uint8_t data;
int retry; int retry;
for (retry = 0; retry < AVR_MAX_RETRIES; retry++) for (retry = 0; retry < AVR_MAX_RETRIES; retry++)
{ {
if (avr_run_command(CMD_VER, &data, sizeof(data))) if (avr_hid_get_state())
{ {
return true; return true;
} }
mdelay(100);
} }
/* TODO: Program HID as it appears to be not programmed. /* TODO: Program HID as it appears to be not programmed.
* To do so, unfortunately, AVR firmware would have to be written * To do so, unfortunately, AVR firmware would have to be written
@ -509,17 +521,6 @@ bool charging_state(void)
return (avr_battery_status & BATTERY_STATUS_CHARGING) != 0; return (avr_battery_status & BATTERY_STATUS_CHARGING) != 0;
} }
static void avr_hid_get_state(void)
{
uint8_t state[8];
if (avr_execute_command(CMD_STATE, state, sizeof(state)))
{
avr_battery_status = state[6];
avr_battery_level = state[7];
parse_button_state(state);
}
}
static uint32_t avr_hid_get_monotime(void) static uint32_t avr_hid_get_monotime(void)
{ {
uint8_t tmp[4]; uint8_t tmp[4];