forked from len0rd/rockbox
iPod - Initial skeleton of an audio driver
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8248 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Dave Chapman
parent
d22938286e
commit
a472ed5114
4 changed files with 404 additions and 10 deletions
|
|
@ -143,6 +143,8 @@ drivers/lcd-h100-remote.c
|
||||||
#endif
|
#endif
|
||||||
#if defined(HAVE_UDA1380) && !defined(SIMULATOR)
|
#if defined(HAVE_UDA1380) && !defined(SIMULATOR)
|
||||||
drivers/uda1380.c
|
drivers/uda1380.c
|
||||||
|
#elif defined(HAVE_WM8975) && !defined(SIMULATOR)
|
||||||
|
drivers/wm8975.c
|
||||||
#elif defined(HAVE_TLV320) && !defined(SIMULATOR)
|
#elif defined(HAVE_TLV320) && !defined(SIMULATOR)
|
||||||
drivers/tlv320.c
|
drivers/tlv320.c
|
||||||
#endif
|
#endif
|
||||||
|
|
|
||||||
249
firmware/drivers/wm8975.c
Normal file
249
firmware/drivers/wm8975.c
Normal file
|
|
@ -0,0 +1,249 @@
|
||||||
|
/***************************************************************************
|
||||||
|
* __________ __ ___.
|
||||||
|
* Open \______ \ ____ ____ | | _\_ |__ _______ ___
|
||||||
|
* Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
|
||||||
|
* Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < <
|
||||||
|
* Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
|
||||||
|
* \/ \/ \/ \/ \/
|
||||||
|
* $Id$
|
||||||
|
*
|
||||||
|
* Copyright (C) 2005 by Dave Chapman
|
||||||
|
*
|
||||||
|
* Based on code from the iPodLinux project (C) 2003-2005 Bernard Leach
|
||||||
|
*
|
||||||
|
* All files in this archive are subject to the GNU General Public License.
|
||||||
|
* See the file COPYING in the source tree root for full license agreement.
|
||||||
|
*
|
||||||
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
||||||
|
* KIND, either express or implied.
|
||||||
|
*
|
||||||
|
****************************************************************************/
|
||||||
|
#include "lcd.h"
|
||||||
|
#include "cpu.h"
|
||||||
|
#include "kernel.h"
|
||||||
|
#include "thread.h"
|
||||||
|
#include "power.h"
|
||||||
|
#include "debug.h"
|
||||||
|
#include "system.h"
|
||||||
|
#include "sprintf.h"
|
||||||
|
#include "button.h"
|
||||||
|
#include "string.h"
|
||||||
|
#include "file.h"
|
||||||
|
#include "buffer.h"
|
||||||
|
#include "audio.h"
|
||||||
|
|
||||||
|
#include "i2c-pp5020.h"
|
||||||
|
#include "wm8975.h"
|
||||||
|
#include "pcf50605.h"
|
||||||
|
|
||||||
|
void wm8975_reset(void);
|
||||||
|
|
||||||
|
#define IPOD_PCM_LEVEL 0x65 /* -6dB */
|
||||||
|
|
||||||
|
#define RESET (0x0f<<1)
|
||||||
|
#define PWRMGMT1 (0x19<<1)
|
||||||
|
#define PWRMGMT2 (0x1a<<1)
|
||||||
|
#define AINTFCE (0x07<<1)
|
||||||
|
#define LOUT1VOL (0x02<<1)
|
||||||
|
#define ROUT1VOL (0x03<<1)
|
||||||
|
#define LOUT2VOL (0x28<<1)
|
||||||
|
#define ROUT2VOL (0x29<<1)
|
||||||
|
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Reset the I2S BIT.FORMAT I2S, 16bit, FIFO.FORMAT 32bit
|
||||||
|
*/
|
||||||
|
static void i2s_reset(void)
|
||||||
|
{
|
||||||
|
/* PP502x */
|
||||||
|
|
||||||
|
/* I2S soft reset */
|
||||||
|
outl(inl(0x70002800) | 0x80000000, 0x70002800);
|
||||||
|
outl(inl(0x70002800) & ~0x80000000, 0x70002800);
|
||||||
|
|
||||||
|
/* BIT.FORMAT [11:10] = I2S (default) */
|
||||||
|
outl(inl(0x70002800) & ~0xc00, 0x70002800);
|
||||||
|
/* BIT.SIZE [9:8] = 16bit (default) */
|
||||||
|
outl(inl(0x70002800) & ~0x300, 0x70002800);
|
||||||
|
|
||||||
|
/* FIFO.FORMAT [6:4] = 32 bit LSB */
|
||||||
|
/* since BIT.SIZ < FIFO.FORMAT low 16 bits will be 0 */
|
||||||
|
outl(inl(0x70002800) | 0x30, 0x70002800);
|
||||||
|
|
||||||
|
/* RX_ATN_LVL=1 == when 12 slots full */
|
||||||
|
/* TX_ATN_LVL=1 == when 12 slots empty */
|
||||||
|
outl(inl(0x7000280c) | 0x33, 0x7000280c);
|
||||||
|
|
||||||
|
/* Rx.CLR = 1, TX.CLR = 1 */
|
||||||
|
outl(inl(0x7000280c) | 0x1100, 0x7000280c);
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Initialise the WM8975 for playback via headphone and line out.
|
||||||
|
* Note, I'm using the WM8750 datasheet as its apparently close.
|
||||||
|
*/
|
||||||
|
int wm8975_init(void) {
|
||||||
|
/* reset I2C */
|
||||||
|
i2c_init();
|
||||||
|
|
||||||
|
/* normal outputs for CDI and I2S pin groups */
|
||||||
|
outl(inl(0x70000020) & ~0x300, 0x70000020);
|
||||||
|
|
||||||
|
/*mini2?*/
|
||||||
|
outl(inl(0x70000010) & ~0x3000000, 0x70000010);
|
||||||
|
/*mini2?*/
|
||||||
|
|
||||||
|
/* device reset */
|
||||||
|
outl(inl(0x60006004) | 0x800, 0x60006004);
|
||||||
|
outl(inl(0x60006004) & ~0x800, 0x60006004);
|
||||||
|
|
||||||
|
/* device enable */
|
||||||
|
outl(inl(0x6000600C) | 0x807, 0x6000600C);
|
||||||
|
|
||||||
|
/* enable external dev clock clocks */
|
||||||
|
outl(inl(0x6000600c) | 0x2, 0x6000600c);
|
||||||
|
|
||||||
|
/* external dev clock to 24MHz */
|
||||||
|
outl(inl(0x70000018) & ~0xc, 0x70000018);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Silently enable / disable audio output */
|
||||||
|
void wm8975_enable_output(bool enable)
|
||||||
|
{
|
||||||
|
if (enable)
|
||||||
|
{
|
||||||
|
/* reset the I2S controller into known state */
|
||||||
|
i2s_reset();
|
||||||
|
|
||||||
|
/*
|
||||||
|
* 1. Switch on power supplies.
|
||||||
|
* By default the WM8750L is in Standby Mode, the DAC is
|
||||||
|
* digitally muted and the Audio Interface, Line outputs
|
||||||
|
* and Headphone outputs are all OFF (DACMU = 1 Power
|
||||||
|
* Management registers 1 and 2 are all zeros).
|
||||||
|
*/
|
||||||
|
ipod_i2c_send(0x1a, RESET | 1, 0xff); /*Reset*/
|
||||||
|
ipod_i2c_send(0x1a, RESET, 0x0);
|
||||||
|
|
||||||
|
/* 2. Enable Vmid and VREF. */
|
||||||
|
ipod_i2c_send(0x1a, PWRMGMT1, 0xc0); /*Pwr Mgmt(1)*/
|
||||||
|
|
||||||
|
/* 3. Enable DACs as required. */
|
||||||
|
ipod_i2c_send(0x1a, PWRMGMT2 | 0x1, 0x80); /*Pwr Mgmt(2)*/
|
||||||
|
|
||||||
|
/* 4. Enable line and / or headphone output buffers as required. */
|
||||||
|
ipod_i2c_send(0x1a, PWRMGMT2 | 0x1, 0xf8); /*Pwr Mgmt(2)*/
|
||||||
|
|
||||||
|
/* BCLKINV=0(Dont invert BCLK) MS=1(Enable Master) LRSWAP=0 LRP=0 */
|
||||||
|
/* IWL=00(16 bit) FORMAT=10(I2S format) */
|
||||||
|
ipod_i2c_send(0x1a, AINTFCE, 0x42);
|
||||||
|
|
||||||
|
/* The iPod can handle multiple frequencies, but fix at 44.1KHz for now */
|
||||||
|
wm8975_set_sample_rate(WM8975_44100HZ);
|
||||||
|
|
||||||
|
/* set the volume to -6dB */
|
||||||
|
ipod_i2c_send(0x1a, LOUT1VOL, IPOD_PCM_LEVEL);
|
||||||
|
ipod_i2c_send(0x1a, ROUT1VOL | 0x1, IPOD_PCM_LEVEL);
|
||||||
|
ipod_i2c_send(0x1a, LOUT1VOL, IPOD_PCM_LEVEL);
|
||||||
|
ipod_i2c_send(0x1a, ROUT1VOL | 0x1, IPOD_PCM_LEVEL);
|
||||||
|
|
||||||
|
ipod_i2c_send(0x1a, 0x45, 0x50); /* Left out Mix(def) */
|
||||||
|
ipod_i2c_send(0x1a, 0x46, 0x50);
|
||||||
|
|
||||||
|
ipod_i2c_send(0x1a, 0x48, 0x50); /* Right out Mix(def) */
|
||||||
|
ipod_i2c_send(0x1a, 0x4b, 0x50);
|
||||||
|
|
||||||
|
ipod_i2c_send(0x1a, 0x4c, 0x0); /* Mono out Mix */
|
||||||
|
ipod_i2c_send(0x1a, 0x4e, 0x0);
|
||||||
|
|
||||||
|
wm8975_mute(0);
|
||||||
|
} else {
|
||||||
|
wm8975_mute(1);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
int wm8975_set_master_vol(int vol_l, int vol_r)
|
||||||
|
{
|
||||||
|
/* +6 to -73dB 1dB steps (plus mute == 80levels) 7bits */
|
||||||
|
/* 1111111 == +6dB */
|
||||||
|
/* 1111001 == 0dB */
|
||||||
|
/* 0110000 == -73dB */
|
||||||
|
/* 0101111 == mute (0x2f) */
|
||||||
|
|
||||||
|
/* OUT1 */
|
||||||
|
ipod_i2c_send(0x1a, LOUT1VOL, vol_l);
|
||||||
|
ipod_i2c_send(0x1a, ROUT1VOL | 0x1, vol_r);
|
||||||
|
|
||||||
|
/* OUT2 */
|
||||||
|
ipod_i2c_send(0x1a, LOUT2VOL, vol_l);
|
||||||
|
ipod_i2c_send(0x1a, ROUT2VOL | 0x1, vol_r);
|
||||||
|
}
|
||||||
|
|
||||||
|
int wm8975_set_mixer_vol(int channel1, int channel2)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_set_bass(int value)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_set_treble(int value)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
int wm8975_mute(int mute)
|
||||||
|
{
|
||||||
|
if (mute)
|
||||||
|
{
|
||||||
|
/* Set DACMU = 1 to soft-mute the audio DACs. */
|
||||||
|
ipod_i2c_send(0x1a, 0xa, 0x8);
|
||||||
|
} else {
|
||||||
|
/* Set DACMU = 0 to soft-un-mute the audio DACs. */
|
||||||
|
ipod_i2c_send(0x1a, 0xa, 0x0);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Nice shutdown of WM8975 codec */
|
||||||
|
void wm8975_close(void)
|
||||||
|
{
|
||||||
|
/* 1. Set DACMU = 1 to soft-mute the audio DACs. */
|
||||||
|
ipod_i2c_send(0x1a, 0xa, 0x8);
|
||||||
|
|
||||||
|
/* 2. Disable all output buffers. */
|
||||||
|
ipod_i2c_send(0x1a, 0x34, 0x0); /*Pwr Mgmt(2)*/
|
||||||
|
|
||||||
|
/* 3. Switch off the power supplies. */
|
||||||
|
ipod_i2c_send(0x1a, 0x32, 0x0); /*Pwr Mgmt(1)*/
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Change the order of the noise shaper, 5th order is recommended above 32kHz */
|
||||||
|
void wm8975_set_nsorder(int order)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Note: Disable output before calling this function */
|
||||||
|
void wm8975_set_sample_rate(int sampling_control) {
|
||||||
|
|
||||||
|
ipod_i2c_send(0x1a, 0x10, sampling_control);
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_enable_recording(bool source_mic) {
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_disable_recording(void) {
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_set_recvol(int left, int right, int type) {
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
void wm8975_set_monitor(int enable) {
|
||||||
|
|
||||||
|
}
|
||||||
52
firmware/export/wm8975.h
Normal file
52
firmware/export/wm8975.h
Normal file
|
|
@ -0,0 +1,52 @@
|
||||||
|
/***************************************************************************
|
||||||
|
* __________ __ ___.
|
||||||
|
* Open \______ \ ____ ____ | | _\_ |__ _______ ___
|
||||||
|
* Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ /
|
||||||
|
* Jukebox | | ( <_> ) \___| < | \_\ ( <_> > < <
|
||||||
|
* Firmware |____|_ /\____/ \___ >__|_ \|___ /\____/__/\_ \
|
||||||
|
* \/ \/ \/ \/ \/
|
||||||
|
* $Id$
|
||||||
|
*
|
||||||
|
* Copyright (C) 2005 by Dave Chapman
|
||||||
|
*
|
||||||
|
* All files in this archive are subject to the GNU General Public License.
|
||||||
|
* See the file COPYING in the source tree root for full license agreement.
|
||||||
|
*
|
||||||
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
||||||
|
* KIND, either express or implied.
|
||||||
|
*
|
||||||
|
****************************************************************************/
|
||||||
|
|
||||||
|
#ifndef _WM8975_H
|
||||||
|
#define _WM8975_H
|
||||||
|
|
||||||
|
extern void wm8975_reset(void);
|
||||||
|
extern int wm8975_init(void);
|
||||||
|
extern void wm8975_enable_output(bool enable);
|
||||||
|
extern int wm8975_set_master_vol(int vol_l, int vol_r);
|
||||||
|
extern int wm8975_set_mixer_vol(int channel1, int channel2);
|
||||||
|
extern void wm8975_set_bass(int value);
|
||||||
|
extern void wm8975_set_treble(int value);
|
||||||
|
extern int wm8975_mute(int mute);
|
||||||
|
extern void wm8975_close(void);
|
||||||
|
extern void wm8975_set_nsorder(int order);
|
||||||
|
extern void wm8975_set_sample_rate(int sampling_control);
|
||||||
|
|
||||||
|
extern void wm8975_enable_recording(bool source_mic);
|
||||||
|
extern void wm8975_disable_recording(void);
|
||||||
|
extern void wm8975_set_recvol(int left, int right, int type);
|
||||||
|
extern void wm8975_set_monitor(int enable);
|
||||||
|
|
||||||
|
/* Register settings for the supported samplerates: */
|
||||||
|
#define WM8975_8000HZ 0x4d
|
||||||
|
#define WM8975_12000HZ 0x61
|
||||||
|
#define WM8975_16000HZ 0x55
|
||||||
|
#define WM8975_22050HZ 0x77
|
||||||
|
#define WM8975_24000HZ 0x79
|
||||||
|
#define WM8975_32000HZ 0x59
|
||||||
|
#define WM8975_44100HZ 0x63
|
||||||
|
#define WM8975_48000HZ 0x41
|
||||||
|
#define WM8975_88200HZ 0x7f
|
||||||
|
#define WM8975_96000HZ 0x5d
|
||||||
|
|
||||||
|
#endif /* _WM8975_H */
|
||||||
|
|
@ -26,6 +26,8 @@
|
||||||
#include "i2c.h"
|
#include "i2c.h"
|
||||||
#if defined(HAVE_UDA1380)
|
#if defined(HAVE_UDA1380)
|
||||||
#include "uda1380.h"
|
#include "uda1380.h"
|
||||||
|
#elif defined(HAVE_WM8975)
|
||||||
|
#include "wm8975.h"
|
||||||
#elif defined(HAVE_TLV320)
|
#elif defined(HAVE_TLV320)
|
||||||
#include "tlv320.h"
|
#include "tlv320.h"
|
||||||
#endif
|
#endif
|
||||||
|
|
@ -343,50 +345,139 @@ void pcm_init(void)
|
||||||
|
|
||||||
#elif defined(HAVE_WM8975)
|
#elif defined(HAVE_WM8975)
|
||||||
|
|
||||||
/* TODO: Implement for iPod - we should probably move the UDA1380 and
|
/* We need to unify this code with the uda1380 code as much as possible, but
|
||||||
WM8975 specific code into separate files.
|
we will keep it separate during early development.
|
||||||
|
|
||||||
For now, just implement some dummy functions.
|
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
static bool pcm_playing;
|
||||||
|
static bool pcm_paused;
|
||||||
|
static int pcm_freq = 0x6; /* 44.1 is default */
|
||||||
|
|
||||||
|
static unsigned char *next_start;
|
||||||
|
static long next_size;
|
||||||
|
|
||||||
|
/* Set up the DMA transfer that kicks in when the audio FIFO gets empty */
|
||||||
|
static void dma_start(const void *addr, long size)
|
||||||
|
{
|
||||||
|
pcm_playing = true;
|
||||||
|
|
||||||
|
addr = (void *)((unsigned long)addr & ~3); /* Align data */
|
||||||
|
size &= ~3; /* Size must be multiple of 4 */
|
||||||
|
|
||||||
|
return;
|
||||||
|
|
||||||
|
/* This is the uda1380 code */
|
||||||
|
#if 0
|
||||||
|
/* Reset the audio FIFO */
|
||||||
|
|
||||||
|
/* Set up DMA transfer */
|
||||||
|
SAR0 = ((unsigned long)addr); /* Source address */
|
||||||
|
DAR0 = (unsigned long)&PDOR3; /* Destination address */
|
||||||
|
BCR0 = size; /* Bytes to transfer */
|
||||||
|
|
||||||
|
/* Enable the FIFO and force one write to it */
|
||||||
|
IIS2CONFIG = IIS_DEFPARM(pcm_freq);
|
||||||
|
|
||||||
|
DCR0 = DMA_INT | DMA_EEXT | DMA_CS | DMA_SINC | DMA_START;
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Stops the DMA transfer and interrupt */
|
||||||
|
static void dma_stop(void)
|
||||||
|
{
|
||||||
|
pcm_playing = false;
|
||||||
|
|
||||||
|
#if 0
|
||||||
|
/* This is the uda1380 code */
|
||||||
|
DCR0 = 0;
|
||||||
|
DSR0 = 1;
|
||||||
|
/* Reset the FIFO */
|
||||||
|
IIS2CONFIG = IIS_RESET | IIS_DEFPARM(pcm_freq);
|
||||||
|
#endif
|
||||||
|
next_start = NULL;
|
||||||
|
next_size = 0;
|
||||||
|
pcm_paused = false;
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
void pcm_init(void)
|
void pcm_init(void)
|
||||||
{
|
{
|
||||||
|
pcm_playing = false;
|
||||||
|
pcm_paused = false;
|
||||||
|
|
||||||
|
/* Initialize default register values. */
|
||||||
|
wm8975_init();
|
||||||
|
|
||||||
|
/* The uda1380 needs a sleep(HZ) here - do we need one? */
|
||||||
|
|
||||||
|
/* Power on */
|
||||||
|
wm8975_enable_output(true);
|
||||||
|
|
||||||
|
/* Unmute the master channel (DAC should be at zero point now). */
|
||||||
|
wm8975_mute(false);
|
||||||
|
|
||||||
|
/* Call dma_stop to initialize everything. */
|
||||||
|
dma_stop();
|
||||||
}
|
}
|
||||||
|
|
||||||
void pcm_set_frequency(unsigned int frequency)
|
void pcm_set_frequency(unsigned int frequency)
|
||||||
{
|
{
|
||||||
(void)frequency;
|
(void)frequency;
|
||||||
|
pcm_freq=frequency;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* the registered callback function to ask for more mp3 data */
|
||||||
|
static void (*callback_for_more)(unsigned char**, long*) = NULL;
|
||||||
|
|
||||||
void pcm_play_data(void (*get_more)(unsigned char** start, long* size))
|
void pcm_play_data(void (*get_more)(unsigned char** start, long* size))
|
||||||
{
|
{
|
||||||
(void)get_more;
|
unsigned char *start;
|
||||||
|
long size;
|
||||||
|
|
||||||
|
callback_for_more = get_more;
|
||||||
|
|
||||||
|
get_more((unsigned char **)&start, (long *)&size);
|
||||||
|
get_more(&next_start, &next_size);
|
||||||
|
|
||||||
|
dma_start(start, size);
|
||||||
}
|
}
|
||||||
|
|
||||||
void pcm_play_stop(void)
|
void pcm_play_stop(void)
|
||||||
{
|
{
|
||||||
|
if (pcm_playing) {
|
||||||
|
dma_stop();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void pcm_play_pause(bool play)
|
void pcm_play_pause(bool play)
|
||||||
{
|
{
|
||||||
(void)play;
|
if(pcm_paused && play && next_size)
|
||||||
|
{
|
||||||
|
logf("unpause");
|
||||||
|
/* We need to enable DMA here */
|
||||||
|
}
|
||||||
|
else if(!pcm_paused && !play)
|
||||||
|
{
|
||||||
|
logf("pause");
|
||||||
|
/* We need to disable DMA here */
|
||||||
|
}
|
||||||
|
pcm_paused = !play;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool pcm_is_paused(void)
|
bool pcm_is_paused(void)
|
||||||
{
|
{
|
||||||
return false;
|
return pcm_paused;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool pcm_is_playing(void)
|
bool pcm_is_playing(void)
|
||||||
{
|
{
|
||||||
return false;
|
return pcm_playing;
|
||||||
}
|
}
|
||||||
|
|
||||||
void pcm_calculate_peaks(int *left, int *right)
|
void pcm_calculate_peaks(int *left, int *right)
|
||||||
{
|
{
|
||||||
(void)left;
|
*left=0;
|
||||||
(void)right;
|
*right=0;
|
||||||
}
|
}
|
||||||
|
|
||||||
long pcm_get_bytes_waiting(void)
|
long pcm_get_bytes_waiting(void)
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue