devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

[Bugfix?] tagtree build_firstletter_menu dst src overlap

Browse source 
pretty sure this is a false positive by gcc but we know what we expect
to recieve so add a small buffer to shut gcc up

Change-Id: Ibbd7c995ec2f0ade4bfbcb1d659f1cae5d4f1de3
This commit is contained in:
William Wilgus 2024-12-11 19:17:08 -05:00 • committed by William Wilgus
parent c3fad37827
commit a3ef7b73b8
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
apps/tagtree.c
View file

@ -1082,10 +1082,15 @@ static bool alloc_menu_parse_buf(char *buf, int type)
static void build_firstletter_menu(char *buf, size_t bufsz)
{
#if 0 /* GCC complains about this I can't find a definitive answer */
const char *subitem = buf;
size_t l = strlen(buf) + 1;
buf+=l;
bufsz-=l;
#else
char subitem[32]; /* canonicalartist longest subitem we expect add a bit extra..*/
strmemccpy(subitem, buf, sizeof(subitem));
#endif
const char * const fmt ="\"%s\"-> %s ? %s %c\"%c\"-> %s =\"fmt_title\"";
const char * const showsub = /* album subitem for canonicalartist */