devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Fix vroken logic that _could_ lead to memory corruption though it was very unlikely

Browse source 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15281 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Nils Wallménius 2007-10-23 15:00:45 +00:00
parent eed41ff985
commit a3117328e9
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
apps/plugins/midi/midiplay.c
View file

@ -89,7 +89,7 @@ PLUGIN_IRAM_DECLARE
struct MIDIfile * mf IBSS_ATTR; struct MIDIfile * mf IBSS_ATTR;
int numberOfSamples IBSS_ATTR; int numberOfSamples IBSS_ATTR; /* the number of samples in the current tick */
long bpm IBSS_ATTR; long bpm IBSS_ATTR;
int32_t gmbuf[BUF_SIZE*NBUF]; int32_t gmbuf[BUF_SIZE*NBUF];
@ -150,7 +150,7 @@ bool lastswap=1;
static inline void synthbuf(void) static inline void synthbuf(void)
{ {
int32_t *outptr; int32_t *outptr;
int i; int i=BUF_SIZE;
#ifndef SYNC #ifndef SYNC
if(lastswap==swap) return; if(lastswap==swap) return;
@ -162,7 +162,7 @@ static inline void synthbuf(void)
#endif #endif
/* synth samples for as many whole ticks as we can fit in the buffer */ /* synth samples for as many whole ticks as we can fit in the buffer */
for(i=0; i < BUF_SIZE/numberOfSamples; i++) for(; i >= numberOfSamples; i -= numberOfSamples)
{ {
synthSamples((int32_t*)outptr, numberOfSamples); synthSamples((int32_t*)outptr, numberOfSamples);
outptr += numberOfSamples; outptr += numberOfSamples;
@ -171,7 +171,7 @@ static inline void synthbuf(void)
} }
/* how many samples did we write to the buffer? */ /* how many samples did we write to the buffer? */
samples_in_buf = BUF_SIZE-(BUF_SIZE%numberOfSamples); samples_in_buf = BUF_SIZE-i;
} }