From a30f5e4b6439e214f032266f80e02ea3d336b783 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Wed, 13 Aug 2008 21:38:33 +0000 Subject: [PATCH] gcc 4.3.1 quite rightfully warnings when printf-style functions use "format not a string literal and no format arguments". Those occurances can (will?) lead to future nasty and surprising bugs. These are just a few of a very large amount of necessary fixes. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18274 a1c6a512-1295-4272-9138-f99709370657 --- apps/menus/playback_menu.c | 4 ++-- firmware/panic.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/menus/playback_menu.c b/apps/menus/playback_menu.c index 8d5c0eeee6..0d5a85483c 100644 --- a/apps/menus/playback_menu.c +++ b/apps/menus/playback_menu.c @@ -143,7 +143,7 @@ static int audioscrobbler_callback(int action,const struct menu_item_ex *this_it { case ACTION_EXIT_MENUITEM: /* on exit */ if (!scrobbler_is_enabled() && global_settings.audioscrobbler) - gui_syncsplash(HZ*2, ID2P(LANG_PLEASE_REBOOT)); + gui_syncsplash(HZ*2, "%s", ID2P(LANG_PLEASE_REBOOT)); if(scrobbler_is_enabled() && !global_settings.audioscrobbler) scrobbler_shutdown(); @@ -161,7 +161,7 @@ static int cuesheet_callback(int action,const struct menu_item_ex *this_item) { case ACTION_EXIT_MENUITEM: /* on exit */ if (!cuesheet_is_enabled() && global_settings.cuesheet) - gui_syncsplash(HZ*2, ID2P(LANG_PLEASE_REBOOT)); + gui_syncsplash(HZ*2, "%s", ID2P(LANG_PLEASE_REBOOT)); break; } return action; diff --git a/firmware/panic.c b/firmware/panic.c index 1791420139..e66676c1c2 100644 --- a/firmware/panic.c +++ b/firmware/panic.c @@ -80,7 +80,7 @@ void panicf( const char *fmt, ...) /* no LCD */ #endif lcd_update(); - DEBUGF(panic_buf); + DEBUGF("%s", panic_buf); set_cpu_frequency(0);