devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Fix sanity check in UnwStartThumb() using the wrong register

Browse source 
cppcheck reported:
[lib/unwarminder/unwarm_thumb.c:399] -> [lib/unwarminder/unwarm_thumb.c:399]: (style) Same expression on both sides of '&&'.

Patch will also be sent to the upstream project.

Change-Id: I57033f290135f4dc09ac7e9b07c31461bc5b471a
Reviewed-on: http://gerrit.rockbox.org/157
Reviewed-by: Thomas Jarosch <tomj@simonv.com>
This commit is contained in:
Thomas Jarosch 2012-02-29 19:08:43 +01:00
parent 5bfbc64151
commit 9476883d2d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/unwarminder/unwarm_thumb.c
View file

@ -396,7 +396,7 @@ UnwResult UnwStartThumb(UnwState * const state)
case 12: /* ORR */
case 13: /* MUL */
case 14: /* BIC */
if(M_IsOriginValid(state->regData[rs].o) && M_IsOriginValid(state->regData[rs].o))
if(M_IsOriginValid(state->regData[rd].o) && M_IsOriginValid(state->regData[rs].o))
{
state->regData[rd].o = state->regData[rs].o;
state->regData[rd].o |= REG_VAL_ARITHMETIC;