devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

[BugFix] Fix some Shif related UB -- ASAN

Browse source 
these are the low hanging fruit identified by ASAN

cast the byte values before shift

Change-Id: Ifc5645354a10c15ccd09d1343e1705857a51e011
This commit is contained in:
William Wilgus 2023-01-04 21:52:59 -05:00
parent ea33e66021
commit 9367ef1ed6
3 changed files with 22 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
firmware/export/pcm_sampr.h
View file

@ -427,10 +427,10 @@ extern const unsigned long rec_freq_sampr[REC_NUM_FREQ];
#ifdef CONFIG_SAMPR_TYPES
#define SAMPR_TYPE_MASK (0xff << 24)
#define SAMPR_TYPE_PLAY (0x00 << 24)
#define SAMPR_TYPE_MASK (0xffu << 24)
#define SAMPR_TYPE_PLAY (0x00u << 24)
#ifdef HAVE_RECORDING
#define SAMPR_TYPE_REC (0x01 << 24)
#define SAMPR_TYPE_REC (0x01u << 24)
#endif
#ifndef PCM_SAMPR_CONFIG_ONLY