devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

PictureFlow: Add move callback for buflib allocations

Browse source 
If we don't provide a callback to buflib_alloc(),
the buffer is always movable (to reduce fragmentation).

Since we pass our buffer to functions that call yield(),
this could lead to memory corruption on buflib compaction.

Change-Id: Id1fad1822479d692551c55cb8bc87cea7b78f759
This commit is contained in:
Thomas Jarosch 2015-01-01 23:45:24 +01:00
parent b0277e4b6d
commit 9076b433d1
2 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
firmware/buflib.c
View file

@ -677,7 +677,7 @@ buflib_free(struct buflib_context *ctx, int handle_num)
else
{
/* Otherwise, set block to the newly-freed block, and mark it free, before
* continuing on, since the code below exects block to point to a free
* continuing on, since the code below expects block to point to a free
* block which may have free space after it.
*/
block = freed_block;