devs/foxbox
1
0
Fork 0
forked from len0rd/rockbox
Code Pull requests Activity

Improve transition between plugin and WPS

Browse source 
Eliminate flashing when plugins are launched
from WPS, by not enabling the SBS, and by
deferring other lcd updates.

Also prevents flashing root menu activity when
returning from plugins.

Change-Id: I7d761867027f2275c4ab8e16ada3107c7ba0be6e
This commit is contained in:
Christian Soffke 2022-12-12 03:49:06 +01:00
parent 0e2e9df991
commit 8ff2c81bde
6 changed files with 109 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

17
apps/plugin.c
View file

@ -894,14 +894,16 @@ int plugin_load(const char* plugin, const void* parameter)
*(p_hdr->api) = &rockbox_api;
lcd_set_viewport(NULL);
lcd_clear_display();
lcd_update();
#ifdef HAVE_REMOTE_LCD
lcd_remote_set_viewport(NULL);
lcd_remote_clear_display();
lcd_remote_update();
#endif
push_current_activity(ACTIVITY_PLUGIN);
if (get_current_activity() == ACTIVITY_WPS)
push_activity_without_refresh(ACTIVITY_PLUGIN);
else
push_current_activity(ACTIVITY_PLUGIN);
/* some plugins assume the entry cache doesn't move and save pointers to it
* they should be fixed properly instead of this lock */
tree_lock_cache(tree_get_context());
@ -922,7 +924,16 @@ int plugin_load(const char* plugin, const void* parameter)
int rc = p_hdr->entry_point(parameter);
tree_unlock_cache(tree_get_context());
pop_current_activity(ACTIVITY_REFRESH_NOW);
pop_current_activity(ACTIVITY_REFRESH_DEFERRED);
int curr_activity = get_current_activity();
if ((curr_activity != ACTIVITY_PLAYLISTVIEWER) &&
(curr_activity != ACTIVITY_WPS) &&
(rc != PLUGIN_GOTO_WPS))
{
FOR_NB_SCREENS(i)
skin_update(CUSTOM_STATUSBAR, i, SKIN_REFRESH_ALL);
}
if (!pfn_tsr_exit)
{ /* close handle if plugin is no tsr one */