From 8ef4f217d4659bbdfe0636eb1ea8a611faf6500f Mon Sep 17 00:00:00 2001
From: Solomon Peachy <pizza@shaftnet.org>
Date: Fri, 7 Mar 2025 09:39:53 -0500
Subject: [PATCH] checkwps: Warn if using SYSFONT in a viewport

Change-Id: Ief69dd489d08af62ed96624dfe504ab5b9f9e6d9
---
 apps/gui/skin_engine/skin_parser.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c
index 3956e53d51..ec043aef48 100644
--- a/apps/gui/skin_engine/skin_parser.c
+++ b/apps/gui/skin_engine/skin_parser.c
@@ -1071,11 +1071,7 @@ static int parse_progressbar_tag(struct skin_element* element,
             pb->height = -1; /* calculate at display time */
         else
         {
-#ifndef __PCTOOL__
             pb->height = font_get(vp->font)->height;
-#else
-            pb->height = 8;
-#endif
         }
     }
     /* optional params, first is the image filename if it isnt recognised as a keyword */
@@ -2164,6 +2160,10 @@ static bool skin_load_fonts(struct wps_data *data)
         else if (font_id <= 0)
         {
             vp->font = FONT_SYSFIXED;
+            DEBUGF("WARNING: Do not use SYSFONT (id 0) in viewports!\n");
+#ifdef __PCTOOL__
+//            success = false;
+#endif
             continue;
         }
 
@@ -2190,7 +2190,7 @@ static bool skin_load_fonts(struct wps_data *data)
             font->id = font_load_ex(path, 0, skinfonts[font_id-2].glyphs);
 
 #else
-                font->id = font_load(path);
+            font->id = font_load(path);
 #endif
             //printf("[%d] %s -> %d\n",font_id, font->name, font->id);
             id_array[font_count++] = font->id;